diff options
| author | xiphon <xiphon@protonmail.com> | 2020-02-01 14:21:33 +0000 |
|---|---|---|
| committer | xiphon <xiphon@protonmail.com> | 2020-02-01 14:21:33 +0000 |
| commit | 742a4659f4624efedb3bf6c288db77b4abd66baa (patch) | |
| tree | 9407048cb2a9bdafcef4dbb454604b55c555932a /src/libwalletqt/AddressBook.h | |
| parent | 6de8547047d5801181b61cbbc707a44a4ee5e77b (diff) | |
| download | monzero-gui-742a4659f4624efedb3bf6c288db77b4abd66baa.tar.gz monzero-gui-742a4659f4624efedb3bf6c288db77b4abd66baa.tar.xz monzero-gui-742a4659f4624efedb3bf6c288db77b4abd66baa.zip | |
AddressBook: thread-safety, fix use-after-free
Diffstat (limited to 'src/libwalletqt/AddressBook.h')
| -rw-r--r-- | src/libwalletqt/AddressBook.h | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/libwalletqt/AddressBook.h b/src/libwalletqt/AddressBook.h index 84566615..1d9309b3 100644 --- a/src/libwalletqt/AddressBook.h +++ b/src/libwalletqt/AddressBook.h @@ -31,6 +31,7 @@ #include <wallet/api/wallet2_api.h> #include <QObject> +#include <QReadWriteLock> #include <QList> #include <QDateTime> @@ -43,10 +44,9 @@ class AddressBook : public QObject { Q_OBJECT public: - Q_INVOKABLE QList<Monero::AddressBookRow*> getAll(bool update = false) const; - Q_INVOKABLE Monero::AddressBookRow * getRow(int index) const; - Q_INVOKABLE bool addRow(const QString &address, const QString &payment_id, const QString &description) const; - Q_INVOKABLE bool deleteRow(int rowId) const; + Q_INVOKABLE bool getRow(int index, std::function<void (Monero::AddressBookRow &)> callback) const; + Q_INVOKABLE bool addRow(const QString &address, const QString &payment_id, const QString &description); + Q_INVOKABLE bool deleteRow(int rowId); quint64 count() const; Q_INVOKABLE QString errorString() const; Q_INVOKABLE int errorCode() const; @@ -61,6 +61,8 @@ public: Q_ENUM(ErrorCode); +private: + void getAll(); signals: void refreshStarted() const; @@ -73,6 +75,7 @@ private: explicit AddressBook(Monero::AddressBook * abImpl, QObject *parent); friend class Wallet; Monero::AddressBook * m_addressBookImpl; + mutable QReadWriteLock m_lock; mutable QList<Monero::AddressBookRow*> m_rows; }; |