diff options
| author | selsta <selsta@sent.at> | 2026-01-15 20:29:04 +0100 |
|---|---|---|
| committer | selsta <selsta@sent.at> | 2026-01-15 20:29:04 +0100 |
| commit | dfe7f302d4611e93692fdaee0799b2f8f377268f (patch) | |
| tree | 52b554fb0fcbfe0791fe8f49017d5b07d3abc1ab | |
| parent | e984c28fafc224df0f3d9e24a3ed942af5cf929f (diff) | |
| download | monzero-gui-dfe7f302d4611e93692fdaee0799b2f8f377268f.tar.gz monzero-gui-dfe7f302d4611e93692fdaee0799b2f8f377268f.tar.xz monzero-gui-dfe7f302d4611e93692fdaee0799b2f8f377268f.zip | |
cmake: warn if qmake has -qt5 suffix during deploy
Also make sure that windeployqt only runs when make deploy
is executed.
| -rw-r--r-- | .github/workflows/build.yml | 4 | ||||
| -rw-r--r-- | cmake/Deploy.cmake | 6 |
2 files changed, 9 insertions, 1 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 67bfdc17..e183613f 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -59,6 +59,10 @@ jobs: with: update: true install: mingw-w64-x86_64-toolchain make mingw-w64-x86_64-pcre mingw-w64-x86_64-cmake mingw-w64-x86_64-boost mingw-w64-x86_64-openssl mingw-w64-x86_64-zeromq mingw-w64-x86_64-libsodium mingw-w64-x86_64-hidapi mingw-w64-x86_64-protobuf-c mingw-w64-x86_64-libusb mingw-w64-x86_64-unbound git mingw-w64-x86_64-qt5 mingw-w64-x86_64-libgcrypt mingw-w64-x86_64-angleproject + - name: add qmake.exe and windeployqt.exe + run: | + cp -f "$MSYSTEM_PREFIX/bin/qmake-qt5.exe" "$MSYSTEM_PREFIX/bin/qmake.exe" + cp -f "$MSYSTEM_PREFIX/bin/windeployqt-qt5.exe" "$MSYSTEM_PREFIX/bin/windeployqt.exe" - name: build run: DEV_MODE=ON make release-win64 -j2 - name: deploy diff --git a/cmake/Deploy.cmake b/cmake/Deploy.cmake index 9a6efd93..e5f147f6 100644 --- a/cmake/Deploy.cmake +++ b/cmake/Deploy.cmake @@ -51,8 +51,12 @@ if(APPLE OR (WIN32 AND NOT STATIC)) endif() elseif(WIN32) + find_program(QMAKE_EXECUTABLE qmake HINTS "${_qt_bin_dir}") find_program(WINDEPLOYQT_EXECUTABLE windeployqt HINTS "${_qt_bin_dir}") - add_custom_command(TARGET monero-wallet-gui POST_BUILD + if(NOT QMAKE_EXECUTABLE OR NOT WINDEPLOYQT_EXECUTABLE) + message(WARNING "Deploy requires qmake.exe and windeployqt.exe (no -qt5 suffix) in ${_qt_bin_dir}") + endif() + add_custom_command(TARGET deploy POST_BUILD COMMAND "${CMAKE_COMMAND}" -E env PATH="${_qt_bin_dir}" "${WINDEPLOYQT_EXECUTABLE}" "$<TARGET_FILE:monero-wallet-gui>" -no-translations -qmldir="${CMAKE_SOURCE_DIR}" COMMENT "Running windeployqt..." ) |