diff options
| author | luigi1111 <luigi1111w@gmail.com> | 2018-07-27 14:27:47 -0500 |
|---|---|---|
| committer | luigi1111 <luigi1111w@gmail.com> | 2018-07-27 14:27:47 -0500 |
| commit | f739a3cbb8e95bc773756e7bc503448e61eed122 (patch) | |
| tree | 00d9edecd0fff278a4546ff887261b30ba02aaa1 /src/wallet/wallet2.cpp | |
| parent | dda05f357a3eed6426d4a78e59a2e88652d30537 (diff) | |
| parent | 2951436704e931e25537ca99e994186aa02c7ba6 (diff) | |
| download | monzero-core-f739a3cbb8e95bc773756e7bc503448e61eed122.tar.gz monzero-core-f739a3cbb8e95bc773756e7bc503448e61eed122.tar.xz monzero-core-f739a3cbb8e95bc773756e7bc503448e61eed122.zip | |
Merge pull request #4109
2951436 wallet: warn when payment IDs are used (moneromooo-monero)
Diffstat (limited to 'src/wallet/wallet2.cpp')
| -rw-r--r-- | src/wallet/wallet2.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/src/wallet/wallet2.cpp b/src/wallet/wallet2.cpp index 9e50f3229..90807803a 100644 --- a/src/wallet/wallet2.cpp +++ b/src/wallet/wallet2.cpp @@ -1557,6 +1557,7 @@ void wallet2::process_new_transaction(const crypto::hash &txid, const cryptonote { // We got a payment ID to go with this tx LOG_PRINT_L2("Found encrypted payment ID: " << payment_id8); + MINFO("Consider using subaddresses instead of encrypted payment IDs"); if (tx_pub_key != null_pkey) { if (!m_account.get_device().decrypt_payment_id(payment_id8, tx_pub_key, m_account.get_keys().m_view_secret_key)) @@ -1580,12 +1581,9 @@ void wallet2::process_new_transaction(const crypto::hash &txid, const cryptonote else if (get_payment_id_from_tx_extra_nonce(extra_nonce.nonce, payment_id)) { LOG_PRINT_L2("Found unencrypted payment ID: " << payment_id); + MWARNING("Found unencrypted payment ID: these are bad for privacy, consider using subaddresses instead"); } } - else if (get_payment_id_from_tx_extra_nonce(extra_nonce.nonce, payment_id)) - { - LOG_PRINT_L2("Found unencrypted payment ID: " << payment_id); - } for (const auto& i : tx_money_got_in_outs) { |