diff options
| author | jeffro256 <jeffro256@tutanota.com> | 2025-03-17 09:31:47 -0500 |
|---|---|---|
| committer | jeffro256 <jeffro256@tutanota.com> | 2025-03-19 23:25:48 -0500 |
| commit | c7f01e57f5a86331b38e5cded4488bec46bb2e6f (patch) | |
| tree | c4ad6e151f3a39f9188383a138dfee518374189a /src/cryptonote_core | |
| parent | 88a5d076822f39cdd897d3f962346f30e4901244 (diff) | |
| download | monzero-core-c7f01e57f5a86331b38e5cded4488bec46bb2e6f.tar.gz monzero-core-c7f01e57f5a86331b38e5cded4488bec46bb2e6f.tar.xz monzero-core-c7f01e57f5a86331b38e5cded4488bec46bb2e6f.zip | |
Blockchain: remove skip for pruned txs in `check_tx_inputs()`
I can't see how this would trigger in the current codebase, so it's not a *current* safety issue,
but I can very well see it becoming on in the future if downstream code doesn't handle the passing
of pruned transactions correctly. I think the safe/good choice would be to remove this skip now
that all transactions that pass into the mempool are supposed to be unpruned. And for all in-block
txs, `check_tx_inputs()` isn't called for checkpointed blocks, and we sync pruned blocks only if
syncing checkpointed blocks.
Diffstat (limited to 'src/cryptonote_core')
| -rw-r--r-- | src/cryptonote_core/blockchain.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/cryptonote_core/blockchain.cpp b/src/cryptonote_core/blockchain.cpp index d9615f9c0..9e2b321cc 100644 --- a/src/cryptonote_core/blockchain.cpp +++ b/src/cryptonote_core/blockchain.cpp @@ -3258,10 +3258,6 @@ bool Blockchain::check_tx_inputs(transaction& tx, tx_verification_context &tvc, if(pmax_used_block_height) *pmax_used_block_height = 0; - // pruned txes are skipped, as they're only allowed in sync-pruned-blocks mode, which is within the builtin hashes - if (tx.pruned) - return true; - crypto::hash tx_prefix_hash = get_transaction_prefix_hash(tx); const uint8_t hf_version = m_hardfork->get_current_version(); |
