core: remove out sorting from v7 rules

and restore random shuffle of outputs

This turned out to have a flaw (sort order depends on output
index), and this doesn't really bring much anyway

1 files changed, 0 insertions, 20 deletions

diff --git a/src/cryptonote_core/blockchain.cpp b/src/cryptonote_core/blockchain.cpp
index 0b09d503c..46427d161 100644
--- a/src/cryptonote_core/blockchain.cpp
+++ b/src/cryptonote_core/blockchain.cpp
@@ -2383,26 +2383,6 @@ bool Blockchain::check_tx_outputs(const transaction& tx, tx_verification_context
     }
   }
 
-  // from v7, sorted outs
-  if (m_hardfork->get_current_version() >= 7) {
-    const crypto::public_key *last_key = NULL;
-    for (size_t n = 0; n < tx.vout.size(); ++n)
-    {
-      const tx_out &o = tx.vout[n];
-      if (o.target.type() == typeid(txout_to_key))
-      {
-        const txout_to_key& out_to_key = boost::get<txout_to_key>(o.target);
-        if (last_key && memcmp(&out_to_key.key, last_key, sizeof(*last_key)) >= 0)
-        {
-          MERROR_VER("transaction has unsorted outputs");
-          tvc.m_invalid_output = true;
-          return false;
-        }
-        last_key = &out_to_key.key;
-      }
-    }
-  }
-
   return true;
 }
 //------------------------------------------------------------------