aboutsummaryrefslogtreecommitdiff
path: root/src/common/notify.cpp
diff options
context:
space:
mode:
authorRiccardo Spagni <ric@spagni.net>2018-10-02 22:39:34 +0200
committerRiccardo Spagni <ric@spagni.net>2018-10-02 22:39:34 +0200
commitbe6063ea59a713c4ddfdd27e8d8d240fec63a3f1 (patch)
tree7eb02193e0d03b0643bdd359a78657f0fa7e1c98 /src/common/notify.cpp
parentd1d64327b662b6cf70efa606c6a6c0d3eb2d7eaa (diff)
parentd5541e44feaa2be10c6a4ffb2746d59bb01a2b26 (diff)
downloadmonzero-core-be6063ea59a713c4ddfdd27e8d8d240fec63a3f1.tar.gz
monzero-core-be6063ea59a713c4ddfdd27e8d8d240fec63a3f1.tar.xz
monzero-core-be6063ea59a713c4ddfdd27e8d8d240fec63a3f1.zip
Merge pull request #4479
d5541e44 common: Windows 'spawn' support for tx and block notifications (xiphon)
Diffstat (limited to 'src/common/notify.cpp')
-rw-r--r--src/common/notify.cpp13
1 files changed, 7 insertions, 6 deletions
diff --git a/src/common/notify.cpp b/src/common/notify.cpp
index b7869ad84..cadc68ea7 100644
--- a/src/common/notify.cpp
+++ b/src/common/notify.cpp
@@ -29,12 +29,17 @@
#include <boost/algorithm/string.hpp>
#include "misc_log_ex.h"
#include "file_io_utils.h"
-#include "exec.h"
+#include "spawn.h"
#include "notify.h"
namespace tools
{
+/*
+ TODO:
+ - Improve tokenization to handle paths containing whitespaces, quotes, etc.
+ - Windows unicode support (implies implementing unicode command line parsing code)
+*/
Notify::Notify(const char *spec)
{
CHECK_AND_ASSERT_THROW_MES(spec, "Null spec");
@@ -51,11 +56,7 @@ int Notify::notify(const char *parameter)
for (std::string &s: margs)
boost::replace_all(s, "%s", parameter);
- char **cargs = (char**)alloca(sizeof(char*) * (margs.size() + 1));
- for (size_t n = 0; n < margs.size(); ++n)
- cargs[n] = (char*)margs[n].c_str();
- cargs[margs.size()] = NULL;
- return tools::exec(filename.c_str(), cargs, false);
+ return tools::spawn(filename.c_str(), margs, false);
}
}