From 7175dcb1078abbdaa130a8c5f5fd2b93fa7b3086 Mon Sep 17 00:00:00 2001 From: moneromooo-monero Date: Wed, 24 Jun 2020 23:26:58 +0000 Subject: replace most boost serialization with existing monero serialization This reduces the attack surface for data that can come from malicious sources (exported output and key images, multisig transactions...) since the monero serialization is already exposed to the outside, and the boost lib we were using had a few known crashers. For interoperability, a new load-deprecated-formats wallet setting is added (off by default). This allows loading boost format data if there is no alternative. It will likely go at some point, along with the ability to load those. Notably, the peer lists file still uses the boost serialization code, as the data it stores is define in epee, while the new serialization code is in monero, and migrating it was fairly hairy. Since this file is local and not obtained from anyone else, the marginal risk is minimal, but it could be migrated later if needed. Some tests and tools also do, this will stay as is for now. --- tests/data/fuzz/cold-outputs/OUTPUTS1 | Bin 7 -> 0 bytes tests/data/fuzz/cold-outputs/OUTPUTS2 | Bin 581 -> 0 bytes tests/data/fuzz/cold-outputs/out-all-6 | Bin 0 -> 2607 bytes tests/data/fuzz/cold-outputs/out-none-6 | Bin 0 -> 3 bytes tests/data/fuzz/cold-transaction/CTX1 | Bin 1073 -> 4192 bytes 5 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 tests/data/fuzz/cold-outputs/OUTPUTS1 delete mode 100644 tests/data/fuzz/cold-outputs/OUTPUTS2 create mode 100644 tests/data/fuzz/cold-outputs/out-all-6 create mode 100644 tests/data/fuzz/cold-outputs/out-none-6 (limited to 'tests/data/fuzz') diff --git a/tests/data/fuzz/cold-outputs/OUTPUTS1 b/tests/data/fuzz/cold-outputs/OUTPUTS1 deleted file mode 100644 index f449f61ad..000000000 Binary files a/tests/data/fuzz/cold-outputs/OUTPUTS1 and /dev/null differ diff --git a/tests/data/fuzz/cold-outputs/OUTPUTS2 b/tests/data/fuzz/cold-outputs/OUTPUTS2 deleted file mode 100644 index 33cf39024..000000000 Binary files a/tests/data/fuzz/cold-outputs/OUTPUTS2 and /dev/null differ diff --git a/tests/data/fuzz/cold-outputs/out-all-6 b/tests/data/fuzz/cold-outputs/out-all-6 new file mode 100644 index 000000000..d24fc604f Binary files /dev/null and b/tests/data/fuzz/cold-outputs/out-all-6 differ diff --git a/tests/data/fuzz/cold-outputs/out-none-6 b/tests/data/fuzz/cold-outputs/out-none-6 new file mode 100644 index 000000000..c5390590c Binary files /dev/null and b/tests/data/fuzz/cold-outputs/out-none-6 differ diff --git a/tests/data/fuzz/cold-transaction/CTX1 b/tests/data/fuzz/cold-transaction/CTX1 index 0afecedbc..4b9ee45dc 100644 Binary files a/tests/data/fuzz/cold-transaction/CTX1 and b/tests/data/fuzz/cold-transaction/CTX1 differ -- cgit v1.2.3