From a2195b9b7fba5da7f47903961db3fb31f6d7146c Mon Sep 17 00:00:00 2001 From: stoffu Date: Wed, 3 Apr 2019 14:10:24 +0900 Subject: crypto: replace rand()%N idiom with unbiased rand_idx(N) --- src/common/dns_utils.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src/common/dns_utils.cpp') diff --git a/src/common/dns_utils.cpp b/src/common/dns_utils.cpp index 1a1155c7c..5e03bf897 100644 --- a/src/common/dns_utils.cpp +++ b/src/common/dns_utils.cpp @@ -33,7 +33,7 @@ #include #include "include_base_utils.h" #include "common/threadpool.h" -#include +#include "crypto/crypto.h" #include #include #include @@ -517,10 +517,7 @@ bool load_txt_records_from_dns(std::vector &good_records, const std std::vector > records; records.resize(dns_urls.size()); - std::random_device rd; - std::mt19937 gen(rd()); - std::uniform_int_distribution dis(0, dns_urls.size() - 1); - size_t first_index = dis(gen); + size_t first_index = crypto::rand_idx(dns_urls.size()); // send all requests in parallel std::deque avail(dns_urls.size(), false), valid(dns_urls.size(), false); -- cgit v1.2.3