summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #10206v0.18.4.4tobtoht2025-11-121-7/+10
|\ | | | | | | 4e4e343 Daemon: relay empty fluffy block on found block (j-berman)
| * Daemon: relay empty fluffy block on found blockj-berman2025-11-111-7/+10
| |
* | tx pool: only increment m_txpool_weight for newly added pool txsj-berman2025-11-111-1/+2
|/ | | | | | | | | | | | | Otherwise we can end up double counting txs towards the weight, which can over-state the pool weight. E.g. relay tx to node in stem phase, add its weight to pool weight, then receive tx from another node, then bump the pool weight again. That double counts the tx towards the pool weight. If the weight exceeds the max, the node will "prune" txs from the pool. Thus, over-counting is probably a cause of, but perhaps not the only cause of: https://github.com/seraphis-migration/monero/issues/148
* Merge pull request #10195tobtoht2025-11-112-12/+11
|\ | | | | | | 26cf4f9 ledger: throw on secret view key export rejection (tobtoht)
| * ledger: throw on secret view key export rejectiontobtoht2025-11-112-12/+11
| |
* | Merge pull request #10202tobtoht2025-11-111-8/+16
|\ \ | | | | | | | | | dafecd0 cryptonote_protocol: accurate next_needed_height when there is an overlap (0xFFFC0000)
| * | cryptonote_protocol: accurate next_needed_height when there is an overlap0xFFFC00002025-11-111-8/+16
| |/
* | Merge pull request #10199tobtoht2025-11-114-2/+3
|\ \ | | | | | | | | | 64f2d8e build: prepare v0.18.4.4 (selsta)
| * | build: prepare v0.18.4.4selsta2025-11-104-2/+3
| |/
* / Fix logging deadlockj-berman2025-11-111-2/+5
|/
* Merge pull request #10153tobtoht2025-10-272-18/+44
|\ | | | | | | 9239d36 wallet: identify spends in pool when scanning (j-berman)
| * wallet: identify spends in pool when scanningj-berman2025-10-072-18/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Make sure to mark identified spends in the pool as spends. The wallet might not know these have been spent if it wasn't the wallet that relayed the tx to the daemon, or the wallet was cleared via rescan_bc. - Make sure to add spends to m_unconfirmed_txs if not present. - Make sure to process the entire pool again if refreshing for the first time. The wallet fetches pool and blocks at the same time. The wallet scans blocks first, then pool. If the wallet identifies received outputs in the chain, then it may have spent those received outputs in the pool. So we make sure to re-process the entire pool again after scanning the chain for the first time. - Multisig wallets that know about spent key images can now detect spend txs in the pool. Update tests for that.
* | Merge pull request #10106v0.18.4.3luigi11112025-10-074-2/+3
|\ \ | | | | | | | | | 09f5cbb build: prepare v0.18.4.3 (selsta)
| * | build: prepare v0.18.4.3selsta2025-10-074-2/+3
| | |
* | | Merge pull request #10150luigi11112025-10-071-2/+5
|\ \ \ | | | | | | | | | | | | 1829992 wallet2: warn instead of throw when RingDB doesn't include spend (j-berman)
| * | | wallet2: warn instead of throw when RingDB doesn't include spendj-berman2025-10-061-2/+5
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | A reorg can end up causing an output's position in the chain to move. Since the wallet doesn't update the RingDB on reorg, it may refer to the output's stale position in the chain. This seems a reasonable solution rather than introducing complex logic to update the stale ring member's value on rerog, since RingDB can be deprecated with FCMP++.
* | | Merge pull request #10149luigi11112025-10-071-1/+0
|\ \ \ | | | | | | | | | | | | 014f3cd cryptonote_basic: remove redundant call to get_transaction_hash() in overload (jeffro256)
| * | | cryptonote_basic: remove redundant call to get_transaction_hash() in overloadjeffro2562025-10-061-1/+0
| |/ / | | | | | | | | | Issue noticed by DataHoarder.
* | | Merge pull request #10148luigi11112025-10-072-15/+2
|\ \ \ | | | | | | | | | | | | 7b53197 Cleaner validation (faster and saner) (j-berman)
| * | | Cleaner validation (faster and saner)j-berman2025-10-052-15/+2
| |/ /
* / / Daemon RPC: fix on_getblockhash error return on too high heightj-berman2025-09-291-0/+1
|/ /
* | Merge pull request #9901tobtoht2025-09-283-5/+10
|\ \ | | | | | | | | | 9a45208 Daemon RPC: add max_block_count field to /getblocks.bin (j-berman)
| * | Daemon RPC: add max_block_count field to /getblocks.binj-berman2025-04-103-5/+10
| | |
* | | Merge pull request #10098tobtoht2025-09-281-1/+1
|\ \ \ | | | | | | | | | | | | 13e28ea simplewallet: batch address creation limit to match rpc (nahuhh)
| * | | simplewallet: batch address creation limit to match rpcnahuhh2025-09-221-1/+1
| | | |
* | | | Merge pull request #10104tobtoht2025-09-281-2/+5
|\ \ \ \ | | | | | | | | | | | | | | | 39c7a22 Send ZMQ miner notifications after txpool additions (WeebDataHoarder)
| * | | | Send ZMQ miner notifications after txpool additionsWeebDataHoarder2025-09-241-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bug was introduced in c069c04ede338929c50297558fee15192aa0f67c, before this txpool additions were not notified on block addition When receiving blocks with previously unknown conditions, miner data was sent first, but txpool add events for already-added transactions in previous block were sent afterward. Miners would then include already-mined transactions in their new templates due to receiving the mistimed txpool add event. The fix is to send miner notifications AFTER txpool events are sent, and before normal block notifications are sent (for mining switch speed purposes) Fixes c069c04ede338929c50297558fee15192aa0f67c / #9135 Fixes dfee15eee18a97be5a8fb9822527f98ebd1b33e9 / #7891
* | | | | Merge pull request #10112tobtoht2025-09-281-4/+0
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | dd82d28 removing lza_menace seed nodes (lza_menace)
| * | | | | removing lza_menace seed nodeslza_menace2025-09-261-4/+0
| | |_|_|/ | |/| | |
* | | | | Merge pull request #10113tobtoht2025-09-281-101/+184
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | 2879885 p2p: Improved peer selection with /24 subnet deduplication to disadvantage 'spy nodes' [v0.18] (rbrunner7)
| * | | | | p2p: Improved peer selection with /24 subnet deduplication to disadvantage ↵rbrunner72025-09-261-101/+184
| |/ / / / | | | | | | | | | | | | | | | 'spy nodes' [v0.18]
* / / / / net_node: add hinto seed nodeshinto.janai2025-09-261-0/+4
|/ / / /
* | | | Merge pull request #10105tobtoht2025-09-241-1/+0
|\ \ \ \ | | | | | | | | | | | | | | | f292444 remove 66.85.74.134 as seed node (Gingeropolous)
| * | | | remove 66.85.74.134 as seed nodeGingeropolous2025-09-241-1/+0
| | |/ / | |/| | | | | | remove 66.85.74.134 as seed node. bastards doubled the price of the server.
* | | | Merge pull request #10092tobtoht2025-09-241-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | 00e4faf cryptonote_core: `--dns-versions-check` is deprecated (nahuhh)
| * | | | cryptonote_core: `--dns-versions-check` is deprecatednahuhh2025-09-211-1/+1
| | |/ / | |/| |
* | | | Merge pull request #10096tobtoht2025-09-241-2/+2
|\ \ \ \ | |/ / / |/| | | | | | | 751061c wallet_rpc_server: allow creating more than 64 addresses at once (moneromooo-monero)
| * | | wallet_rpc_server: allow creating more than 64 addresses at oncemoneromooo-monero2025-09-221-2/+2
| |/ / | | | | | | | | | | | | it's too low a limit (at least one person mentioned having to call create_address in a loop due to it)
* | | Merge pull request #10051v0.18.4.2tobtoht2025-08-213-2/+2
|\ \ \ | | | | | | | | | | | | f921431 checkpoints: update to a recent block height (selsta)
| * | | checkpoints: update to a recent block heightselsta2025-08-203-2/+2
| | | |
* | | | Skip ping connections in outgoing countLee *!* Clagett2025-08-192-4/+6
|/ / /
* | | Merge pull request #10019tobtoht2025-08-054-2/+3
|\ \ \ | | | | | | | | | | | | 32f701b build: prepare v0.18.4.2 (selsta)
| * | | build: prepare v0.18.4.2selsta2025-08-014-2/+3
| | | |
* | | | wallet: deprecate wallet2::find_and_save_rings()jeffro2562025-07-294-80/+6
|/ / / | | | | | | | | | | | | | | | | | | Rings for outgoing transactions are stored within the scanning code since the last hardfork, so this code is largely unneccessary now. Co-authored-by: j-berman <justinberman@protonmail.com>
* / / set do_not_relay always false in submit_multisig_mainSNeedlewoods2025-07-141-2/+2
|/ /
* | Merge pull request #9982tobtoht2025-07-131-1/+4
|\ \ | | | | | | | | | 45152f9 rpc: return error correctly on bad key image string (jeffro256)
| * | rpc: return error correctly on bad key image stringjeffro2562025-07-111-1/+4
| | | | | | | | | | | | | | | | | | Because of the missing `return` statement, the status is set to "OK" later on in the method when it shouldn't be. Thank you to ADA Logics and the MAGIC Monero Fund for reporting this!
* | | Merge pull request #9983tobtoht2025-07-131-8/+2
|\ \ \ | | | | | | | | | | | | bec90df add do_not_relay option to submit_multisig_main command in simplewallet (SNeedlewoods)
| * | | add do_not_relay option to submit_multisig_main command in simplewalletSNeedlewoods2025-07-111-8/+2
| |/ /
* / / crypto: check+throw for Cryptonight v1 invalid inputjeffro2562025-07-111-1/+11
|/ / | | | | | | | | | | | | If `crypto::cn_slow_hash()` is called with `variant=1` and an input length of less thab 43 bytes, it triggers a program exit. This checks first and throws an exception instead. Thank you to ADA Logics and the MAGIC Monero Fund for reporting this!