| Commit message (Collapse) | Author | Age | Files | Lines |
| |\
| |
| |
| | |
4e4e343 Daemon: relay empty fluffy block on found block (j-berman)
|
| | | |
|
| |/
|
|
|
|
|
|
|
|
|
|
|
| |
Otherwise we can end up double counting txs towards the weight,
which can over-state the pool weight. E.g. relay tx to node in
stem phase, add its weight to pool weight, then receive tx
from another node, then bump the pool weight again. That double
counts the tx towards the pool weight.
If the weight exceeds the max, the node will "prune" txs from the
pool. Thus, over-counting is probably a cause of, but perhaps
not the only cause of:
https://github.com/seraphis-migration/monero/issues/148
|
| |\
| |
| |
| | |
26cf4f9 ledger: throw on secret view key export rejection (tobtoht)
|
| | | |
|
| |\ \
| | |
| | |
| | | |
dafecd0 cryptonote_protocol: accurate next_needed_height when there is an overlap (0xFFFC0000)
|
| | |/ |
|
| |\ \
| | |
| | |
| | | |
64f2d8e build: prepare v0.18.4.4 (selsta)
|
| | |/ |
|
| |/ |
|
| |\
| |
| |
| | |
9239d36 wallet: identify spends in pool when scanning (j-berman)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
- Make sure to mark identified spends in the pool as spends. The
wallet might not know these have been spent if it wasn't the wallet
that relayed the tx to the daemon, or the wallet was cleared via
rescan_bc.
- Make sure to add spends to m_unconfirmed_txs if not present.
- Make sure to process the entire pool again if refreshing for
the first time. The wallet fetches pool and blocks at the same
time. The wallet scans blocks first, then pool. If the wallet
identifies received outputs in the chain, then it may have spent
those received outputs in the pool. So we make sure to re-process
the entire pool again after scanning the chain for the first time.
- Multisig wallets that know about spent key images can now detect
spend txs in the pool. Update tests for that.
|
| |\ \
| | |
| | |
| | | |
09f5cbb build: prepare v0.18.4.3 (selsta)
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | | |
1829992 wallet2: warn instead of throw when RingDB doesn't include spend (j-berman)
|
| | | |/
| |/|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
A reorg can end up causing an output's position in the chain to
move. Since the wallet doesn't update the RingDB on reorg, it
may refer to the output's stale position in the chain.
This seems a reasonable solution rather than introducing complex
logic to update the stale ring member's value on rerog, since
RingDB can be deprecated with FCMP++.
|
| |\ \ \
| | | |
| | | |
| | | | |
014f3cd cryptonote_basic: remove redundant call to get_transaction_hash() in overload (jeffro256)
|
| | |/ /
| | |
| | |
| | | |
Issue noticed by DataHoarder.
|
| |\ \ \
| | | |
| | | |
| | | | |
7b53197 Cleaner validation (faster and saner) (j-berman)
|
| | |/ / |
|
| |/ / |
|
| |\ \
| | |
| | |
| | | |
9a45208 Daemon RPC: add max_block_count field to /getblocks.bin (j-berman)
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | | |
13e28ea simplewallet: batch address creation limit to match rpc (nahuhh)
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
39c7a22 Send ZMQ miner notifications after txpool additions (WeebDataHoarder)
|
| | | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
Bug was introduced in c069c04ede338929c50297558fee15192aa0f67c, before this txpool additions were not notified on block addition
When receiving blocks with previously unknown conditions, miner data was sent first, but txpool add events for already-added transactions in previous block were sent afterward. Miners would then include already-mined transactions in their new templates due to receiving the mistimed txpool add event.
The fix is to send miner notifications AFTER txpool events are sent, and before normal block notifications are sent (for mining switch speed purposes)
Fixes c069c04ede338929c50297558fee15192aa0f67c / #9135
Fixes dfee15eee18a97be5a8fb9822527f98ebd1b33e9 / #7891
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
dd82d28 removing lza_menace seed nodes (lza_menace)
|
| | | |_|_|/
| |/| | | |
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
2879885 p2p: Improved peer selection with /24 subnet deduplication to disadvantage 'spy nodes' [v0.18] (rbrunner7)
|
| | |/ / / /
| | | | |
| | | | |
| | | | | |
'spy nodes' [v0.18]
|
| |/ / / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
f292444 remove 66.85.74.134 as seed node (Gingeropolous)
|
| | | |/ /
| |/| |
| | | | |
remove 66.85.74.134 as seed node. bastards doubled the price of the server.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
00e4faf cryptonote_core: `--dns-versions-check` is deprecated (nahuhh)
|
| | | |/ /
| |/| | |
|
| |\ \ \ \
| |/ / /
|/| | |
| | | | |
751061c wallet_rpc_server: allow creating more than 64 addresses at once (moneromooo-monero)
|
| | |/ /
| | |
| | |
| | |
| | | |
it's too low a limit (at least one person mentioned having to
call create_address in a loop due to it)
|
| |\ \ \
| | | |
| | | |
| | | | |
f921431 checkpoints: update to a recent block height (selsta)
|
| | | | | |
|
| |/ / / |
|
| |\ \ \
| | | |
| | | |
| | | | |
32f701b build: prepare v0.18.4.2 (selsta)
|
| | | | | |
|
| |/ / /
| | |
| | |
| | |
| | |
| | |
| | | |
Rings for outgoing transactions are stored within the scanning code since the last hardfork,
so this code is largely unneccessary now.
Co-authored-by: j-berman <justinberman@protonmail.com>
|
| |/ / |
|
| |\ \
| | |
| | |
| | | |
45152f9 rpc: return error correctly on bad key image string (jeffro256)
|
| | | |
| | |
| | |
| | |
| | |
| | | |
Because of the missing `return` statement, the status is set to "OK" later on in the method when it shouldn't be.
Thank you to ADA Logics and the MAGIC Monero Fund for reporting this!
|
| |\ \ \
| | | |
| | | |
| | | | |
bec90df add do_not_relay option to submit_multisig_main command in simplewallet (SNeedlewoods)
|
| | |/ / |
|
| |/ /
| |
| |
| |
| |
| |
| | |
If `crypto::cn_slow_hash()` is called with `variant=1` and an input length of less thab 43 bytes, it triggers a program exit.
This checks first and throws an exception instead.
Thank you to ADA Logics and the MAGIC Monero Fund for reporting this!
|