summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #6376v0.15.0.5luigi11112020-03-091-4/+16
|\ | | | | | | 6177e49 Added logging for dropped local txes with no i2p/tor connections (vtnerd)
| * Added logging for dropped local txes with no i2p/tor connectionsLee Clagett2020-03-071-4/+16
| |
* | Merge pull request #6373luigi11112020-03-091-8/+6
|\ \ | | | | | | | | | 62ab7fd p2p: plug tor to clearnet association vector (moneromooo-monero)
| * | p2p: plug tor to clearnet association vectorAaron Hook2020-03-071-8/+6
| |/ | | | | | | | | | | | | | | | | | | During the handshake for an incoming connection, the peer id is checked against the local node's peer id only for the specific zone of the incoming peer, in order to avoid linking public addresses to tor addresses: https://github.com/monero-project/monero/blob/5d7ae2d2791c0244a221872a7ac62627abb81896/src/p2p/net_node.inl#L2343 However, on handshakes for outgoing connections, all zones are checked: https://github.com/monero-project/monero/blob/5d7ae2d2791c0244a221872a7ac62627abb81896/src/p2p/net_node.inl#L1064 If an attacker wanted to link a specific tor node to a public node, they could potentially connect to as many public nodes as possible, get themselves added to the peer whitelist, maybe stuff some more attacker-owned addresses into the greylist, then disconnect, and for any future incoming connections, respond with the tor node's id in an attempt to link the public/tor addresses.
* | Merge pull request #6368luigi11112020-03-094-2/+3
|\ \ | | | | | | | | | ac1a34c build: prepare v0.15.0.5 update (selsta)
| * | build: prepare v0.15.0.5 updateselsta2020-03-034-2/+3
| |/
* | Merge pull request #6365luigi11112020-03-094-13/+13
|\ \ | | | | | | | | | d438e6a wallet: fix exceptions getting the hash of a pruned tx (moneromooo-monero)
| * | wallet: fix exceptions getting the hash of a pruned txmoneromooo-monero2020-03-014-13/+13
| |/
* / Fixed bug in ZMQ JSON-RPC method fieldLee Clagett2019-11-181-3/+12
|/
* make d2h et al. constant-timeJethro Grassie2019-11-191-30/+8
|
* Merge pull request #6152luigi11112019-11-183-2/+2
|\ | | | | | | 74b0ca4 v0.15.0.1 version bump (moneromooo-monero)
| * v0.15.0.1 version bumpmoneromooo-monero2019-11-183-2/+2
| |
* | Fix #6147 DB corruption from child process overwriteHoward Chu2019-11-171-1/+6
|/ | | | Don't leave stdout/stderr dangling on a fork.
* wallet: set non-empty error string on connection failurexiphon2019-11-151-1/+1
|
* wallet2: fix pool txes not being flushed when minedmoneromooo-monero2019-11-041-1/+1
|
* Merge pull request #6075Riccardo Spagni2019-11-037-38/+110
|\ | | | | | | | | | | | | | | | | | | 912ff6abe simplewallet: plug a timing leak (moneromooo-monero) cc2fc0bc3 epee: allow a random component in once_a_time timeouts (moneromooo-monero) c0f504787 wallet: reuse cached height when set after refresh (moneromooo-monero) f98d9673e wallet2: fix is_synced checking target height, not height (moneromooo-monero) 98cdc8492 wallet: fix another facet of "did I get some monero" information leak (moneromooo-monero) 69b8aa5a2 wallet2: do not send an unnecessary last getblocks.bin call on refresh (moneromooo-monero) 2ca057402 wallet2: do not repeatedly ask for pool txes sent to us (moneromooo-monero)
| * simplewallet: plug a timing leakmoneromooo-monero2019-11-022-10/+31
| | | | | | | | | | | | | | | | | | | | As reported by Tramèr et al, timing of refresh requests can be used to see whether a password was requested (and thus at least one output received) since this will induce a delay in subsequent calls. To avoid this, we schedule calls at a given time instead of sleeping for a set time (which would make delays additive). To further avoid a scheduled call being during the time in which a password is prompted, the actual scheduled time is now randomized.
| * wallet: reuse cached height when set after refreshmoneromooo-monero2019-11-012-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | Refreshing sets cached height, which is otherwise got by calling get_info. Since get_info is called upon needing to display a prompt after a command has finished, it can be used to determine how much time a given command took to run if the cache timeout lapses while the command runs. Refreshing caches the height as a side effect, so get_info will never be called as a result of displaying a prompt after refreshing (and potentially leaking how much time it took to process a set of transactions, therefore leaking whether we got some monero in them).
| * wallet2: fix is_synced checking target height, not heightmoneromooo-monero2019-11-011-1/+1
| | | | | | | | | | | | Target height would be appropriate for the daemon, which syncs off other daemons, but the wallet syncs off the daemon it's connected to, and its target is the daemon's current height.
| * wallet: fix another facet of "did I get some monero" information leakmoneromooo-monero2019-11-014-15/+50
| | | | | | | | | | | | | | We get new pool txes before processing any tx, pool or not. This ensures that if we're asked for a password, this does not cause a measurable delay in the txpool query after the last block query.
| * wallet2: do not send an unnecessary last getblocks.bin call on refreshmoneromooo-monero2019-11-012-7/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "everything refreshed" state was detected when a refresh call did not return any new blocks. This can be detected without that extra "empty" call by comparing the claimed node height to the height of the last block retrieved. Doing this avoids that last call, saves some bandwidth, and makes the common refresh case use only one call rather than two. As a side effect, it prevents an information leak reported by Tramèr et al: if the wallet retrieves a set of blocks which includes an output sent to the refreshing wallet, the wallet will prompt the user for the password to decode the amount and calculate the key image for the new output, and this will delay subsequent calls to getblocks.bin, allowing a passive adversary to note the delay and deduce when the wallet receives at least one output. This can still happen if the wallet downloads more than 1000 blocks, since this will be split in several calls, but then the most the adversary can tell is which 1000 block section the user received some monero (the adversary can estimate the heights of the blocks by calculating how many "large" transfers are done, which will be sections of blocks, the last of which will usually be below 1000, but the size of the data should allow the actual number of blocks sent to be determined fairly accurately). This timing trick still be used via the subsequent scan for incoming txes in the txpool, which will be fixed later.
| * wallet2: do not repeatedly ask for pool txes sent to usmoneromooo-monero2019-11-011-5/+0
| | | | | | | | | | | | | | | | This lets a passive attacker with access to the network link between node and wallet perform traffic analysis to deduce when an idle wallet receives a transaction. Reported by Tramèr et al.
* | Merge pull request #6079Riccardo Spagni2019-11-024-3/+4
| | | | | | | | e4d1674e8 0.15.0.0 release engineering (Riccardo Spagni)
* | Merge pull request #6066Riccardo Spagni2019-11-015-12/+18
|\ \ | | | | | | | | | d31024c2e cryptonote: untangle dependency from miner to blockchain (moneromooo-monero)
| * | cryptonote: untangle dependency from miner to blockchainmoneromooo-monero2019-10-315-12/+18
| |/ | | | | | | It causes link errors at least on mac
* | Merge pull request #6064Riccardo Spagni2019-11-012-3/+6
|\ \ | |/ |/| | | 0e3b823a1 daemon: always use bootstrap daemon (if set) in '--no-sync' mode (xiphon)
| * daemon: always use bootstrap daemon (if set) in '--no-sync' modexiphon2019-10-302-3/+6
| |
* | Merge pull request #6045luigi11112019-10-271-2/+11
|\ \ | | | | | | | | | 86ac20f blockchain: fix unwanted error when probing the pool for a tx (moneromooo-monero)
| * | blockchain: fix unwanted error when probing the pool for a txmoneromooo-monero2019-10-271-2/+11
| | |
* | | wallet: do not warn if the rpc cost was freemoneromooo-monero2019-10-271-1/+1
|/ /
* | Merge pull request #6017luigi11112019-10-251-1/+1
|\ \ | | | | | | | | | 5734686 rpc: Include tag in get_info version string (ndorf)
| * | rpc: Include tag in get_info version stringNathan Dorfman2019-10-241-1/+1
| | |
* | | rpc: fix PRIx64 build error on some systemsmoneromooo-monero2019-10-261-1/+1
| | |
* | | Merge pull request #6024luigi11112019-10-251-0/+4
|\ \ \ | | | | | | | | | | | | 296ec7c device: bounds checking in Ledger send_secret/receive_secret (xiphon)
| * | | device: bounds checking in Ledger send_secret/receive_secretxiphon2019-10-251-0/+4
| | | |
* | | | Merge pull request #5958luigi11112019-10-253-108/+217
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | d25acd7 Add hmac over encrypted value during transaction (clashm) 34f28a7 Add display address (clashm) 235b94e Revert PR #5835 (export view key) (clashm) 32febd2 Fix debug feature (clashm)
| * | | Fix debug featurecslashm2019-10-031-0/+2
| | | |
| * | | Revert PR #5835 (export view key)cslashm2019-10-031-1/+1
| | | |
| * | | Add display addresscslashm2019-10-032-1/+24
| | | |
| * | | Add hmac over encrypted value during transactioncslashm2019-10-033-106/+190
| | | |
* | | | Merge pull request #6028luigi11112019-10-251-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | 174a6ac tx_pool: fix divide by 0 in log (moneromooo-monero)
| * | | | tx_pool: fix divide by 0 in logmoneromooo-monero2019-10-251-1/+1
| | |_|/ | |/| | | | | | | | | | Coverity 205394
* | | | Merge pull request #6007luigi11112019-10-2510-1/+97
|\ \ \ \ | | | | | | | | | | | | | | | a4dc575 rpc: add a flush_cache RPC (moneromooo-monero)
| * | | | rpc: add a flush_cache RPCmoneromooo-monero2019-10-2510-1/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows flushing internal caches (for now, the bad tx cache, which will allow debugging a stuck monerod after it has failed to verify a transaction in a block, since it would otherwise not try again, making subsequent log changes pointless)
* | | | | Merge pull request #6023luigi11112019-10-251-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | 643dcb9 net: link with libzmq (moneromooo-monero)
| * | | | | net: link with libzmqmoneromooo-monero2019-10-251-1/+1
| | |/ / / | |/| | |
* | | | | Merge pull request #6021luigi11112019-10-253-14/+14
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | 65e8a89 Change monerod --proxy to --tx-proxy (vtnerd)
| * | | | | Change monerod --proxy to --tx-proxyLee Clagett2019-10-243-14/+14
| | | | | |
* | | | | | Merge pull request #6019luigi11112019-10-252-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | d60c1b6 changed 'batttery' to 'battery' (jakehemmerle)
| * | | | | | changed 'batttery' to 'battery'Jake Hemmerle2019-10-242-3/+3
| |/ / / / /