summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* make d2h et al. constant-timeJethro Grassie2019-11-191-30/+8
|
* Merge pull request #6152luigi11112019-11-183-2/+2
|\ | | | | | | 74b0ca4 v0.15.0.1 version bump (moneromooo-monero)
| * v0.15.0.1 version bumpmoneromooo-monero2019-11-183-2/+2
| |
* | Fix #6147 DB corruption from child process overwriteHoward Chu2019-11-171-1/+6
|/ | | | Don't leave stdout/stderr dangling on a fork.
* wallet: set non-empty error string on connection failurexiphon2019-11-151-1/+1
|
* wallet2: fix pool txes not being flushed when minedmoneromooo-monero2019-11-041-1/+1
|
* Merge pull request #6075Riccardo Spagni2019-11-037-38/+110
|\ | | | | | | | | | | | | | | | | | | 912ff6abe simplewallet: plug a timing leak (moneromooo-monero) cc2fc0bc3 epee: allow a random component in once_a_time timeouts (moneromooo-monero) c0f504787 wallet: reuse cached height when set after refresh (moneromooo-monero) f98d9673e wallet2: fix is_synced checking target height, not height (moneromooo-monero) 98cdc8492 wallet: fix another facet of "did I get some monero" information leak (moneromooo-monero) 69b8aa5a2 wallet2: do not send an unnecessary last getblocks.bin call on refresh (moneromooo-monero) 2ca057402 wallet2: do not repeatedly ask for pool txes sent to us (moneromooo-monero)
| * simplewallet: plug a timing leakmoneromooo-monero2019-11-022-10/+31
| | | | | | | | | | | | | | | | | | | | As reported by Tramèr et al, timing of refresh requests can be used to see whether a password was requested (and thus at least one output received) since this will induce a delay in subsequent calls. To avoid this, we schedule calls at a given time instead of sleeping for a set time (which would make delays additive). To further avoid a scheduled call being during the time in which a password is prompted, the actual scheduled time is now randomized.
| * wallet: reuse cached height when set after refreshmoneromooo-monero2019-11-012-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | Refreshing sets cached height, which is otherwise got by calling get_info. Since get_info is called upon needing to display a prompt after a command has finished, it can be used to determine how much time a given command took to run if the cache timeout lapses while the command runs. Refreshing caches the height as a side effect, so get_info will never be called as a result of displaying a prompt after refreshing (and potentially leaking how much time it took to process a set of transactions, therefore leaking whether we got some monero in them).
| * wallet2: fix is_synced checking target height, not heightmoneromooo-monero2019-11-011-1/+1
| | | | | | | | | | | | Target height would be appropriate for the daemon, which syncs off other daemons, but the wallet syncs off the daemon it's connected to, and its target is the daemon's current height.
| * wallet: fix another facet of "did I get some monero" information leakmoneromooo-monero2019-11-014-15/+50
| | | | | | | | | | | | | | We get new pool txes before processing any tx, pool or not. This ensures that if we're asked for a password, this does not cause a measurable delay in the txpool query after the last block query.
| * wallet2: do not send an unnecessary last getblocks.bin call on refreshmoneromooo-monero2019-11-012-7/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "everything refreshed" state was detected when a refresh call did not return any new blocks. This can be detected without that extra "empty" call by comparing the claimed node height to the height of the last block retrieved. Doing this avoids that last call, saves some bandwidth, and makes the common refresh case use only one call rather than two. As a side effect, it prevents an information leak reported by Tramèr et al: if the wallet retrieves a set of blocks which includes an output sent to the refreshing wallet, the wallet will prompt the user for the password to decode the amount and calculate the key image for the new output, and this will delay subsequent calls to getblocks.bin, allowing a passive adversary to note the delay and deduce when the wallet receives at least one output. This can still happen if the wallet downloads more than 1000 blocks, since this will be split in several calls, but then the most the adversary can tell is which 1000 block section the user received some monero (the adversary can estimate the heights of the blocks by calculating how many "large" transfers are done, which will be sections of blocks, the last of which will usually be below 1000, but the size of the data should allow the actual number of blocks sent to be determined fairly accurately). This timing trick still be used via the subsequent scan for incoming txes in the txpool, which will be fixed later.
| * wallet2: do not repeatedly ask for pool txes sent to usmoneromooo-monero2019-11-011-5/+0
| | | | | | | | | | | | | | | | This lets a passive attacker with access to the network link between node and wallet perform traffic analysis to deduce when an idle wallet receives a transaction. Reported by Tramèr et al.
* | Merge pull request #6079Riccardo Spagni2019-11-024-3/+4
| | | | | | | | e4d1674e8 0.15.0.0 release engineering (Riccardo Spagni)
* | Merge pull request #6066Riccardo Spagni2019-11-015-12/+18
|\ \ | | | | | | | | | d31024c2e cryptonote: untangle dependency from miner to blockchain (moneromooo-monero)
| * | cryptonote: untangle dependency from miner to blockchainmoneromooo-monero2019-10-315-12/+18
| |/ | | | | | | It causes link errors at least on mac
* | Merge pull request #6064Riccardo Spagni2019-11-012-3/+6
|\ \ | |/ |/| | | 0e3b823a1 daemon: always use bootstrap daemon (if set) in '--no-sync' mode (xiphon)
| * daemon: always use bootstrap daemon (if set) in '--no-sync' modexiphon2019-10-302-3/+6
| |
* | Merge pull request #6045luigi11112019-10-271-2/+11
|\ \ | | | | | | | | | 86ac20f blockchain: fix unwanted error when probing the pool for a tx (moneromooo-monero)
| * | blockchain: fix unwanted error when probing the pool for a txmoneromooo-monero2019-10-271-2/+11
| | |
* | | wallet: do not warn if the rpc cost was freemoneromooo-monero2019-10-271-1/+1
|/ /
* | Merge pull request #6017luigi11112019-10-251-1/+1
|\ \ | | | | | | | | | 5734686 rpc: Include tag in get_info version string (ndorf)
| * | rpc: Include tag in get_info version stringNathan Dorfman2019-10-241-1/+1
| | |
* | | rpc: fix PRIx64 build error on some systemsmoneromooo-monero2019-10-261-1/+1
| | |
* | | Merge pull request #6024luigi11112019-10-251-0/+4
|\ \ \ | | | | | | | | | | | | 296ec7c device: bounds checking in Ledger send_secret/receive_secret (xiphon)
| * | | device: bounds checking in Ledger send_secret/receive_secretxiphon2019-10-251-0/+4
| | | |
* | | | Merge pull request #5958luigi11112019-10-253-108/+217
|\| | | | | | | | | | | | | | | | | | | | | | | | | | | d25acd7 Add hmac over encrypted value during transaction (clashm) 34f28a7 Add display address (clashm) 235b94e Revert PR #5835 (export view key) (clashm) 32febd2 Fix debug feature (clashm)
| * | | Fix debug featurecslashm2019-10-031-0/+2
| | | |
| * | | Revert PR #5835 (export view key)cslashm2019-10-031-1/+1
| | | |
| * | | Add display addresscslashm2019-10-032-1/+24
| | | |
| * | | Add hmac over encrypted value during transactioncslashm2019-10-033-106/+190
| | | |
* | | | Merge pull request #6028luigi11112019-10-251-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | 174a6ac tx_pool: fix divide by 0 in log (moneromooo-monero)
| * | | | tx_pool: fix divide by 0 in logmoneromooo-monero2019-10-251-1/+1
| | |_|/ | |/| | | | | | | | | | Coverity 205394
* | | | Merge pull request #6007luigi11112019-10-2510-1/+97
|\ \ \ \ | | | | | | | | | | | | | | | a4dc575 rpc: add a flush_cache RPC (moneromooo-monero)
| * | | | rpc: add a flush_cache RPCmoneromooo-monero2019-10-2510-1/+97
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This allows flushing internal caches (for now, the bad tx cache, which will allow debugging a stuck monerod after it has failed to verify a transaction in a block, since it would otherwise not try again, making subsequent log changes pointless)
* | | | | Merge pull request #6023luigi11112019-10-251-1/+1
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | 643dcb9 net: link with libzmq (moneromooo-monero)
| * | | | | net: link with libzmqmoneromooo-monero2019-10-251-1/+1
| | |/ / / | |/| | |
* | | | | Merge pull request #6021luigi11112019-10-253-14/+14
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | 65e8a89 Change monerod --proxy to --tx-proxy (vtnerd)
| * | | | | Change monerod --proxy to --tx-proxyLee Clagett2019-10-243-14/+14
| | | | | |
* | | | | | Merge pull request #6019luigi11112019-10-252-3/+3
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | d60c1b6 changed 'batttery' to 'battery' (jakehemmerle)
| * | | | | | changed 'batttery' to 'battery'Jake Hemmerle2019-10-242-3/+3
| |/ / / / /
* | | | | | Merge pull request #6014luigi11112019-10-251-0/+5
|\ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | 93e7426 wallet2: error out when we need a daemon password but have no prompt function (moneromooo-monero)
| * | | | | | wallet2: error out when we need a daemon password but have no prompt functionmoneromooo-monero2019-10-231-0/+5
| | |_|_|_|/ | |/| | | |
* | | | | | Merge pull request #6013luigi11112019-10-251-0/+1
|\ \ \ \ \ \ | |_|_|_|/ / |/| | | | | | | | | | | 635401b wallet2: fix the logged number of detached transfers (moneromooo-monero)
| * | | | | wallet2: fix the logged number of detached transfersmoneromooo-monero2019-10-231-0/+1
| |/ / / /
* | | | | Merge pull request #5357luigi11112019-10-2541-794/+3548
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | | | | | | | | | | | b3a9a4d add a quick early out to get_blocks.bin when up to date (moneromooo-monero) 2899379 daemon, wallet: new pay for RPC use system (moneromooo-monero) ffa4602 simplewallet: add public_nodes command (moneromooo-monero)
| * | | | simplewallet: add public_nodes commandmoneromooo-monero2019-10-257-22/+99
| | | | | | | | | | | | | | | | | | | | Lists nodes exposing their RPC port for public use
| * | | | daemon, wallet: new pay for RPC use systemmoneromooo-monero2019-10-2541-789/+3452
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Daemons intended for public use can be set up to require payment in the form of hashes in exchange for RPC service. This enables public daemons to receive payment for their work over a large number of calls. This system behaves similarly to a pool, so payment takes the form of valid blocks every so often, yielding a large one off payment, rather than constant micropayments. This system can also be used by third parties as a "paywall" layer, where users of a service can pay for use by mining Monero to the service provider's address. An example of this for web site access is Primo, a Monero mining based website "paywall": https://github.com/selene-kovri/primo This has some advantages: - incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own - incentive to run your own node instead of using a third party's, thereby promoting decentralization - decentralized: payment is done between a client and server, with no third party needed - private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance - no payment occurs on the blockchain, so there is no extra transactional load - one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy) - no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do - Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue - no large credit balance maintained on servers, so they have no incentive to exit scam - you can use any/many node(s), since there's little cost in switching servers - market based prices: competition between servers to lower costs - incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others - increases network security - helps counteract mining pools' share of the network hash rate - zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner And some disadvantages: - low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine) - payment is "random", so a server might go a long time without a block before getting one - a public node's overall expected payment may be small Public nodes are expected to compete to find a suitable level for cost of service. The daemon can be set up this way to require payment for RPC services: monerod --rpc-payment-address 4xxxxxx \ --rpc-payment-credits 250 --rpc-payment-difficulty 1000 These values are an example only. The --rpc-payment-difficulty switch selects how hard each "share" should be, similar to a mining pool. The higher the difficulty, the fewer shares a client will find. The --rpc-payment-credits switch selects how many credits are awarded for each share a client finds. Considering both options, clients will be awarded credits/difficulty credits for every hash they calculate. For example, in the command line above, 0.25 credits per hash. A client mining at 100 H/s will therefore get an average of 25 credits per second. For reference, in the current implementation, a credit is enough to sync 20 blocks, so a 100 H/s client that's just starting to use Monero and uses this daemon will be able to sync 500 blocks per second. The wallet can be set to automatically mine if connected to a daemon which requires payment for RPC usage. It will try to keep a balance of 50000 credits, stopping mining when it's at this level, and starting again as credits are spent. With the example above, a new client will mine this much credits in about half an hour, and this target is enough to sync 500000 blocks (currently about a third of the monero blockchain). There are three new settings in the wallet: - credits-target: this is the amount of credits a wallet will try to reach before stopping mining. The default of 0 means 50000 credits. - auto-mine-for-rpc-payment-threshold: this controls the minimum credit rate which the wallet considers worth mining for. If the daemon credits less than this ratio, the wallet will consider mining to be not worth it. In the example above, the rate is 0.25 - persistent-rpc-client-id: if set, this allows the wallet to reuse a client id across runs. This means a public node can tell a wallet that's connecting is the same as one that connected previously, but allows a wallet to keep their credit balance from one run to the other. Since the wallet only mines to keep a small credit balance, this is not normally worth doing. However, someone may want to mine on a fast server, and use that credit balance on a low power device such as a phone. If left unset, a new client ID is generated at each wallet start, for privacy reasons. To mine and use a credit balance on two different devices, you can use the --rpc-client-secret-key switch. A wallet's client secret key can be found using the new rpc_payments command in the wallet. Note: anyone knowing your RPC client secret key is able to use your credit balance. The wallet has a few new commands too: - start_mining_for_rpc: start mining to acquire more credits, regardless of the auto mining settings - stop_mining_for_rpc: stop mining to acquire more credits - rpc_payments: display information about current credits with the currently selected daemon The node has an extra command: - rpc_payments: display information about clients and their balances The node will forget about any balance for clients which have been inactive for 6 months. Balances carry over on node restart.
| * | | | add a quick early out to get_blocks.bin when up to datemoneromooo-monero2019-10-241-1/+15
| |/ / /
* | | | Merge pull request #6002luigi11112019-10-241-0/+4
|\ \ \ \ | |_|/ / |/| | | | | | | 0136bf7 v12 fork heights (tevador)