aboutsummaryrefslogtreecommitdiff
path: root/src/wallet/wallet_rpc_server.cpp
Commit message (Collapse)AuthorAgeFilesLines
...
* Merge pull request #6019luigi11112019-10-251-2/+2
|\ | | | | | | d60c1b6 changed 'batttery' to 'battery' (jakehemmerle)
| * changed 'batttery' to 'battery'Jake Hemmerle2019-10-241-2/+2
| |
* | daemon, wallet: new pay for RPC use systemmoneromooo-monero2019-10-251-0/+14
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Daemons intended for public use can be set up to require payment in the form of hashes in exchange for RPC service. This enables public daemons to receive payment for their work over a large number of calls. This system behaves similarly to a pool, so payment takes the form of valid blocks every so often, yielding a large one off payment, rather than constant micropayments. This system can also be used by third parties as a "paywall" layer, where users of a service can pay for use by mining Monero to the service provider's address. An example of this for web site access is Primo, a Monero mining based website "paywall": https://github.com/selene-kovri/primo This has some advantages: - incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own - incentive to run your own node instead of using a third party's, thereby promoting decentralization - decentralized: payment is done between a client and server, with no third party needed - private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance - no payment occurs on the blockchain, so there is no extra transactional load - one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy) - no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do - Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue - no large credit balance maintained on servers, so they have no incentive to exit scam - you can use any/many node(s), since there's little cost in switching servers - market based prices: competition between servers to lower costs - incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others - increases network security - helps counteract mining pools' share of the network hash rate - zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner And some disadvantages: - low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine) - payment is "random", so a server might go a long time without a block before getting one - a public node's overall expected payment may be small Public nodes are expected to compete to find a suitable level for cost of service. The daemon can be set up this way to require payment for RPC services: monerod --rpc-payment-address 4xxxxxx \ --rpc-payment-credits 250 --rpc-payment-difficulty 1000 These values are an example only. The --rpc-payment-difficulty switch selects how hard each "share" should be, similar to a mining pool. The higher the difficulty, the fewer shares a client will find. The --rpc-payment-credits switch selects how many credits are awarded for each share a client finds. Considering both options, clients will be awarded credits/difficulty credits for every hash they calculate. For example, in the command line above, 0.25 credits per hash. A client mining at 100 H/s will therefore get an average of 25 credits per second. For reference, in the current implementation, a credit is enough to sync 20 blocks, so a 100 H/s client that's just starting to use Monero and uses this daemon will be able to sync 500 blocks per second. The wallet can be set to automatically mine if connected to a daemon which requires payment for RPC usage. It will try to keep a balance of 50000 credits, stopping mining when it's at this level, and starting again as credits are spent. With the example above, a new client will mine this much credits in about half an hour, and this target is enough to sync 500000 blocks (currently about a third of the monero blockchain). There are three new settings in the wallet: - credits-target: this is the amount of credits a wallet will try to reach before stopping mining. The default of 0 means 50000 credits. - auto-mine-for-rpc-payment-threshold: this controls the minimum credit rate which the wallet considers worth mining for. If the daemon credits less than this ratio, the wallet will consider mining to be not worth it. In the example above, the rate is 0.25 - persistent-rpc-client-id: if set, this allows the wallet to reuse a client id across runs. This means a public node can tell a wallet that's connecting is the same as one that connected previously, but allows a wallet to keep their credit balance from one run to the other. Since the wallet only mines to keep a small credit balance, this is not normally worth doing. However, someone may want to mine on a fast server, and use that credit balance on a low power device such as a phone. If left unset, a new client ID is generated at each wallet start, for privacy reasons. To mine and use a credit balance on two different devices, you can use the --rpc-client-secret-key switch. A wallet's client secret key can be found using the new rpc_payments command in the wallet. Note: anyone knowing your RPC client secret key is able to use your credit balance. The wallet has a few new commands too: - start_mining_for_rpc: start mining to acquire more credits, regardless of the auto mining settings - stop_mining_for_rpc: stop mining to acquire more credits - rpc_payments: display information about current credits with the currently selected daemon The node has an extra command: - rpc_payments: display information about clients and their balances The node will forget about any balance for clients which have been inactive for 6 months. Balances carry over on node restart.
* Merge pull request #5940luigi11112019-10-141-0/+7
|\ | | | | | | 6b4bc0d RPC on_transfer_split error consistent with on_transfer if no tx sent (binaryFate)
| * RPC on_transfer_split error consistent with on_transfer if no tx sentbinaryFate2019-09-281-0/+7
| |
* | wallet_rpc_server: don't report integrated addresses for 0 payment IDmoneromooo-monero2019-10-141-2/+5
| | | | | | | | These are dummy ones
* | wallet: remove long payment ID sending supportmoneromooo-monero2019-10-141-24/+3
|/
* wallet: add edit_address_book RPCmoneromooo-monero2019-09-171-0/+102
|
* Merge pull request #5871luigi11112019-09-141-0/+7
|\ | | | | | | 3407743 wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_payments (moneromooo-monero)
| * wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_paymentsmoneromooo-monero2019-09-051-0/+7
| | | | | | | | Much easier to work with than the raw unlock_time field
* | Merge pull request #5870luigi11112019-09-141-0/+1
|\ \ | | | | | | | | | 83ca764 wallet_rpc_server: call deinit on exit (moneromooo-monero)
| * | wallet_rpc_server: call deinit on exitmoneromooo-monero2019-08-281-0/+1
| |/
* | Merge pull request #5855luigi11112019-09-081-8/+8
|\ \ | |/ |/| | | 2ec455d wallet: fix mismatch between two concepts of 'balance' (moneromooo-monero)
| * wallet: fix mismatch between two concepts of "balance"moneromooo-monero2019-09-051-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | One considers the blockchain, while the other considers the blockchain and some recent actions, such as a recently created transaction which spend some outputs, but isn't yet mined. Typically, the "balance" command wants the latter, to reflect the recent action, but things like proving ownership wants the former. This fixes a crash in get_reserve_proof, where a preliminary check and the main code used two concepts of "balance".
* | wallet, rpc: add a release field to get_versionmoneromooo-monero2019-08-261-0/+2
|/ | | | | | | It does not leak much since you can make a fair guess by RPC version already, and some people want to avoid non release clients when using third parties' nodes (because they'd never lie about it)
* Merge pull request #5750luigi11112019-08-211-2/+2
|\ | | | | | | 884df82 wallet: provide original address for outgoing transfers (xiphon)
| * wallet: provide original address for outgoing transfersxiphon2019-07-101-2/+2
| |
* | Merge pull request #5478luigi11112019-08-141-3/+2
|\ \ | | | | | | | | | 7d9b7fe functional_tests: add validate_address tests (moneromooo-monero)
| * | functional_tests: add validate_address testsmoneromooo-monero2019-07-291-3/+2
| | |
* | | Add IPv6 supportThomas Winget2019-07-311-1/+3
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | new cli options (RPC ones also apply to wallet): --p2p-bind-ipv6-address (default = "::") --p2p-bind-port-ipv6 (default same as ipv4 port for given nettype) --rpc-bind-ipv6-address (default = "::1") --p2p-use-ipv6 (default false) --rpc-use-ipv6 (default false) --p2p-require-ipv4 (default true, if ipv4 bind fails and this is true, will not continue even if ipv6 bind successful) --rpc-require-ipv4 (default true, description as above) ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except in the cases of the cli args for bind address. For those the square braces can be omitted.
* | Merge pull request #5513luigi11112019-07-241-1/+6
|\ \ | | | | | | | | | bc94ba4 wallet: distinguish between empty and absent attributes (moneromooo-monero)
| * | wallet: distinguish between empty and absent attributesmoneromooo-monero2019-05-021-1/+6
| | |
* | | Merge pull request #5457luigi11112019-07-241-2/+0
|\ \ \ | | | | | | | | | | | | 3b9ce45 wallet_rpc_server: remove unused variable (moneromooo-monero)
| * | | wallet_rpc_server: remove unused variablemoneromooo-monero2019-04-171-2/+0
| | | |
* | | | wallet_rpc_server: fix get_bulk_payments with short payment idsmoneromooo-monero2019-07-091-0/+5
| |_|/ |/| |
* | | Fix allow any cert mode in wallet rpc when configured over rpcLee Clagett2019-05-221-1/+5
| | |
* | | Add ssl_options support to monerod's rpc mode.Lee Clagett2019-05-221-50/+1
| | |
* | | Merge pull request #5538luigi11112019-05-141-1/+1
|\ \ \ | | | | | | | | | | | | 615f287 wallet: fix certificate fingerprint length check (moneromooo-monero)
| * | | wallet: fix certificate fingerprint length checkmoneromooo-monero2019-05-111-1/+1
| | | | | | | | | | | | | | | | Fixed by crCr62U0
* | | | wallet_rpc_server: use original addresses in destinations in get_transfersmoneromooo-monero2019-05-101-1/+9
|/ / / | | | | | | | | | And add them for pending transfers, where they were missing
* | | Merge pull request #5503Riccardo Spagni2019-05-071-4/+4
|\ \ \ | | | | | | | | | | | | ccc1e311 wallet_rpc_server: reject standalone short payment id in address book (moneromooo-monero)
| * | | wallet_rpc_server: reject standalone short payment id in address bookmoneromooo-monero2019-04-301-4/+4
| | |/ | |/|
* | | Merge pull request #5493Riccardo Spagni2019-05-021-0/+9
|\ \ \ | | | | | | | | | | | | 5e0da6fb change SSL certificate fingerprint whitelisting from SHA1 to SHA-256 (moneromooo-monero)
| * | | change SSL certificate fingerprint whitelisting from SHA1 to SHA-256moneromooo-monero2019-04-261-0/+9
| |/ / | | | | | | | | | SHA1 is too close to bruteforceable
* | | Merge pull request #5491Riccardo Spagni2019-05-021-2/+4
|\ \ \ | |/ / |/| | | | | | | | | | | 98fb98f9 wallet_rpc_server: adding missing return on error in set_daemon (moneromooo-monero) 9074c0d8 wallet_rpc_server: return false on error in set_log_categories (moneromooo-monero) 968848a7 wallet_rpc_server: fix crash in validate_address if no wallet is loaded (moneromooo-monero)
| * | wallet_rpc_server: adding missing return on error in set_daemonmoneromooo-monero2019-04-251-0/+1
| | |
| * | wallet_rpc_server: return false on error in set_log_categoriesmoneromooo-monero2019-04-251-1/+1
| | | | | | | | | | | | Reported by SmajeNz0
| * | wallet_rpc_server: fix crash in validate_address if no wallet is loadedmoneromooo-monero2019-04-251-1/+2
| | | | | | | | | | | | Reported by SmajeNz0
* | | wallet_rpc_server: add block_height and frozen to incoming_transfersmoneromooo-monero2019-04-201-0/+2
|/ /
* | Merge pull request #5458Riccardo Spagni2019-04-181-0/+1
|\ \ | | | | | | | | | 84047cb7 wallet_rpc_server: add unlocked field to incoming_transfers output (moneromooo-monero)
| * | wallet_rpc_server: add unlocked field to incoming_transfers outputmoneromooo-monero2019-04-171-0/+1
| |/
* / wallet_rpc_server: set suggested_confirmations_threshold for pool txesmoneromooo-monero2019-04-161-5/+3
|/
* wallet_rpc_server: add set_log_level/set_log_categoriesmoneromooo-monero2019-04-161-0/+33
|
* Merge pull request #5446Riccardo Spagni2019-04-161-5/+1
|\ | | | | | | | | | | | | | | | | 7d79222f daemon: remove debug info (moneromooo-monero) 8fec0f98 functional_tests: add sweep_single test (moneromooo-monero) 9880d61b wallet_rpc_server: remove unused code (moneromooo-monero) 8a61b33d rpc: omit irrelevant fields for pool txes in gettransactions (moneromooo-monero) 56508524 rpc: add relayed in get_transaction output (moneromooo-monero) 82e510f1 rpc: set default log category in core_rpc_server.h (moneromooo-monero)
| * wallet_rpc_server: remove unused codemoneromooo-monero2019-04-151-5/+1
| |
* | Merge pull request #5429Riccardo Spagni2019-04-161-41/+48
|\ \ | | | | | | | | | bcb86ae6 wallet_rpc_server: fix inconsistent wallet caches on reload (moneromooo-monero)
| * | wallet_rpc_server: fix inconsistent wallet caches on reloadmoneromooo-monero2019-04-121-41/+48
| |/ | | | | | | | | | | | | | | | | | | Loading the same wallet as the currently loaded one would autosave the current state after loading it, leading to some kind of rollback effect. We now save before loading to avoid this. If loading fails, it means the current wallet will be saved (or maybe not, depending on where the failure occurs: most of the sanity checks occur before saving). There is a new autosave_current flag to open/restore calls so the (enabled by default) autosave can be skipped.
* | Merge pull request #5418Riccardo Spagni2019-04-161-1/+1
|\ \ | |/ |/| | | 374f388d wallet_rpc_server: add a all flag to export_outputs (moneromooo-monero)
| * wallet_rpc_server: add a all flag to export_outputsmoneromooo-monero2019-04-101-1/+1
| | | | | | | | if we don't want to export new outputs only
* | Merge pull request #5382Riccardo Spagni2019-04-111-4/+5
|\ \ | | | | | | | | | | | | | | | | | | c12b43cb wallet: add number of blocks required for the balance to fully unlock (moneromooo-monero) 3f1e9e84 wallet2: set confirmations to 0 for pool txes in proofs (moneromooo-monero) 36c037ec wallet_rpc_server: error out on getting the spend key from a hot wallet (moneromooo-monero) cd1eaff2 wallet_rpc_server: always fill out subaddr_indices in get_transfers (moneromooo-monero)