summaryrefslogtreecommitdiff
path: root/src/wallet/wallet_rpc_server.cpp
Commit message (Collapse)AuthorAgeFilesLines
* wallet: feature: transfer amount with fee includedjeffro2562024-02-201-8/+14
| | | | | | | | | | | | | | | | | To transfer ~5 XMR to an address such that your balance drops by exactly 5 XMR, provide a `subtractfeefrom` flag to the `transfer` command. For example: transfer 76bDHojqFYiFCCYYtzTveJ8oFtmpNp3X1TgV2oKP7rHmZyFK1RvyE4r8vsJzf7SyNohMnbKT9wbcD3XUTgsZLX8LU5JBCfm 5 subtractfeefrom=all If my walet balance was exactly 30 XMR before this transaction, it will be exactly 25 XMR afterwards and the destination address will receive slightly less than 5 XMR. You can manually select which destinations fund the transaction fee and which ones do not by providing the destination index. For example: transfer 75sr8AAr... 3 74M7W4eg... 4 7AbWqDZ6... 5 subtractfeefrom=0,2 This will drop your balance by exactly 12 XMR including fees and will spread the fee cost proportionally (3:5 ratio) over destinations with addresses `75sr8AAr...` and `7AbWqDZ6...`, respectively. Disclaimer: This feature was paid for by @LocalMonero.
* wallet2: fix refresh function parametersselsta2023-10-011-1/+1
| | | | max_blocks is last on master branch
* wallet_rpc_server: chunk refresh to keep responding to RPC while refreshingmoneromooo-monero2023-08-171-2/+6
|
* wallet_rpc_server: add --no-initial-sync flag for quicker network bindingmoneromooo-monero2023-08-171-1/+5
|
* Merge pull request #8942luigi11112023-08-171-3/+30
|\ | | | | | | 78348bc wallet-rpc: restore from multisig seed (jeffro256)
| * wallet-rpc: restore from multisig seedjeffro2562023-08-101-3/+30
| |
* | Enforce restricted # pool txs served via RPC + optimize chunked reqs ↵j-berman2023-07-091-1/+3
|/ | | | | | | | | | | | | | | | | | | | | | [release-v0.18] - `/getblocks.bin` respects the `RESTRICTED_TX_COUNT` (=100) when returning pool txs via a restricted RPC daemon. - A restricted RPC daemon includes a max of `RESTRICTED_TX_COUNT` txs in the `added_pool_txs` field, and returns any remaining pool hashes in the `remaining_added_pool_txids` field. The client then requests the remaining txs via `/gettransactions` in chunks. - `/gettransactions` no longer does expensive no-ops for ALL pool txs if the client requests a subset of pool txs. Instead it searches for the txs the client explicitly requests. - Reset `m_pool_info_query_time` when a user: (1) rescans the chain (so the wallet re-requests the whole pool) (2) changes the daemon their wallets points to (a new daemon would have a different view of the pool) - `/getblocks.bin` respects the `req.prune` field when returning pool txs. - Pool extension fields in response to `/getblocks.bin` are optional with default 0'd values.
* wallet2: fix rescanning tx via scan_txj-berman2023-03-131-2/+6
| | | | | | | | | | | | | | | | | - Detach & re-process txs >= lowest scan height - ensures that if a user calls scan_tx(tx1) after scanning tx2, the wallet correctly processes tx1 and tx2 - if a user provides a tx with a height higher than the wallet's last scanned height, the wallet will scan starting from that tx's height - scan_tx requires trusted daemon iff need to re-process existing txs: in addition to querying a daemon for txids, if a user provides a txid of a tx with height *lower* than any *already* scanned txs in the wallet, then the wallet will also query the daemon for all the *higher* txs as well. This is likely unexpected behavior to a caller, and so to protect a caller from revealing txid's to an untrusted daemon in an unexpected way, require the daemon be trusted.
* add an option to force-update multisig key exchange under some circumstanceskoe2022-09-211-8/+1
|
* allow exporting outputs in chunksmoneromooo-monero2022-09-071-1/+1
| | | | | this will make it easier huge wallets to do so without hitting random limits (eg, max string size in node).
* disable multisig by defaultmoneromooo-monero2022-05-171-0/+33
| | | | | | | | | There are vulnerabilities in multisig protocol if the parties do not trust each other, and while there is a patch for it, it has not been throroughly reviewed yet, so it is felt safer to disable multisig by default for now. If all parties in a multisig setup trust each other, then it is safe to enable multisig.
* Merge pull request #8220luigi11112022-05-101-1/+2
|\ | | | | | | 0d6ecb1 multisig: add post-kex verification round to check that all participants have completed the multisig address (koe)
| * multisig: add post-kex verification round to check that all participants ↵koe2022-04-291-1/+2
| | | | | | | | have completed the multisig address
* | Merge pull request #8215luigi11112022-04-061-2/+10
|\ \ | | | | | | | | | d1f1947 wallet_rpc_server: support regex for get_accounts tag (reemuru)
| * | wallet_rpc_server: support regex for get_accounts tagreemuru2022-03-131-2/+10
| |/ | | | | | | | | | | | | | | This commit adds a 'regexp' boolean field to the get_accounts request. The flag is set to false by default and maintains backwards compatibility. When set to true the user can search tags by regular expression filters. An additional error message was added for failed regular expression searches. Bump minor version to 25.
* | Merge pull request #8213luigi11112022-04-061-6/+0
|\ \ | | | | | | | | | 7dcfccb wallet_rpc_server: fix make_integrated_address with no payment id (moneromooo-monero)
| * | wallet_rpc_server: fix make_integrated_address with no payment idmoneromooo-monero2022-03-111-6/+0
| |/
* / Copyright: Update to 2022mj-xmr2022-03-041-1/+1
|/
* Merge pull request #8145luigi11112022-03-021-1/+5
|\ | | | | | | fb5b2b3 support authentication in monero-wallet-rpc set_daemon (woodser)
| * support authentication in monero-wallet-rpc set_daemonwoodser2022-01-171-1/+5
| |
* | multisig key exchange update and refactorkoe2022-02-221-50/+4
|/
* Merge pull request #7898luigi11112021-09-091-1/+2
|\ | | | | | | f353c29 wallet_rpc_server: fix help text remaining bold (selsta)
| * wallet_rpc_server: fix help text remaining boldselsta2021-08-271-1/+2
| |
* | Merge pull request #7823luigi11112021-09-091-0/+8
|\ \ | |/ |/| | | 24d3d65 monero-wallet-rpc: Prevent --password-file from being used with --wallet-dir (Kermit Alexander II)
| * monero-wallet-rpc: Prevent --password-file from being used with --wallet-dirKermit Alexander II2021-08-201-0/+8
| |
* | Fix describe_transfer for multiple txes in a txsetAlex Opie2021-08-021-9/+32
|/ | | | | | | | This ensures each list of recipients is only the recipients for one transaction. It also adds a new field "summary" that describes the txset as a whole. Fixes #7344
* provide key images of spent outputs in wallet rpcwoodser2021-06-151-7/+18
|
* Merge pull request #7661luigi11112021-06-101-2/+1
|\ | | | | | | 08e4497 Improve cryptonote (block and tx) binary read performance (Lee Clagett)
| * Improve cryptonote (block and tx) binary read performanceLee Clagett2021-01-231-2/+1
| |
* | support freeze, thaw, and frozen in wallet rpcwoodser2021-05-181-0/+84
|/
* Merge pull request #7651luigi11112021-04-221-1/+6
|\ | | | | | | c8ff1d4 monero-wallet-cli: improve error message when tx amount is zero (Elliot Wirrick)
| * monero-wallet-cli: improve error message when tx amount is zeroElliot Wirrick2021-04-071-1/+6
| |
* | Merge pull request #7321luigi11112021-04-061-1/+1
|\ \ | |/ |/| | | f9b5b52 fix serialization being different on mac (moneromooo-monero)
| * fix serialization being different on macmoneromooo-monero2021-03-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | On Mac, size_t is a distinct type from uint64_t, and some types (in wallet cache as well as cold/hot wallet transfer data) use pairs/containers with size_t as fields. Mac would save those as full size, while other platforms would save them as varints. Might apply to other platforms where the types are distinct. There's a nasty hack for backward compatibility, which can go after a couple forks.
* | Merge pull request #7430luigi11112021-03-291-17/+13
|\ \ | | | | | | | | | 064eeb2 wallet_rpc_server: set seed language in generate_from_keys (moneromooo-monero)
| * | wallet_rpc_server: set seed language in generate_from_keysmoneromooo-monero2021-03-061-17/+13
| |/ | | | | | | Also sanity check language name
* | Merge pull request #7422luigi11112021-03-201-0/+1
|\ \ | | | | | | | | | d46d90c return output key for incoming transfers (benevanoff)
| * | return output key for incoming transfersbenevanoff2021-03-041-0/+1
| | |
* | | wallet_rpc: add scan_txtobtoht2021-03-011-0/+35
| |/ |/|
* | Merge pull request #7355luigi11112021-02-181-1/+1
|\ \ | | | | | | | | | | | | bd12984 Remove copies from foreach loops (thanks to Clang) (Lee Clagett) 1572df9 Removing unused namespace alias (Lee Clagett)
| * | Remove copies from foreach loops (thanks to Clang)Lee Clagett2021-01-281-1/+1
| |/
* | Merge pull request #7346luigi11112021-02-181-1/+0
|\ \ | | | | | | | | | 85db173 Remove unused variables in monero codebase (Kevin Barbour)
| * | Remove unused variables in monero codebaseKevin Barbour2021-02-091-1/+0
| |/ | | | | | | | | | | | | | | | | | | | | There are quite a few variables in the code that are no longer (or perhaps never were) in use. These were discovered by enabling compiler warnings for unused variables and cleaning them up. In most cases where the unused variables were the result of a function call the call was left but the variable assignment removed, unless it was obvious that it was a simple getter with no side effects.
* / wallet_rpc_server: don't abort on initial refresh failurexiphon2021-01-071-1/+8
|/
* Bind signature to full address and signing modeSarang Noether2020-08-281-3/+0
|
* wallet: allow signing a message with spend or view keymoneromooo-monero2020-08-281-2/+25
|
* replace most boost serialization with existing monero serializationmoneromooo-monero2020-08-171-5/+23
| | | | | | | | | | | | | | | | | | | | | | This reduces the attack surface for data that can come from malicious sources (exported output and key images, multisig transactions...) since the monero serialization is already exposed to the outside, and the boost lib we were using had a few known crashers. For interoperability, a new load-deprecated-formats wallet setting is added (off by default). This allows loading boost format data if there is no alternative. It will likely go at some point, along with the ability to load those. Notably, the peer lists file still uses the boost serialization code, as the data it stores is define in epee, while the new serialization code is in monero, and migrating it was fairly hairy. Since this file is local and not obtained from anyone else, the marginal risk is minimal, but it could be migrated later if needed. Some tests and tools also do, this will stay as is for now.
* Merge pull request #6546Alexander Blair2020-08-161-5/+17
|\ | | | | | | eda167585 wallet_rpc_server: use unlock_time in suggested confirmations calc (moneromooo-monero)
| * wallet_rpc_server: use unlock_time in suggested confirmations calcmoneromooo-monero2020-05-171-5/+17
| |
* | Update copyright year to 2020SomaticFanatic2020-05-061-1/+1
|/ | | | Update copyright year to 2020