summaryrefslogtreecommitdiff
path: root/src/wallet/wallet_rpc_server.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #8166luigi11112022-04-061-1/+5
|\ | | | | | | 41b87b1 support authentication in monero-wallet-rpc set_daemon (woodser)
| * support authentication in monero-wallet-rpc set_daemonwoodser2022-01-311-1/+5
| |
* | multisig key exchange update and refactorkoe2022-02-241-50/+4
|/
* support freeze, thaw, and frozen in wallet rpcwoodser2021-08-121-0/+84
|
* provide key images of spent outputs in wallet rpcwoodser2021-08-071-7/+18
|
* fix serialization being different on macmoneromooo-monero2021-03-051-1/+1
| | | | | | | | | | | | On Mac, size_t is a distinct type from uint64_t, and some types (in wallet cache as well as cold/hot wallet transfer data) use pairs/containers with size_t as fields. Mac would save those as full size, while other platforms would save them as varints. Might apply to other platforms where the types are distinct. There's a nasty hack for backward compatibility, which can go after a couple forks.
* Bind signature to full address and signing modeSarang Noether2020-08-281-3/+0
|
* wallet: allow signing a message with spend or view keymoneromooo-monero2020-08-281-2/+25
|
* replace most boost serialization with existing monero serializationmoneromooo-monero2020-08-171-5/+23
| | | | | | | | | | | | | | | | | | | | | | This reduces the attack surface for data that can come from malicious sources (exported output and key images, multisig transactions...) since the monero serialization is already exposed to the outside, and the boost lib we were using had a few known crashers. For interoperability, a new load-deprecated-formats wallet setting is added (off by default). This allows loading boost format data if there is no alternative. It will likely go at some point, along with the ability to load those. Notably, the peer lists file still uses the boost serialization code, as the data it stores is define in epee, while the new serialization code is in monero, and migrating it was fairly hairy. Since this file is local and not obtained from anyone else, the marginal risk is minimal, but it could be migrated later if needed. Some tests and tools also do, this will stay as is for now.
* Merge pull request #6546Alexander Blair2020-08-161-5/+17
|\ | | | | | | eda167585 wallet_rpc_server: use unlock_time in suggested confirmations calc (moneromooo-monero)
| * wallet_rpc_server: use unlock_time in suggested confirmations calcmoneromooo-monero2020-05-171-5/+17
| |
* | Update copyright year to 2020SomaticFanatic2020-05-061-1/+1
|/ | | | Update copyright year to 2020
* simplewallet: report timestamp based expected unlock time on balancemoneromooo-monero2020-04-221-4/+5
|
* Merge pull request #6268Alexander Blair2020-03-121-2/+2
|\ | | | | | | a6c24412 wallet: fix exceptions getting the hash of a pruned tx (moneromooo-monero)
| * wallet: fix exceptions getting the hash of a pruned txmoneromooo-monero2019-12-301-2/+2
| |
* | Merge pull request #6241Alexander Blair2020-02-281-1/+12
|\ \ | | | | | | | | | ae84ec90 wallet-cli/rpc: allow sweep_all to use outputs in all subaddresses within an account (stoffu)
| * | wallet-cli/rpc: allow sweep_all to use outputs in all subaddresses within an ↵stoffu2019-12-161-1/+12
| |/ | | | | | | account
* | Merge pull request #6203Alexander Blair2020-02-281-1/+0
|\ \ | | | | | | | | | ef95a76d remove unused variable 'ptx' from on_describe_transfer() (woodser)
| * | remove unused variable 'ptx' from on_describe_transfer()woodser2019-12-011-1/+0
| |/
* | Merge pull request #6190luigi11112020-02-191-0/+2
|\ \ | | | | | | | | | 096a9db Wallet: Distingush amounts for a single subaddress (tmoravec)
| * | Wallet: Distingush amounts for a single subaddressTadeas Moravec2020-01-111-0/+2
| |/ | | | | | | | | | | | | | | Adding a new `amounts` field ot the output of `get_transfers` RPC method. This field specifies individual payments made to a single subaddress in a single transaction, e.g., made by this command: transfer <addr1> <amount1> <addr1> <amount2>
* | Merge pull request #6102Alexander Blair2020-02-061-6/+7
|\ \ | | | | | | | | | b328de6b wallet_rpc_server: add tx weight in transfer commands responses (moneromooo-monero)
| * | wallet_rpc_server: add tx weight in transfer commands responsesmoneromooo-monero2019-11-051-6/+7
| |/
* | Merge pull request #6069Alexander Blair2020-02-061-1/+1
|\ \ | | | | | | | | | d64e5aa7 wallet: allow message sign/verify for subaddresses (moneromooo-monero)
| * | wallet: allow message sign/verify for subaddressesmoneromooo-monero2019-12-311-1/+1
| | |
* | | wallet: do not split integrated addresses in address book apimoneromooo-monero2020-01-261-78/+17
| | |
* | | Merge pull request #6144Alexander Blair2020-01-161-3/+23
|\ \ \ | | | | | | | | | | | | 0e0351c4 wallet_rpc_server: add count parameter to create_address (Matt Smith)
| * | | wallet_rpc_server: add count parameter to create_addressMatt Smith2019-11-221-3/+23
| | |/ | |/|
* / | wallet_rpc_server: new estimate_tx_size_and_weight RPCmoneromooo-monero2019-11-061-0/+19
|/ /
* / wallet: fix another facet of "did I get some monero" information leakmoneromooo-monero2019-11-011-2/+8
|/ | | | | | | We get new pool txes before processing any tx, pool or not. This ensures that if we're asked for a password, this does not cause a measurable delay in the txpool query after the last block query.
* Merge pull request #6019luigi11112019-10-251-2/+2
|\ | | | | | | d60c1b6 changed 'batttery' to 'battery' (jakehemmerle)
| * changed 'batttery' to 'battery'Jake Hemmerle2019-10-241-2/+2
| |
* | daemon, wallet: new pay for RPC use systemmoneromooo-monero2019-10-251-0/+14
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Daemons intended for public use can be set up to require payment in the form of hashes in exchange for RPC service. This enables public daemons to receive payment for their work over a large number of calls. This system behaves similarly to a pool, so payment takes the form of valid blocks every so often, yielding a large one off payment, rather than constant micropayments. This system can also be used by third parties as a "paywall" layer, where users of a service can pay for use by mining Monero to the service provider's address. An example of this for web site access is Primo, a Monero mining based website "paywall": https://github.com/selene-kovri/primo This has some advantages: - incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own - incentive to run your own node instead of using a third party's, thereby promoting decentralization - decentralized: payment is done between a client and server, with no third party needed - private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance - no payment occurs on the blockchain, so there is no extra transactional load - one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy) - no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do - Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue - no large credit balance maintained on servers, so they have no incentive to exit scam - you can use any/many node(s), since there's little cost in switching servers - market based prices: competition between servers to lower costs - incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others - increases network security - helps counteract mining pools' share of the network hash rate - zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner And some disadvantages: - low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine) - payment is "random", so a server might go a long time without a block before getting one - a public node's overall expected payment may be small Public nodes are expected to compete to find a suitable level for cost of service. The daemon can be set up this way to require payment for RPC services: monerod --rpc-payment-address 4xxxxxx \ --rpc-payment-credits 250 --rpc-payment-difficulty 1000 These values are an example only. The --rpc-payment-difficulty switch selects how hard each "share" should be, similar to a mining pool. The higher the difficulty, the fewer shares a client will find. The --rpc-payment-credits switch selects how many credits are awarded for each share a client finds. Considering both options, clients will be awarded credits/difficulty credits for every hash they calculate. For example, in the command line above, 0.25 credits per hash. A client mining at 100 H/s will therefore get an average of 25 credits per second. For reference, in the current implementation, a credit is enough to sync 20 blocks, so a 100 H/s client that's just starting to use Monero and uses this daemon will be able to sync 500 blocks per second. The wallet can be set to automatically mine if connected to a daemon which requires payment for RPC usage. It will try to keep a balance of 50000 credits, stopping mining when it's at this level, and starting again as credits are spent. With the example above, a new client will mine this much credits in about half an hour, and this target is enough to sync 500000 blocks (currently about a third of the monero blockchain). There are three new settings in the wallet: - credits-target: this is the amount of credits a wallet will try to reach before stopping mining. The default of 0 means 50000 credits. - auto-mine-for-rpc-payment-threshold: this controls the minimum credit rate which the wallet considers worth mining for. If the daemon credits less than this ratio, the wallet will consider mining to be not worth it. In the example above, the rate is 0.25 - persistent-rpc-client-id: if set, this allows the wallet to reuse a client id across runs. This means a public node can tell a wallet that's connecting is the same as one that connected previously, but allows a wallet to keep their credit balance from one run to the other. Since the wallet only mines to keep a small credit balance, this is not normally worth doing. However, someone may want to mine on a fast server, and use that credit balance on a low power device such as a phone. If left unset, a new client ID is generated at each wallet start, for privacy reasons. To mine and use a credit balance on two different devices, you can use the --rpc-client-secret-key switch. A wallet's client secret key can be found using the new rpc_payments command in the wallet. Note: anyone knowing your RPC client secret key is able to use your credit balance. The wallet has a few new commands too: - start_mining_for_rpc: start mining to acquire more credits, regardless of the auto mining settings - stop_mining_for_rpc: stop mining to acquire more credits - rpc_payments: display information about current credits with the currently selected daemon The node has an extra command: - rpc_payments: display information about clients and their balances The node will forget about any balance for clients which have been inactive for 6 months. Balances carry over on node restart.
* Merge pull request #5940luigi11112019-10-141-0/+7
|\ | | | | | | 6b4bc0d RPC on_transfer_split error consistent with on_transfer if no tx sent (binaryFate)
| * RPC on_transfer_split error consistent with on_transfer if no tx sentbinaryFate2019-09-281-0/+7
| |
* | wallet_rpc_server: don't report integrated addresses for 0 payment IDmoneromooo-monero2019-10-141-2/+5
| | | | | | | | These are dummy ones
* | wallet: remove long payment ID sending supportmoneromooo-monero2019-10-141-24/+3
|/
* wallet: add edit_address_book RPCmoneromooo-monero2019-09-171-0/+102
|
* Merge pull request #5871luigi11112019-09-141-0/+7
|\ | | | | | | 3407743 wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_payments (moneromooo-monero)
| * wallet_rpc_server: add locked field to get_transfers/get_{bulk_,}_paymentsmoneromooo-monero2019-09-051-0/+7
| | | | | | | | Much easier to work with than the raw unlock_time field
* | Merge pull request #5870luigi11112019-09-141-0/+1
|\ \ | | | | | | | | | 83ca764 wallet_rpc_server: call deinit on exit (moneromooo-monero)
| * | wallet_rpc_server: call deinit on exitmoneromooo-monero2019-08-281-0/+1
| |/
* | Merge pull request #5855luigi11112019-09-081-8/+8
|\ \ | |/ |/| | | 2ec455d wallet: fix mismatch between two concepts of 'balance' (moneromooo-monero)
| * wallet: fix mismatch between two concepts of "balance"moneromooo-monero2019-09-051-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | One considers the blockchain, while the other considers the blockchain and some recent actions, such as a recently created transaction which spend some outputs, but isn't yet mined. Typically, the "balance" command wants the latter, to reflect the recent action, but things like proving ownership wants the former. This fixes a crash in get_reserve_proof, where a preliminary check and the main code used two concepts of "balance".
* | wallet, rpc: add a release field to get_versionmoneromooo-monero2019-08-261-0/+2
|/ | | | | | | It does not leak much since you can make a fair guess by RPC version already, and some people want to avoid non release clients when using third parties' nodes (because they'd never lie about it)
* Merge pull request #5750luigi11112019-08-211-2/+2
|\ | | | | | | 884df82 wallet: provide original address for outgoing transfers (xiphon)
| * wallet: provide original address for outgoing transfersxiphon2019-07-101-2/+2
| |
* | Merge pull request #5478luigi11112019-08-141-3/+2
|\ \ | | | | | | | | | 7d9b7fe functional_tests: add validate_address tests (moneromooo-monero)
| * | functional_tests: add validate_address testsmoneromooo-monero2019-07-291-3/+2
| | |
* | | Add IPv6 supportThomas Winget2019-07-311-1/+3
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | new cli options (RPC ones also apply to wallet): --p2p-bind-ipv6-address (default = "::") --p2p-bind-port-ipv6 (default same as ipv4 port for given nettype) --rpc-bind-ipv6-address (default = "::1") --p2p-use-ipv6 (default false) --rpc-use-ipv6 (default false) --p2p-require-ipv4 (default true, if ipv4 bind fails and this is true, will not continue even if ipv6 bind successful) --rpc-require-ipv4 (default true, description as above) ipv6 addresses are to be specified as "[xx:xx:xx::xx:xx]:port" except in the cases of the cli args for bind address. For those the square braces can be omitted.