aboutsummaryrefslogtreecommitdiff
path: root/src/wallet/wallet2.cpp
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge pull request #6235Alexander Blair2020-02-281-1/+1
|\ \ \ | | | | | | | | | | | | 5cbb17b9 wallet2: fix hang in wallet refresh (moneromooo-monero)
| * | | wallet2: fix hang in wallet refreshmoneromooo-monero2019-12-141-1/+1
| |/ / | | | | | | | | | | | | | | | | | | | | | | | | If the hashes received would move the current blockchain past the stop point, the short history would not be updated, since we do not expect another loop, but the daemon might return earlier hashes, causing the end index to not be enough to reach the threshold and this require another loop, which will download the same hashes and cause an infinite loop.
* | | Merge pull request #6194luigi11112020-02-191-1/+1
|\ \ \ | | | | | | | | | | | | 316ab7b wallet2: better error when restoring a wallet with the wrong keys (moneromooo-monero)
| * | | wallet2: better error when restoring a wallet with the wrong keysmoneromooo-monero2019-11-281-1/+1
| | | |
* | | | Merge pull request #6190luigi11112020-02-191-1/+27
|\ \ \ \ | | | | | | | | | | | | | | | 096a9db Wallet: Distingush amounts for a single subaddress (tmoravec)
| * | | | Wallet: Distingush amounts for a single subaddressTadeas Moravec2020-01-111-1/+27
| | |/ / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | Adding a new `amounts` field ot the output of `get_transfers` RPC method. This field specifies individual payments made to a single subaddress in a single transaction, e.g., made by this command: transfer <addr1> <amount1> <addr1> <amount2>
* | | | Merge pull request #6103Alexander Blair2020-02-061-0/+6
|\ \ \ \ | | | | | | | | | | | | | | | 4b384003 wallet2: don't try to lock an empty filename (moneromooo-monero)
| * | | | wallet2: don't try to lock an empty filenamemoneromooo-monero2019-11-051-0/+6
| | | | |
* | | | | Merge pull request #6069Alexander Blair2020-02-061-2/+16
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | d64e5aa7 wallet: allow message sign/verify for subaddresses (moneromooo-monero)
| * | | | | wallet: allow message sign/verify for subaddressesmoneromooo-monero2019-12-311-2/+16
| | | | | |
* | | | | | wallet: do not split integrated addresses in address book apimoneromooo-monero2020-01-261-4/+6
| | | | | |
* | | | | | Merge pull request #6154Alexander Blair2020-01-241-0/+1
|\ \ \ \ \ \ | |_|_|_|_|/ |/| | | | | | | | | | | 3b419333 wallet: don't issue node rpc proxy requests in '--offline' mode (xiphon)
| * | | | | wallet: don't issue node rpc proxy requests in '--offline' modexiphon2019-11-191-0/+1
| | |/ / / | |/| | |
* | | | | Merge pull request #6105Alexander Blair2020-01-111-0/+18
|\ \ \ \ \ | |_|_|/ / |/| | | | | | | | | 0de8a0d3 wallet_rpc_server: new estimate_tx_size_and_weight RPC (moneromooo-monero)
| * | | | wallet_rpc_server: new estimate_tx_size_and_weight RPCmoneromooo-monero2019-11-061-0/+18
| |/ / /
* | | | Merge pull request #6057luigi11112019-12-121-3/+21
|\ \ \ \ | |_|_|/ |/| | | | | | | 3b8dcc2 wallet2: make keys unlocker reentrant (moneromooo-monero)
| * | | wallet2: make keys unlocker reentrantmoneromooo-monero2019-10-291-3/+21
| | |/ | |/| | | | | | | protects against having your keys mangled
* | | wallet2: fix pool txes not being flushed when minedmoneromooo-monero2019-11-041-1/+1
| |/ |/|
* | wallet2: fix is_synced checking target height, not heightmoneromooo-monero2019-11-011-1/+1
| | | | | | | | | | | | Target height would be appropriate for the daemon, which syncs off other daemons, but the wallet syncs off the daemon it's connected to, and its target is the daemon's current height.
* | wallet: fix another facet of "did I get some monero" information leakmoneromooo-monero2019-11-011-10/+30
| | | | | | | | | | | | | | We get new pool txes before processing any tx, pool or not. This ensures that if we're asked for a password, this does not cause a measurable delay in the txpool query after the last block query.
* | wallet2: do not send an unnecessary last getblocks.bin call on refreshmoneromooo-monero2019-11-011-5/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The "everything refreshed" state was detected when a refresh call did not return any new blocks. This can be detected without that extra "empty" call by comparing the claimed node height to the height of the last block retrieved. Doing this avoids that last call, saves some bandwidth, and makes the common refresh case use only one call rather than two. As a side effect, it prevents an information leak reported by Tramèr et al: if the wallet retrieves a set of blocks which includes an output sent to the refreshing wallet, the wallet will prompt the user for the password to decode the amount and calculate the key image for the new output, and this will delay subsequent calls to getblocks.bin, allowing a passive adversary to note the delay and deduce when the wallet receives at least one output. This can still happen if the wallet downloads more than 1000 blocks, since this will be split in several calls, but then the most the adversary can tell is which 1000 block section the user received some monero (the adversary can estimate the heights of the blocks by calculating how many "large" transfers are done, which will be sections of blocks, the last of which will usually be below 1000, but the size of the data should allow the actual number of blocks sent to be determined fairly accurately). This timing trick still be used via the subsequent scan for incoming txes in the txpool, which will be fixed later.
* | wallet2: do not repeatedly ask for pool txes sent to usmoneromooo-monero2019-11-011-5/+0
|/ | | | | | | | This lets a passive attacker with access to the network link between node and wallet perform traffic analysis to deduce when an idle wallet receives a transaction. Reported by Tramèr et al.
* Merge pull request #6014luigi11112019-10-251-0/+5
|\ | | | | | | 93e7426 wallet2: error out when we need a daemon password but have no prompt function (moneromooo-monero)
| * wallet2: error out when we need a daemon password but have no prompt functionmoneromooo-monero2019-10-231-0/+5
| |
* | Merge pull request #6013luigi11112019-10-251-0/+1
|\ \ | | | | | | | | | 635401b wallet2: fix the logged number of detached transfers (moneromooo-monero)
| * | wallet2: fix the logged number of detached transfersmoneromooo-monero2019-10-231-0/+1
| |/
* | simplewallet: add public_nodes commandmoneromooo-monero2019-10-251-0/+21
| | | | | | | | Lists nodes exposing their RPC port for public use
* | daemon, wallet: new pay for RPC use systemmoneromooo-monero2019-10-251-245/+420
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Daemons intended for public use can be set up to require payment in the form of hashes in exchange for RPC service. This enables public daemons to receive payment for their work over a large number of calls. This system behaves similarly to a pool, so payment takes the form of valid blocks every so often, yielding a large one off payment, rather than constant micropayments. This system can also be used by third parties as a "paywall" layer, where users of a service can pay for use by mining Monero to the service provider's address. An example of this for web site access is Primo, a Monero mining based website "paywall": https://github.com/selene-kovri/primo This has some advantages: - incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own - incentive to run your own node instead of using a third party's, thereby promoting decentralization - decentralized: payment is done between a client and server, with no third party needed - private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance - no payment occurs on the blockchain, so there is no extra transactional load - one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy) - no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do - Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue - no large credit balance maintained on servers, so they have no incentive to exit scam - you can use any/many node(s), since there's little cost in switching servers - market based prices: competition between servers to lower costs - incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others - increases network security - helps counteract mining pools' share of the network hash rate - zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner And some disadvantages: - low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine) - payment is "random", so a server might go a long time without a block before getting one - a public node's overall expected payment may be small Public nodes are expected to compete to find a suitable level for cost of service. The daemon can be set up this way to require payment for RPC services: monerod --rpc-payment-address 4xxxxxx \ --rpc-payment-credits 250 --rpc-payment-difficulty 1000 These values are an example only. The --rpc-payment-difficulty switch selects how hard each "share" should be, similar to a mining pool. The higher the difficulty, the fewer shares a client will find. The --rpc-payment-credits switch selects how many credits are awarded for each share a client finds. Considering both options, clients will be awarded credits/difficulty credits for every hash they calculate. For example, in the command line above, 0.25 credits per hash. A client mining at 100 H/s will therefore get an average of 25 credits per second. For reference, in the current implementation, a credit is enough to sync 20 blocks, so a 100 H/s client that's just starting to use Monero and uses this daemon will be able to sync 500 blocks per second. The wallet can be set to automatically mine if connected to a daemon which requires payment for RPC usage. It will try to keep a balance of 50000 credits, stopping mining when it's at this level, and starting again as credits are spent. With the example above, a new client will mine this much credits in about half an hour, and this target is enough to sync 500000 blocks (currently about a third of the monero blockchain). There are three new settings in the wallet: - credits-target: this is the amount of credits a wallet will try to reach before stopping mining. The default of 0 means 50000 credits. - auto-mine-for-rpc-payment-threshold: this controls the minimum credit rate which the wallet considers worth mining for. If the daemon credits less than this ratio, the wallet will consider mining to be not worth it. In the example above, the rate is 0.25 - persistent-rpc-client-id: if set, this allows the wallet to reuse a client id across runs. This means a public node can tell a wallet that's connecting is the same as one that connected previously, but allows a wallet to keep their credit balance from one run to the other. Since the wallet only mines to keep a small credit balance, this is not normally worth doing. However, someone may want to mine on a fast server, and use that credit balance on a low power device such as a phone. If left unset, a new client ID is generated at each wallet start, for privacy reasons. To mine and use a credit balance on two different devices, you can use the --rpc-client-secret-key switch. A wallet's client secret key can be found using the new rpc_payments command in the wallet. Note: anyone knowing your RPC client secret key is able to use your credit balance. The wallet has a few new commands too: - start_mining_for_rpc: start mining to acquire more credits, regardless of the auto mining settings - stop_mining_for_rpc: stop mining to acquire more credits - rpc_payments: display information about current credits with the currently selected daemon The node has an extra command: - rpc_payments: display information about clients and their balances The node will forget about any balance for clients which have been inactive for 6 months. Balances carry over on node restart.
* Merge pull request #5959luigi11112019-10-161-5/+5
|\ | | | | | | 4d22317 wallet2: don't delete file that may not exist (selsta)
| * wallet2: don't delete file that may not existselsta2019-10-041-5/+5
| |
* | Merge pull request #5952luigi11112019-10-161-1/+35
|\ \ | | | | | | | | | 93d5cf2 wallet2: add ignore-outputs-{above/below} option (stoffu)
| * | wallet2: add ignore-outputs-{above/below} optionstoffu2019-10-021-1/+35
| | | | | | | | | | | | https://github.com/aeonix/aeon/pull/131
* | | wallet: remove long payment ID sending supportmoneromooo-monero2019-10-141-7/+0
| | |
* | | wallet2: ignore received unencrypted payment IDs (but warn hard)moneromooo-monero2019-10-141-6/+18
| | |
* | | Merge pull request #5915luigi11112019-10-081-1/+1
|\ \ \ | |/ / |/| | | | | 8330e77 monerod can now sync from pruned blocks (moneromooo-monero)
| * | monerod can now sync from pruned blocksmoneromooo-monero2019-09-271-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the peer (whether pruned or not itself) supports sending pruned blocks to syncing nodes, the pruned version will be sent along with the hash of the pruned data and the block weight. The original tx hashes can be reconstructed from the pruned txes and theur prunable data hash. Those hashes and the block weights are hashes and checked against the set of precompiled hashes, ensuring the data we received is the original data. It is currently not possible to use this system when not using the set of precompiled hashes, since block weights can not otherwise be checked for validity. This is off by default for now, and is enabled by --sync-pruned-blocks
* | | Merge pull request #5893luigi11112019-09-301-0/+6
|\ \ \ | |_|/ |/| | | | | Coverity fixes [3a81639, 1bd962d, 2825f07, d099658, d46f701, cd57a10] (anonimal)
| * | wallet2: resolve CID 203918 null pointer deference (NULL_RETURNS)anonimal2019-09-061-0/+6
| | |
* | | Merge pull request #5877luigi11112019-09-241-5/+4
|\ \ \ | | | | | | | | | | | | | | | | | | | | 2cd4fd8 Changed the use of boost:value_initialized for C++ list initializer (JesusRami) 4ad191f Removed unused boost/value_init header (whyamiroot) 928f4be Make null hash constants constexpr (whyamiroot)
| * | | Removed unused boost/value_init headerLev Sizov2019-09-021-1/+0
| | | |
| * | | Changed the use of boost:value_initialized for C++ list initializerJesus Ramirez2019-09-021-4/+4
| | | |
* | | | wallet: add edit_address_book RPCmoneromooo-monero2019-09-171-0/+15
| | | |
* | | | Merge pull request #5861luigi11112019-09-141-0/+16
|\ \ \ \ | | | | | | | | | | | | | | | f0356f7 wallet2: enable ignoring fractional outputs also when sweeping (stoffu)
| * | | | wallet2: enable ignoring fractional outputs also when sweepingstoffu2019-09-101-0/+16
| | |_|/ | |/| |
* | | | Merge pull request #5866luigi11112019-09-141-2/+2
|\ \ \ \ | |/ / / |/| | | | | | | 21f6c80 rpc: move a leftover light wallet RPC out of daemon RPC (moneromooo-monero)
| * | | rpc: move a leftover light wallet RPC out of daemon RPCmoneromooo-monero2019-08-281-2/+2
| |/ /
* | | Merge pull request #5855luigi11112019-09-081-34/+58
|\ \ \ | | | | | | | | | | | | 2ec455d wallet: fix mismatch between two concepts of 'balance' (moneromooo-monero)
| * | | wallet: fix mismatch between two concepts of "balance"moneromooo-monero2019-09-051-34/+58
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One considers the blockchain, while the other considers the blockchain and some recent actions, such as a recently created transaction which spend some outputs, but isn't yet mined. Typically, the "balance" command wants the latter, to reflect the recent action, but things like proving ownership wants the former. This fixes a crash in get_reserve_proof, where a preliminary check and the main code used two concepts of "balance".
* | | | Merge pull request #5850luigi11112019-09-081-3/+1
|\ \ \ \ | | | | | | | | | | | | | | | c4da1a2 wallet2: fix unset_ring tx retrieval checks (moneromooo-monero)
| * | | | wallet2: fix unset_ring tx retrieval checksmoneromooo-monero2019-08-241-3/+1
| |/ / /