summaryrefslogtreecommitdiff
path: root/src/wallet/wallet2.cpp
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #3474Riccardo Spagni2018-03-221-5/+6
|\ | | | | | | | | eaa8bfe7 wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctly The previous expression (stoffu) 0a619f78 wallet2: enable the mitigation only after the fork height (stoffu)
| * wallet2: set from_height of GET_OUTPUT_DISTRIBUTION correctlystoffu2018-03-221-1/+1
| | | | | | | | | | | | | | | | The previous expression req_t.from_height = X ? Y >= Z : 0; forces the parameter to take the value of either 0 or 1.
| * wallet2: enable the mitigation only after the fork heightstoffu2018-03-221-4/+5
| |
* | Merge pull request #3469Riccardo Spagni2018-03-221-0/+9
|\ \ | | | | | | | | | 0098ed33 wallet2: fix for loading settings of key reuse mitigation (stoffu)
| * | wallet2: fix for loading settings of key reuse mitigationstoffu2018-03-221-0/+9
| |/
* / wallet: catch exceptions dealing with ringdb and warnmoneromooo-monero2018-03-211-19/+44
|/
* wallet: make the segregation height settablemoneromooo-monero2018-03-171-8/+58
| | | | via user setting first, then DNS TXT record, hardcoded fallback
* Merge pull request #3336Riccardo Spagni2018-03-161-4/+4
|\ | | | | | | 57c0b1ed Fix typos in various files (Dimitris Apostolou)
| * Fix typos in various filesDimitris Apostolou2018-03-151-4/+4
| |
* | wallet: more user friendly print_ringmoneromooo-monero2018-03-161-2/+38
| | | | | | | | | | It can now take a txid (to display rings for all its inputs), and will print rings in a format that set_ring understands
* | ringdb: use the genesis block as a db namemoneromooo-monero2018-03-161-1/+3
| | | | | | | | | | | | | | This will avoid careless forkers polluting the shared database even if they make their own chain. They'll then automatically start using another subdb, and any key-reusing fork of those forks will reuse their subdbs.
* | wallet: add a set_ring commandmoneromooo-monero2018-03-161-0/+11
| | | | | | | | | | This is so one can set rings for spent key images in case the attackers don't merge the ring matching patch set.
* | wallet: make ringdb an object with database statemoneromooo-monero2018-03-161-24/+48
| |
* | wallet: add an output blackball list to avoid using those in ringsmoneromooo-monero2018-03-161-2/+29
| |
* | wallet: key reuse mitigation optionsmoneromooo-monero2018-03-161-15/+166
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If a pre-fork output is spent on both Monero and attack chain, any post-fork output can be deduced to be a fake output, thereby decreasing the effective ring size. The segregate-per-fork-outputs option, on by default, allows selecting only pre-fork outputs in this case, so that the same ring can be used when spending it on the other side, which does not decrease the effective ring size. This is intended to be SET when intending to spend Monero on the attack fork, and to be UNSET if not intending to spend Monero on the attack fork (since it leaks the fact that the output being spent is pre-fork). If the user is not certain yet whether they will spend pre-fork outputs on a key reusing fork, the key-reuse-mitigation2 option should be SET instead. If you use this option and intend to spend Monero on both forks, then spend real Monero first.
* | wallet: add shared ring databasemoneromooo-monero2018-03-161-6/+233
| | | | | | | | | | | | | | | | | | | | | | | | This maps key images to rings, so that different forks can reuse the rings by key image. This avoids revealing the real inputs like would happen if two forks spent the same outputs with different rings. This database is meant to be shared with all Monero forks which don't bother making a new chain, putting users' privacy at risk in the process. It is placed in a shared data directory by default ($HOME/.shared-ringdb on UNIX like systems). You may use --shared-ringdb-dir to override this location, and should then do so for all Monero forks for them to share the database.
* | add RPC to get a histogram of outputs of a given amountmoneromooo-monero2018-03-161-0/+65
| |
* | replace invoke_http_json("/json_rpc",...) with ↵stoffu2018-03-141-108/+78
|/ | | | invoke_http_json_rpc("/json_rpc",methodname,...) to reduce boilerplate
* Merge pull request #3398Riccardo Spagni2018-03-141-1/+1
|\ | | | | | | c577abab wallet: fix auto low priority so that it takes effect only when saved default is 0 (stoffu)
| * wallet: fix auto low priority so that it takes effect only when saved ↵stoffu2018-03-141-1/+1
| | | | | | | | default is 0
* | Merge pull request #3399Riccardo Spagni2018-03-141-1/+1
|\ \ | | | | | | | | | 1d39b265 wallet2: fix use_fork_rules() when querying version that is defined but not enabled yet (stoffu)
| * | wallet2: fix use_fork_rules() when querying version that is defined but not ↵stoffu2018-03-141-1/+1
| |/ | | | | | | enabled yet
* | Merge pull request #3386Riccardo Spagni2018-03-141-0/+5
|\ \ | | | | | | | | | 9abeff59 wallet2: handle no blocks returned in refresh to mean no new blocks (moneromooo-monero)
| * | wallet2: handle no blocks returned in refresh to mean no new blocksmoneromooo-monero2018-03-111-0/+5
| |/ | | | | | | | | This is not a possible return from the daemon, but I want this in now so all wallets handle this when the daemon starts doing so.
* | wallet2: check_tx_key() shouldn't require hardware encryptionstoffu2018-03-141-2/+2
| |
* | device: untangle cyclic depenencystoffu2018-03-141-20/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When #3303 was merged, a cyclic dependency chain was generated: libdevice <- libcncrypto <- libringct <- libdevice This was because libdevice needs access to a set of basic crypto operations implemented in libringct such as scalarmultBase(), while libringct also needs access to abstracted crypto operations implemented in libdevice such as ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct into libringct_basic and libringct, where the basic crypto ops previously in libringct are moved into libringct_basic. The cyclic dependency is now resolved thanks to this separation: libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct This eliminates the need for crypto_device.cpp and rctOps_device.cpp. Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and get_subaddress_secret_key() were previously implemented in libcryptonote_basic (cryptonote_format_utils.cpp) and were then called from hw::core::device_default, which is odd because libdevice is supposed to be independent of libcryptonote_basic. Therefore, those functions were moved to device_default.cpp.
* | device: made function prototypes consistent with pre-#3303 codebasestoffu2018-03-141-6/+2
| |
* | Merge pull request #3377Riccardo Spagni2018-03-141-1/+1
|\ \ | | | | | | | | | aa8bef0c fix error message typo in wallet2.cpp (cryptochangements34)
| * | fix error message typo in wallet2.cppcryptochangements342018-03-091-1/+1
| |/
* | Merge pull request #3369Riccardo Spagni2018-03-141-6/+6
|\ \ | | | | | | | | | 1979d53d wallet: fixes and tweaks to the save_watch_only command (moneromooo-monero)
| * | wallet: fixes and tweaks to the save_watch_only commandmoneromooo-monero2018-03-071-6/+6
| | | | | | | | | | | | | | | | | | - save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly - catch any exception (eg, I/O errors) and error out - print the new keys filename in simplewallet
* | | Merge pull request #3353Riccardo Spagni2018-03-141-43/+59
|\ \ \ | | | | | | | | | | | | 73dd883d Ledger HW Bug fixes (Cédric)
| * | | Ledger HW Bug fixesCédric2018-03-121-43/+59
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fix the way the REAL mode is handle: Let create_transactions_2 and create_transactions_from construct the vector of transactions. Then iterate on it and resign. We just need to add 'outs' list in the TX struct for that. Fix default secret keys value when DEBUG_HWDEVICE mode is off The magic value (00...00 for view key and FF..FF for spend key) was not correctly set when DEBUG_HWDEVICE was off. Both was set to 00...00. Add sub-address info in ABP map in order to correctly display destination sub-address on device Fix DEBUG_HWDEVICE mode: - Fix compilation errors. - Fix control device init in ledger device. - Add more log. Fix sub addr control Fix debug Info
* | | Merge pull request #3337Riccardo Spagni2018-03-141-3/+14
|\ \ \ | | | | | | | | | | | | | | | | 91d97dd4 fuzz_tests: set small subaddress lookahead for speed (moneromooo-monero) 5f85cc7e wallet2: guard against overflowing of subaddress indices (moneromooo-monero)
| * | | wallet2: guard against overflowing of subaddress indicesmoneromooo-monero2018-03-141-3/+14
| |/ /
* | | Merge pull request #3315Riccardo Spagni2018-03-141-24/+48
|\ \ \ | |/ / |/| | | | | 649a1b7a wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets (Leon Klingele)
| * | wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new ↵Leon Klingele2018-03-101-24/+48
| |/ | | | | | | | | | | | | | | | | | | | | wallets Previously, a file containing the unencrypted Monero address was created by default in the wallet's directory. This file might pose as a privacy risk. The creation of this file is now opt-in and can be enabled by providing --create-address-file
* / Bump min ring size from 5 to 7 from v7moneromooo-monero2018-03-071-1/+5
|/
* Merge pull request #3313Riccardo Spagni2018-03-051-0/+12
|\ | | | | | | 43026822 Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows (rbrunner7)
| * Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windowsrbrunner72018-02-251-0/+12
| |
* | Merge pull request #3277Riccardo Spagni2018-03-051-50/+65
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | 0e7ad2e2 Wallet API: generalize 'bool testnet' to 'NetworkType nettype' (stoffu) af773211 Stagenet (stoffu) cc9a0bee command_line: allow args to depend on more than one args (stoffu) 55f8d917 command_line::get_arg: remove 'required' for dependent args as they're always optional (stoffu) 450306a0 command line: allow has_arg to handle arg_descriptor<bool,false,true> #3318 (stoffu) 9f9e095a Use `genesis_tx` parameter in `generate_genesis_block`. #3261 (Jean Pierre Dudey)
| * | Stagenetstoffu2018-03-051-50/+65
| | |
* | | Merge pull request #3273Riccardo Spagni2018-03-051-13/+16
|\ \ \ | | | | | | | | | | | | f3b74e75 Fix refresh height estimation (Howard Chu)
| * | | Fix refresh height estimationHoward Chu2018-02-161-13/+16
| | | | | | | | | | | | | | | | | | | | | | | | Since commit b0426d4c refresh height for a newly created wallet connected to a sync'd daemon was off by a month. Now we only use the 1 month safety margin if we're unable to talk to a daemon.
* | | | Correct spelling mistakes.Edward Betts2018-03-051-7/+7
| |/ / |/| |
* | | Code modifications to integrate Ledger HW device into monero-wallet-cli.cslashm2018-03-041-89/+169
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
* | Merge pull request #3256Riccardo Spagni2018-02-201-2/+2
|\ \ | | | | | | | | | df5273de wallet2: fix auto_low_priority field name typo on load (moneromooo-monero)
| * | wallet2: fix auto_low_priority field name typo on loadmoneromooo-monero2018-02-131-2/+2
| | |
* | | Merge pull request #3247Riccardo Spagni2018-02-201-17/+12
|\ \ \ | | | | | | | | | | | | | | | | 89ad162a wallet2: remove unused m_subaddresses_inv (moneromooo-monero) f2c4c399 wallet2: speed up subaddress generation (by about a third) (moneromooo-monero)
| * | | wallet2: remove unused m_subaddresses_invmoneromooo-monero2018-02-161-4/+0
| | | |