summaryrefslogtreecommitdiff
path: root/src/simplewallet
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #8617tobtoht2025-02-132-4/+201
|\ | | | | | | e44e8b164 wallet: background sync with just the view key (j-berman)
| * wallet: background sync with just the view keyj-berman2024-05-242-4/+201
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - When background syncing, the wallet wipes the spend key from memory and processes all new transactions. The wallet saves all receives, spends, and "plausible" spends of receives the wallet does not know key images for. - When background sync disabled, the wallet processes all background synced txs and then clears the background sync cache. - Adding "plausible" spends to the background sync cache ensures that the wallet does not need to query the daemon to see if any received outputs were spent while background sync was enabled. This would harm privacy especially for users of 3rd party daemons. - To enable the feature in the CLI wallet, the user can set background-sync to reuse-wallet-password or custom-background-password and the wallet automatically syncs in the background when the wallet locks, then processes all background synced txs when the wallet is unlocked. - The custom-background-password option enables the user to open a distinct background wallet that only has a view key saved and can be opened/closed/synced separately from the main wallet. When the main wallet opens, it processes the background wallet's cache. - To enable the feature in the RPC wallet, there is a new `/setup_background_sync` endpoint. - HW, multsig and view-only wallets cannot background sync.
* | build: fix build with Boost 1.85 and remove instances of viewkey logging ↵jeffro2562024-09-101-3/+3
|/ | | | | | | | | | | [RELEASE] 1. Use std::is_standard_layout and std::is_trivially_copyable instead of std::is_pod for KV byte-wise serialization, which fixes compile issue for Boost UUIDs 2. Removed reimplementation of std::hash for boost::uuids::uuid 3. Removed << operator overload for crypto::secret_key 4. Removed instances in code where private view key was dumped to the log in plaintext Release version of #9450, containing C++14 modified assertions
* Enforce Tx unlock_time is Zero by Relay Rule [RELEASE]jeffro2562024-04-292-133/+14
| | | | | | | | | | | | | | | | Related to https://github.com/monero-project/research-lab/issues/78 Added a relay rule that enforces the `unlock_time` field is equal to 0 for non-coinbase transactions. UIs changed: * Removed `locked_transfer` and `locked_sweep_all` commands from `monero-wallet-cli` APIs changed: * Removed `unlock_time` parameters from `wallet2` transfer methods * Wallet RPC transfer endpoints send error codes when requested unlock time is not 0 * Removed `unlock_time` parameters from `construct_tx*` cryptonote core functions @tobtoht: undo rebase changes tx.dsts -> tx_dsts
* wallet2: adjust fee during backlog, fix set priorityselsta2024-03-081-1/+1
|
* wallet: feature: transfer amount with fee includedjeffro2562024-02-201-5/+78
| | | | | | | | | | | | | | | | | To transfer ~5 XMR to an address such that your balance drops by exactly 5 XMR, provide a `subtractfeefrom` flag to the `transfer` command. For example: transfer 76bDHojqFYiFCCYYtzTveJ8oFtmpNp3X1TgV2oKP7rHmZyFK1RvyE4r8vsJzf7SyNohMnbKT9wbcD3XUTgsZLX8LU5JBCfm 5 subtractfeefrom=all If my walet balance was exactly 30 XMR before this transaction, it will be exactly 25 XMR afterwards and the destination address will receive slightly less than 5 XMR. You can manually select which destinations fund the transaction fee and which ones do not by providing the destination index. For example: transfer 75sr8AAr... 3 74M7W4eg... 4 7AbWqDZ6... 5 subtractfeefrom=0,2 This will drop your balance by exactly 12 XMR including fees and will spread the fee cost proportionally (3:5 ratio) over destinations with addresses `75sr8AAr...` and `7AbWqDZ6...`, respectively. Disclaimer: This feature was paid for by @LocalMonero.
* wallet2, RPC: Optimize RPC calls for periodic refresh from 3 down to 1 call ↵rbrunner72023-07-091-1/+4
| | | | [release-v0.18]
* wallet2: fix rescanning tx via scan_txj-berman2023-03-131-2/+3
| | | | | | | | | | | | | | | | | - Detach & re-process txs >= lowest scan height - ensures that if a user calls scan_tx(tx1) after scanning tx2, the wallet correctly processes tx1 and tx2 - if a user provides a tx with a height higher than the wallet's last scanned height, the wallet will scan starting from that tx's height - scan_tx requires trusted daemon iff need to re-process existing txs: in addition to querying a daemon for txids, if a user provides a txid of a tx with height *lower* than any *already* scanned txs in the wallet, then the wallet will also query the daemon for all the *higher* txs as well. This is likely unexpected behavior to a caller, and so to protect a caller from revealing txid's to an untrusted daemon in an unexpected way, require the daemon be trusted.
* Merge pull request #8585luigi11112022-09-261-1/+1
|\ | | | | | | 5ffa31c wallet2: fail to establish daemon cxn == 'Disconnected' cxn status (j-berman)
| * wallet2: fail to establish daemon cxn == "Disconnected" cxn statusj-berman2022-09-211-1/+1
| |
* | add an option to force-update multisig key exchange under some circumstanceskoe2022-09-212-12/+18
|/
* Merge pull request #8545v0.18.1.1luigi11112022-09-152-17/+30
|\ | | | | | | | | | | | | 12e7c41 Merge pull request #5 from j-berman/restore-msig-encrypted-seed (Justin Berman) 848a0c0 Fix segfault restoring encrypted multisig seed (j-berman) 401f5d9 Require user ack multisig is experimental to restore (j-berman) fc8a5d6 multisig: fix #8537 seed restore (suggestions by @UkoeHB) (j-berman)
| * Fix segfault restoring encrypted multisig seedj-berman2022-09-062-17/+17
| |
| * Require user ack multisig is experimental to restorej-berman2022-09-061-0/+13
| |
* | wallet2: check wallet compatibility with daemon's hard fork versionj-berman2022-09-122-8/+11
| |
* | allow exporting outputs in chunksmoneromooo-monero2022-09-071-2/+4
|/ | | | | this will make it easier huge wallets to do so without hitting random limits (eg, max string size in node).
* Merge pull request #8391luigi11112022-07-051-0/+16
|\ | | | | | | 41b1a6b simplewallet: print usage when given no args (hinto.janaiyo)
| * simplewallet: print usage when given no argshinto.janaiyo2022-06-201-0/+16
| |
* | Improve consistency between on_money_received and on_money_received_unconfirmedLuke Parker2022-06-012-3/+7
|/ | | | | | unconfirmed solely uses a - b, and received now accepts b so it can provide more detailed logs on what occurred (printing a - b, yet with a and b).
* Merge pull request #8337luigi11112022-05-261-2/+0
|\ | | | | | | 1164874 src, epee: fix a couple compiler warnings (selsta)
| * src, epee: fix a couple compiler warningsselsta2022-05-171-2/+0
| |
* | disable multisig by defaultmoneromooo-monero2022-05-172-0/+56
|/ | | | | | | | | There are vulnerabilities in multisig protocol if the parties do not trust each other, and while there is a patch for it, it has not been throroughly reviewed yet, so it is felt safer to disable multisig by default for now. If all parties in a multisig setup trust each other, then it is safe to enable multisig.
* Merge pull request #8220luigi11112022-05-101-3/+7
|\ | | | | | | 0d6ecb1 multisig: add post-kex verification round to check that all participants have completed the multisig address (koe)
| * multisig: add post-kex verification round to check that all participants ↵koe2022-04-291-3/+7
| | | | | | | | have completed the multisig address
* | Merge pull request #8178luigi11112022-04-252-65/+5
|\ \ | | | | | | | | | 5d388eb Bump ring size to 16 for v15 & remove set default in wallet cli (j-berman)
| * | Bump ring size to 16 for v15 & remove set default in wallet clij-berman2022-04-182-65/+5
| | |
* | | Merge pull request #8245luigi11112022-04-191-1/+1
|\ \ \ | |/ / |/| | | | | 3593a98 simplewallet: fix integrated_address output string (selsta)
| * | simplewallet: fix integrated_address output stringselsta2022-04-081-1/+1
| | |
* | | CMake: Add missing headers via monero_find_all_headers macromj-xmr2022-04-061-2/+1
|/ /
* | Merge pull request #8197luigi11112022-04-063-3/+3
|\ \ | | | | | | | | | da9aa1f Copyright: Update to 2022 (mj-xmr)
| * | Copyright: Update to 2022mj-xmr2022-03-043-3/+3
| |/
* | Merge pull request #8180luigi11112022-04-061-13/+47
|\ \ | | | | | | | | | 3f88fdd simplewallet: add option for exporting tx keys (reemuru)
| * | simplewallet: add option for exporting tx keysreemuru2022-02-241-13/+47
| | | | | | | | | | | | | | | | | | | | | This commit adds an option to export transaction keys when performing export_transfers all. By passing option=with_keys a new column 'tx key' will be populated with respective keys.
* | | Merge pull request #8053luigi11112022-04-061-2/+2
|\ \ \ | | | | | | | | | | | | cf44349 account info text alignment (im)
| * | | account info text alignmentim2021-11-101-2/+2
| |/ /
* | / Make the wallet name optional when locked.Norman Moeschter2022-03-102-0/+28
| |/ |/|
* | Merge pull request #7877luigi11112022-03-022-61/+3
|\ \ | |/ |/| | | e08abaa multisig key exchange update and refactor (koe)
| * multisig key exchange update and refactorkoe2022-02-222-61/+3
| |
* | simplewallet: fix incoming_transfers index errorselsta2021-10-101-8/+6
|/
* simplewallet: don't truncate integ. address in export_transfersselsta2021-06-241-2/+2
|
* wallet2: Fix rescan_bc keep_ki optionNathan Dorfman2021-04-231-1/+1
|
* Merge pull request #7651luigi11112021-04-221-1/+6
|\ | | | | | | c8ff1d4 monero-wallet-cli: improve error message when tx amount is zero (Elliot Wirrick)
| * monero-wallet-cli: improve error message when tx amount is zeroElliot Wirrick2021-04-071-1/+6
| |
* | Merge pull request #7002luigi11112021-04-161-0/+1
|\ \ | |/ |/| | | 673c6d2 Reduce compilation time of epee/portable_storage_template_helper.h (mj-xmr)
| * Reduce compilation time of epee/portable_storage_template_helper.hmj-xmr2021-03-281-0/+1
| |
* | Merge pull request #7358luigi11112021-03-292-2/+21
|\ \ | |/ |/| | | f346e3e wallet_rpc_payments: implement multithreading (gdmojo)
| * wallet_rpc_payments: implement multithreadinggdmojo2021-02-202-2/+21
| |
* | Merge pull request #7355luigi11112021-02-181-1/+1
|\ \ | | | | | | | | | | | | bd12984 Remove copies from foreach loops (thanks to Clang) (Lee Clagett) 1572df9 Removing unused namespace alias (Lee Clagett)
| * | Remove copies from foreach loops (thanks to Clang)Lee Clagett2021-01-281-1/+1
| |/
* | Merge pull request #7346luigi11112021-02-181-8/+1
|\ \ | | | | | | | | | 85db173 Remove unused variables in monero codebase (Kevin Barbour)