aboutsummaryrefslogtreecommitdiff
path: root/src/simplewallet/simplewallet.cpp
Commit message (Collapse)AuthorAgeFilesLines
...
* | | Merge pull request #3410Riccardo Spagni2018-03-151-7/+19
|\ \ \ | | | | | | | | | | | | c5024c5b simplewallet: add a warning when getting a daemon error in transfer (moneromooo-monero)
| * | | simplewallet: add a warning when getting a daemon error in transfermoneromooo-monero2018-03-151-7/+19
| | | | | | | | | | | | | | | | | | | | A malicious daemon (or MITM) could attempt to add spurious errors so the wallet tries again, sending another set of fake outs.
* | | | wallet2+cli+rpc: eliminate redundant m_http_client from cli/rpc and delegate ↵stoffu2018-03-151-6/+5
| |/ / |/| | | | | | | | calls to wallet2
* | | Merge pull request #3384Riccardo Spagni2018-03-141-2/+1
|\ \ \ | | | | | | | | | | | | b63ea060 simplewallet: do not call a RPC when displaying the prompt (moneromooo-monero)
| * | | simplewallet: do not call a RPC when displaying the promptmoneromooo-monero2018-03-111-2/+1
| | |/ | |/| | | | | | | Speeds up refresh when you have a lot of in/out transactions
* | | device: untangle cyclic depenencystoffu2018-03-141-1/+0
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When #3303 was merged, a cyclic dependency chain was generated: libdevice <- libcncrypto <- libringct <- libdevice This was because libdevice needs access to a set of basic crypto operations implemented in libringct such as scalarmultBase(), while libringct also needs access to abstracted crypto operations implemented in libdevice such as ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct into libringct_basic and libringct, where the basic crypto ops previously in libringct are moved into libringct_basic. The cyclic dependency is now resolved thanks to this separation: libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct This eliminates the need for crypto_device.cpp and rctOps_device.cpp. Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and get_subaddress_secret_key() were previously implemented in libcryptonote_basic (cryptonote_format_utils.cpp) and were then called from hw::core::device_default, which is odd because libdevice is supposed to be independent of libcryptonote_basic. Therefore, those functions were moved to device_default.cpp.
* | Merge pull request #3369Riccardo Spagni2018-03-141-1/+11
|\ \ | | | | | | | | | 1979d53d wallet: fixes and tweaks to the save_watch_only command (moneromooo-monero)
| * | wallet: fixes and tweaks to the save_watch_only commandmoneromooo-monero2018-03-071-1/+11
| | | | | | | | | | | | | | | | | | - save the new keys file as FOO-watchonly.keys, not FOO.keys-watchonly - catch any exception (eg, I/O errors) and error out - print the new keys filename in simplewallet
* | | Merge pull request #3315Riccardo Spagni2018-03-141-4/+12
|\ \ \ | |_|/ |/| | | | | 649a1b7a wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new wallets (Leon Klingele)
| * | wallet2 / simplewallet: Must opt-in to create '.address.txt' files for new ↵Leon Klingele2018-03-101-4/+12
| |/ | | | | | | | | | | | | | | | | | | | | wallets Previously, a file containing the unencrypted Monero address was created by default in the wallet's directory. This file might pose as a privacy risk. The creation of this file is now opt-in and can be enabled by providing --create-address-file
* / Bump min ring size from 5 to 7 from v7moneromooo-monero2018-03-071-2/+2
|/
* Merge pull request #3298Riccardo Spagni2018-03-051-9/+3
|\ | | | | | | f2bb8085 Fix #3297 use the password_prompter helper (Howard Chu)
| * Fix #3297 use the password_prompter helperHoward Chu2018-02-201-9/+3
| |
* | Merge pull request #3312Riccardo Spagni2018-03-051-1/+1
|\ \ | | | | | | | | | 399120dd simplewallet: set seed language when restoring from english-old seed (stoffu)
| * | simplewallet: set seed language when restoring from english-old seedstoffu2018-02-251-1/+1
| | |
* | | Merge pull request #3313Riccardo Spagni2018-03-051-0/+36
|\ \ \ | | | | | | | | | | | | 43026822 Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windows (rbrunner7)
| * | | Wallet2 + CLI wallet: UTF-8 support for filenames and paths under Windowsrbrunner72018-02-251-0/+36
| |/ /
* | | Merge pull request #3332Riccardo Spagni2018-03-051-3/+14
|\ \ \ | | | | | | | | | | | | 6b40ea93 simplewallet: fix print_ring_members printing wrong heights (moneromooo-monero)
| * | | simplewallet: fix print_ring_members printing wrong heightsmoneromooo-monero2018-03-021-3/+14
| |/ / | | | | | | | | | And also use uint64_t instead of int for heights where appropriate
* | | Merge pull request #3277Riccardo Spagni2018-03-051-39/+50
|\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 0e7ad2e2 Wallet API: generalize 'bool testnet' to 'NetworkType nettype' (stoffu) af773211 Stagenet (stoffu) cc9a0bee command_line: allow args to depend on more than one args (stoffu) 55f8d917 command_line::get_arg: remove 'required' for dependent args as they're always optional (stoffu) 450306a0 command line: allow has_arg to handle arg_descriptor<bool,false,true> #3318 (stoffu) 9f9e095a Use `genesis_tx` parameter in `generate_genesis_block`. #3261 (Jean Pierre Dudey)
| * | | Stagenetstoffu2018-03-051-39/+50
| | | |
* | | | Correct spelling mistakes.Edward Betts2018-03-051-1/+1
|/ / /
* / / Code modifications to integrate Ledger HW device into monero-wallet-cli.cslashm2018-03-041-5/+161
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.
* | Merge pull request #3294Riccardo Spagni2018-02-201-1/+1
|\ \ | | | | | | | | | fd57e13a simplewallet: typo in generate-from-multisig-keys (stoffu)
| * | simplewallet: typo in generate-from-multisig-keysstoffu2018-02-191-1/+1
| |/
* | Merge pull request #3263Riccardo Spagni2018-02-201-1/+1
|\ \ | | | | | | | | | d4e728c9 simplewallet: reword donate command message for clarity (Serhack)
| * | simplewallet: reword donate command message for claritySerhack2018-02-141-1/+1
| | |
* | | Merge pull request #3257Riccardo Spagni2018-02-201-8/+0
|\ \ \ | |_|/ |/| | | | | da25757b simplewallet: do nothing in on_skip_transaction (wallet2 already logs warnings) (stoffu)
| * | simplewallet: do nothing in on_skip_transaction (wallet2 already logs warnings)stoffu2018-02-151-8/+0
| |/
* | Merge pull request #3249Riccardo Spagni2018-02-171-0/+7
|\ \ | | | | | | | | | a4b50a6f handle ^D and ^C while password prompting (Jethro Grassie)
| * | handle ^D and ^C while password promptingJethro Grassie2018-02-101-0/+7
| |/
* | Merge pull request #3226Riccardo Spagni2018-02-161-1/+5
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | e4646379 keccak: fix mdlen bounds sanity checking (moneromooo-monero) 2e3e90ac pass large parameters by const ref, not value (moneromooo-monero) 61defd89 blockchain: sanity check number of precomputed hash of hash blocks (moneromooo-monero) 9af6b2d1 ringct: fix infinite loop in unused h2b function (moneromooo-monero) 8cea8d0c simplewallet: double check a new multisig wallet is multisig (moneromooo-monero) 9b98a6ac threadpool: catch exceptions in dtor, to avoid terminate (moneromooo-monero) 24803ed9 blockchain_export: fix buffer overflow in exporter (moneromooo-monero) f3f7da62 perf_timer: rewrite to make it clear there is no division by zero (moneromooo-monero) c6ea3df0 performance_tests: remove add_arg call stray extra param (moneromooo-monero) fa6b4566 fuzz_tests: fix an uninitialized var in setup (moneromooo-monero) 03887f11 keccak: fix sanity check bounds test (moneromooo-monero) ad11db91 blockchain_db: initialize m_open in base class ctor (moneromooo-monero) bece67f9 miner: restore std::cout precision after modification (moneromooo-monero) 1aabd14c db_lmdb: check hard fork info drop succeeded (moneromooo-monero)
| * | simplewallet: double check a new multisig wallet is multisigmoneromooo-monero2018-02-021-1/+5
| |/ | | | | | | Coverity 182493
* | Merge pull request #3214Riccardo Spagni2018-02-161-0/+1
|\ \ | | | | | | | | | 214d251c wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrown (stoffu)
| * | wallet: suggest the use of sweep_unmixable when not_enough_outs_to_mix is thrownstoffu2018-02-081-0/+1
| |/
* | Merge pull request #3175Riccardo Spagni2018-02-161-1/+1
|\ \ | | | | | | | | | 3be98036 wallet-cli: Do not ask for scan_from_height if it explicitly is set to zero. (Maximilian Lupke)
| * | wallet-cli: Do not ask for scan_from_height if it explicitly is set to zero.Maximilian Lupke2018-01-241-1/+1
| | | | | | | | | | | | Fixes #3080
* | | Merge pull request #3094Riccardo Spagni2018-02-161-10/+10
|\ \ \ | |_|/ |/| | | | | a85dbb3f Fixed typos and wording tweaks (Maxithi)
| * | Fixed typos and wording tweaksMaxithi2018-01-291-10/+10
| | |
* | | wallet: automatically use low priority if safe (no backlog & recent blocks ↵stoffu2018-01-281-12/+27
| | | | | | | | | | | | not full)
* | | simplewallet: bug fix for backlog estimatestoffu2018-01-281-4/+1
| | |
* | | Merge pull request #3141Riccardo Spagni2018-01-271-2/+2
|\ \ \ | | | | | | | | | | | | | | | | | | | | 3160a930 wallet2: remove {set|get}_default_decimal_point and use the same funcs under cryptonote:: instead (stoffu) 7d1088d3 wallet2: make scan_output const and omit keys arg (stoffu) bc1ee2c2 wallet2: make member functions const when possible (stoffu)
| * | | wallet2: remove {set|get}_default_decimal_point and use the same funcs under ↵stoffu2018-01-261-2/+2
| | | | | | | | | | | | | | | | cryptonote:: instead
* | | | Merge pull request #3118Riccardo Spagni2018-01-271-0/+38
|\ \ \ \ | | | | | | | | | | | | | | | ca336c62 simplewallet: check file overwrite when exporting stuff (stoffu)
| * | | | simplewallet: check file overwrite when exporting stuffstoffu2018-01-261-0/+38
| |/ / /
* | | | Merge pull request #3102Riccardo Spagni2018-01-271-3/+3
|\ \ \ \ | | | | | | | | | | | | | | | 3050a4f0 simplewallet: fix typo get_tx_proof_out to get_tx_proof (stoffu)
| * | | | simplewallet: fix typo get_tx_proof_out to get_tx_proofstoffu2018-01-261-3/+3
| |/ / /
* / / / Update 2018 copyrightxmr-eric2018-01-261-1/+1
|/ / /
* | | Merge pull request #3130Riccardo Spagni2018-01-251-2/+14
|\ \ \ | | | | | | | | | | | | | | | | 5ae617d5 simplewallet: single out 0 amount destinations as dummy ones (moneromooo-monero) c1d19f3c wallet2: fix sweep_all sending an atomic unit (moneromooo-monero)
| * | | simplewallet: single out 0 amount destinations as dummy onesmoneromooo-monero2018-01-161-2/+14
| | |/ | |/| | | | | | | Avoids surprising the user with "sending 0 to..."