summaryrefslogtreecommitdiff
path: root/src/simplewallet/simplewallet.cpp
Commit message (Collapse)AuthorAgeFilesLines
* simplewallet: plug a timing leakmoneromooo-monero2019-11-021-7/+26
| | | | | | | | | | As reported by Tramèr et al, timing of refresh requests can be used to see whether a password was requested (and thus at least one output received) since this will induce a delay in subsequent calls. To avoid this, we schedule calls at a given time instead of sleeping for a set time (which would make delays additive). To further avoid a scheduled call being during the time in which a password is prompted, the actual scheduled time is now randomized.
* wallet: fix another facet of "did I get some monero" information leakmoneromooo-monero2019-11-011-2/+10
| | | | | | | We get new pool txes before processing any tx, pool or not. This ensures that if we're asked for a password, this does not cause a measurable delay in the txpool query after the last block query.
* Merge pull request #6019luigi11112019-10-251-1/+1
|\ | | | | | | d60c1b6 changed 'batttery' to 'battery' (jakehemmerle)
| * changed 'batttery' to 'battery'Jake Hemmerle2019-10-241-1/+1
| |
* | simplewallet: add public_nodes commandmoneromooo-monero2019-10-251-19/+65
| | | | | | | | Lists nodes exposing their RPC port for public use
* | daemon, wallet: new pay for RPC use systemmoneromooo-monero2019-10-251-7/+375
|/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Daemons intended for public use can be set up to require payment in the form of hashes in exchange for RPC service. This enables public daemons to receive payment for their work over a large number of calls. This system behaves similarly to a pool, so payment takes the form of valid blocks every so often, yielding a large one off payment, rather than constant micropayments. This system can also be used by third parties as a "paywall" layer, where users of a service can pay for use by mining Monero to the service provider's address. An example of this for web site access is Primo, a Monero mining based website "paywall": https://github.com/selene-kovri/primo This has some advantages: - incentive to run a node providing RPC services, thereby promoting the availability of third party nodes for those who can't run their own - incentive to run your own node instead of using a third party's, thereby promoting decentralization - decentralized: payment is done between a client and server, with no third party needed - private: since the system is "pay as you go", you don't need to identify yourself to claim a long lived balance - no payment occurs on the blockchain, so there is no extra transactional load - one may mine with a beefy server, and use those credits from a phone, by reusing the client ID (at the cost of some privacy) - no barrier to entry: anyone may run a RPC node, and your expected revenue depends on how much work you do - Sybil resistant: if you run 1000 idle RPC nodes, you don't magically get more revenue - no large credit balance maintained on servers, so they have no incentive to exit scam - you can use any/many node(s), since there's little cost in switching servers - market based prices: competition between servers to lower costs - incentive for a distributed third party node system: if some public nodes are overused/slow, traffic can move to others - increases network security - helps counteract mining pools' share of the network hash rate - zero incentive for a payer to "double spend" since a reorg does not give any money back to the miner And some disadvantages: - low power clients will have difficulty mining (but one can optionally mine in advance and/or with a faster machine) - payment is "random", so a server might go a long time without a block before getting one - a public node's overall expected payment may be small Public nodes are expected to compete to find a suitable level for cost of service. The daemon can be set up this way to require payment for RPC services: monerod --rpc-payment-address 4xxxxxx \ --rpc-payment-credits 250 --rpc-payment-difficulty 1000 These values are an example only. The --rpc-payment-difficulty switch selects how hard each "share" should be, similar to a mining pool. The higher the difficulty, the fewer shares a client will find. The --rpc-payment-credits switch selects how many credits are awarded for each share a client finds. Considering both options, clients will be awarded credits/difficulty credits for every hash they calculate. For example, in the command line above, 0.25 credits per hash. A client mining at 100 H/s will therefore get an average of 25 credits per second. For reference, in the current implementation, a credit is enough to sync 20 blocks, so a 100 H/s client that's just starting to use Monero and uses this daemon will be able to sync 500 blocks per second. The wallet can be set to automatically mine if connected to a daemon which requires payment for RPC usage. It will try to keep a balance of 50000 credits, stopping mining when it's at this level, and starting again as credits are spent. With the example above, a new client will mine this much credits in about half an hour, and this target is enough to sync 500000 blocks (currently about a third of the monero blockchain). There are three new settings in the wallet: - credits-target: this is the amount of credits a wallet will try to reach before stopping mining. The default of 0 means 50000 credits. - auto-mine-for-rpc-payment-threshold: this controls the minimum credit rate which the wallet considers worth mining for. If the daemon credits less than this ratio, the wallet will consider mining to be not worth it. In the example above, the rate is 0.25 - persistent-rpc-client-id: if set, this allows the wallet to reuse a client id across runs. This means a public node can tell a wallet that's connecting is the same as one that connected previously, but allows a wallet to keep their credit balance from one run to the other. Since the wallet only mines to keep a small credit balance, this is not normally worth doing. However, someone may want to mine on a fast server, and use that credit balance on a low power device such as a phone. If left unset, a new client ID is generated at each wallet start, for privacy reasons. To mine and use a credit balance on two different devices, you can use the --rpc-client-secret-key switch. A wallet's client secret key can be found using the new rpc_payments command in the wallet. Note: anyone knowing your RPC client secret key is able to use your credit balance. The wallet has a few new commands too: - start_mining_for_rpc: start mining to acquire more credits, regardless of the auto mining settings - stop_mining_for_rpc: stop mining to acquire more credits - rpc_payments: display information about current credits with the currently selected daemon The node has an extra command: - rpc_payments: display information about clients and their balances The node will forget about any balance for clients which have been inactive for 6 months. Balances carry over on node restart.
* Merge pull request #5983luigi11112019-10-221-1/+3
|\ | | | | | | 32d6376 simplewallet: add --restore-from-seed alias (moneromooo-monero)
| * simplewallet: add --restore-from-seed aliasmoneromooo-monero2019-10-111-1/+3
| | | | | | | | It may be more intuitive for some people
* | Merge pull request #5982luigi11112019-10-221-0/+3
|\ \ | | | | | | | | | bba5bae implewallet: don't trigger idle lock right after a foreground refresh (moneromooo-monero)
| * | simplewallet: don't trigger idle lock right after a foreground refreshmoneromooo-monero2019-10-111-0/+3
| |/
* | Merge pull request #5977luigi11112019-10-221-1/+1
|\ \ | | | | | | | | | e85c838 simplewallet: do not print warning for locked coinbase txes (moneromooo-monero)
| * | simplewallet: do not print warning for locked coinbase txesmoneromooo-monero2019-10-101-1/+1
| |/ | | | | | | since they're all locked for a fixed amount
* | Merge pull request #5952luigi11112019-10-161-0/+45
|\ \ | | | | | | | | | 93d5cf2 wallet2: add ignore-outputs-{above/below} option (stoffu)
| * | wallet2: add ignore-outputs-{above/below} optionstoffu2019-10-021-0/+45
| |/ | | | | | | https://github.com/aeonix/aeon/pull/131
* | Merge pull request #5946luigi11112019-10-161-3/+3
|\ \ | | | | | | | | | 16498dc simplewallet.cpp - clean up welcome message (SomaticFanatic)
| * | simplewallet.cpp - clean up welcome messageSomaticFanatic2019-10-011-3/+3
| |/ | | | | Fixed a typo ("and -are- not visible to the world by default"), removed a few redundant commas, and capitalized words inside the URL.
* | wallet: remove long payment ID sending supportmoneromooo-monero2019-10-141-79/+5
| |
* | simplewallet: reinstate short payment id nag, only if non defaultmoneromooo-monero2019-10-141-1/+8
|/
* Merge pull request #5906luigi11112019-09-301-1/+0
|\ | | | | | | bd9c12e simplewallet: remove erroneously added line under subaddress-lookahead (stoffu)
| * simplewallet: remove erroneously added line under subaddress-lookaheadstoffu2019-09-111-1/+0
| |
* | Merge pull request #5874luigi11112019-09-141-15/+13
|\ \ | | | | | | | | | f380f69 simplewallet: warn if invalid default ring size is set and actually ignore the setting (stoffu)
| * | simplewallet: warn if invalid default ring size is set and actually ignore ↵stoffu2019-08-291-15/+13
| | | | | | | | | | | | the setting
* | | Merge pull request #5865luigi11112019-09-141-5/+5
|\ \ \ | |_|/ |/| | | | | | | | 11f13da blockchain: fix logging bad number of blocks if first one fails (moneromooo-monero) 19bfe7e simplewallet: fix warnings about useless std::move (moneromooo-monero)
| * | simplewallet: fix warnings about useless std::movemoneromooo-monero2019-08-281-5/+5
| |/
* | Merge pull request #5855luigi11112019-09-081-9/+9
|\ \ | | | | | | | | | 2ec455d wallet: fix mismatch between two concepts of 'balance' (moneromooo-monero)
| * | wallet: fix mismatch between two concepts of "balance"moneromooo-monero2019-09-051-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | One considers the blockchain, while the other considers the blockchain and some recent actions, such as a recently created transaction which spend some outputs, but isn't yet mined. Typically, the "balance" command wants the latter, to reflect the recent action, but things like proving ownership wants the former. This fixes a crash in get_reserve_proof, where a preliminary check and the main code used two concepts of "balance".
* | | Merge pull request #5842luigi11112019-09-081-1/+16
|\ \ \ | | | | | | | | | | | | 87d2f06 simplewallet: moan harder about untrusted nodes (moneromooo-monero)
| * | | simplewallet: moan harder about untrusted nodesmoneromooo-monero2019-08-241-1/+16
| | | |
* | | | simplewallet: lock console on inactivitymoneromooo-monero2019-08-281-130/+290
| |_|/ |/| |
* | | Wallet: Option to export data to ASCIITadeas Moravec2019-08-221-16/+49
| |/ |/| | | | | | | | | | | | | | | | | | | New CLI wallet variable: export-format with options "binary" (the default), or "ascii". "Binary" behaves as before, "ascii" forces the wallet to convert data to ASCII using base64. Reading files from the disk tries to auto detect what format has been used (using a magic string added when exporting the data). Implements https://github.com/monero-project/monero/issues/2859
* | Merge pull request #5808luigi11112019-08-211-4/+14
|\ \ | | | | | | | | | | | | 5a91b83 simplewallet: add a few missing settings help text (stoffu) ae7bf37 simplewallet: fix arg indexing bug in set_device_name (stoffu)
| * | simplewallet: fix arg indexing bug in set_device_namestoffu2019-08-131-1/+1
| | |
| * | simplewallet: add a few missing settings help textstoffu2019-08-131-4/+14
| | |
* | | Merge pull request #5750luigi11112019-08-211-3/+3
|\ \ \ | | | | | | | | | | | | 884df82 wallet: provide original address for outgoing transfers (xiphon)
| * | | wallet: provide original address for outgoing transfersxiphon2019-07-101-3/+3
| | | |
* | | | Merge pull request #5743luigi11112019-08-211-0/+9
|\ \ \ \ | | | | | | | | | | | | | | | 65f29a8 simplewallet: add restore_height command (tobtoht)
| * | | | simplewallet: add restore_height commandthotbot2019-07-081-0/+9
| |/ / /
* | | | Merge pull request #5742luigi11112019-08-211-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | 0d916a6 Fix incorrectly named binding for MMS send_signer_config command (tobtoht)
| * | | | Fix incorrectly named binding for MMS send_signer_config commandtobtoht2019-07-081-1/+1
| |/ / / | | | | | | | | send_message_config isn't used anywhere else in the code, and it is clear from the help command that it should be named send_signer_config.
* | | | Merge pull request #5740luigi11112019-08-211-1/+1
|\ \ \ \ | | | | | | | | | | | | | | | 256d286 Minor formatting fix in help set command (tobtoht)
| * | | | Minor formatting fix in help set commandtobtoht2019-07-061-1/+1
| |/ / /
* | | | Merge pull request #5722luigi11112019-08-211-10/+29
|\ \ \ \ | |_|_|/ |/| | | | | | | 8be5fea simplewallet: optional all flag to export_outputs/export_key_images (moneromooo-monero)
| * | | simplewallet: optional all flag to export_outputs/export_key_imagesmoneromooo-monero2019-07-021-10/+29
| |/ /
* | | Merge pull request #5685luigi11112019-08-171-1/+3
|\ \ \ | | | | | | | | | | | | a604241 simplewallet: don't ask about mining when running a command line (moneromooo-monero)
| * | | simplewallet: don't ask about mining when running a command linemoneromooo-monero2019-06-221-1/+3
| |/ / | | | | | | | | | This is likely to be done via a script
* | | Merge pull request #5656luigi11112019-08-151-1/+1
|\ \ \ | |_|/ |/| | | | | 8ccc30b Fix --restore-date usage (hyc)
| * | Fix --restore-date usageHoward Chu2019-06-161-1/+1
| |/ | | | | | | | | The wallet was ignoring --restore-height and --restore-date params and prompting for them again.
* | Merge pull request #5608luigi11112019-07-241-4/+12
|\ \ | | | | | | | | | c820e18 simplewallet: print errors on exceptions creating wallets (moneromooo-monero)
| * | simplewallet: print errors on exceptions creating walletsmoneromooo-monero2019-06-061-4/+12
| |/ | | | | | | Exceptions would otherwise terminate the process silently
* | Merge pull request #5594luigi11112019-07-241-6/+49
|\ \ | | | | | | | | | f074b6b device: show address on device display (ph4r05)