| Commit message (Collapse) | Author | Age | Files | Lines |
| | |
|
| | |
|
| |\
| |
| |
| | |
1e07110 Nicer looking exit when blockchain.bin is found (moneromooo-monero)
|
| | |
| |
| |
| |
| | |
Do not print the exception message, and write the important bit
in red, since people will only read the last line otherwise.
|
| |/
|
|
|
|
| |
Fixes intermittent test failures when the pool contains
unexpected transactions that were brought in from the
live pool.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
This ensures this will be done without fail, as the error prone
matching of every return with a call to KILL_IOSERVICE leads to
hard to debug corruption when one is missing.
|
| |
|
|
|
|
|
|
| |
- only try to stop if actually started
- print number of threads before zeroing it
This fixes the suspiciously doubled "Mining has been stopped"
message on exit.
|
| |\
| |
| |
| | |
0953355 blockchain_db: inform user about new format if blockchain.bin is found (moneromooo-monero)
|
| | | |
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | | |
b39aae7 Tweak 45800a25e9374e63caaabba05c89585c86acd668 (hyc)
4a5a5ff blockchain: always stop the ioservice before returning (moneromooo-monero)
78b65cf db_lmdb: safety close db at exit (moneromooo-monero)
45800a2 db_lmdb: fix a strdup/delete[] mistmatch (moneromooo-monero)
|
| | |/
| |
| |
| | |
Fixes a use after free
|
| |\ \
| | |
| | |
| | | |
fc34132 Remove assert from status command (hyc)
|
| | |/
| |
| |
| | |
Crashes every time...
|
| |\ \
| | |
| | |
| | |
| | | |
b0541a5 blockchain: remove obsolete containers (moneromooo-monero)
18a5211 blockchain: Fix height in call to on_blockchain_dec (moneromooo-monero)
|
| | | | |
|
| | |/
| |
| |
| | |
It was a noop anyway
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the block reward was too high, the verification failed flag
was set, but the function continued. The code which was supposed
to trap this flag and return failure failed to trap it, and,
while the block was not added to the chain, the function would
return success.
The reason for avoiding returning when the block reward problem
was detected was to be able to return any transactions to the
pool if needed. This is now mooted by moving the transaction
return code to a separate function, which is now called at all
appropriate points, making the logic much simpler, and hopefully
correct now.
We also move the hard fork version check after the prev_id check,
as block which does not go on the top of the chain might not
have the expected version there, without being invalid just for
this reason.
Last, we trap the case where a block fails to be added due to
using already spent key images, to set the verification failed
flag.
|
| | |
|
| |
|
|
|
|
| |
This fixes some double spending tests.
This may or may not be unneeded in normal (non test) circumstances,
to be determined later. Keeping these for now may be slower, but safer.
|
| |
|
|
| |
Probably paranoid and unnecessary
|
| |
|
|
|
|
|
| |
Block reward may now be less than the full amount allowed.
This was breaking the bitflipping test.
We now keep track of whether a block which was accepted by the core
has a lower than allowed block reward, and allow this in the test.
|
| |
|
|
|
| |
It was missing in the port to DB.
This is actually a noop, so should not have functional changes.
|
| |
|
|
|
| |
When rolling over more than one block, the db height will decrease,
but the split height should be constant, as per the original code.
|
| |
|
|
| |
It was present in the original code
|
| |
|
|
|
| |
This can happen when trying to find an amount that does not exist,
and fixes a core test.
|
| |
|
|
|
|
| |
The check was explicit in the original version, so it seems
safer to make it explicit here, especially as it is now done
implicitely in a different place, away from the original check.
|
| |
|
|
| |
And make it change behavior slightly when close/after first hard fork
|
| | |
|
| |
|
|
| |
The former is obsolete
|
| | |
|
| | |
|
| |
|
|
| |
Remove trailing whitespace in same files.
|
| |\
| |
| |
| | |
a74cc1b hardfork: only accept major versions we know about (moneromooo-monero)
|
| | | |
|
| |/ |
|
| |
|
|
|
|
|
|
|
|
|
| |
The core tests use the blockchain, and reset it to be able
to add test data to it. This does not play nice with the
databases, since those will save that data without an explicit
save call.
We add a fakechain flag that the tests will set, which tells
the core and blockchain code to use a separate database, as
well as skip a few things like checkpoints and fixup, which
only make sense for real data.
|
| |
|
|
|
| |
This makes it log the same height as the original code, which is
less confusing when comparing behaviors.
|
| | |
|
| | |
|
| |\
| |
| |
| | |
336b375 Register daemon command line arguments to core if they're used in core (moneromooo-monero)
|
| | |
| |
| |
| |
| |
| | |
This fixes coretests, which does not register daemon specific arguments,
but uses core, which uses those arguments. Also gets rid of an unwanted
dependency on daemon code from core.
|
| |/
|
|
|
|
|
|
|
|
|
| |
Early DB versions did not store key images for inputs if the
transaction spending them had no outputs (ie, all fee). This
is not correct, as this would allow these outputs to be double
spent. This was fixed in 533acc30eda7792c802ea8b6417917fa99b8bc2b
a few months ago, but databases having synced blocks 2021612 and
685498 with a faulty version will be missing those key images
in the spent keys database. This code checks for this, and adds
those key images if they are missing.
|
| |
|
|
|
| |
This reverts commit c6bf73131aaf804cb17f24c856f826be2761a566, reversing
changes made to 8a52cf4055d247dd4b162985c931e99683992e3c.
|
| |
|
|
|
|
|
|
| |
This allows them to be saved as a fixed (one byte) chunk whatever
the value. Using a varint will use two bytes as the high bit gets
set.
This is backward compatible with current usage (0-2 values).
|
| |\
| |
| |
| |
| |
| |
| |
| |
| | |
d887c18 hardfork: fix more major/minor issues (moneromooo-monero)
3b47ca2 hardfork: fix rescan on load (moneromooo-monero)
4cea2b1 Add IP blocking for misbehaving nodes (adapted from Boolberry) (Javier Smooth)
9c64b12 quiet down p2p logging a bit (Javier Smooth)
53c75ab blockchain: log versions as numbers, not characters (moneromooo-monero)
edade8d hardfork: fix actual/voting confusion (moneromooo-monero)
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Also add some more tests, and rename some instances of
"version" and "add" for clarity.
NOTE: the starting height values are sometimes wrong.
I suspect this is due to the hard fork reorg code being
buggy, since they're good when syncing after the fact.
However, they're not actually used by the consensus code,
so I'm ignoring this for now, but this needs debugging.
|
| | | |
|