| Commit message (Collapse) | Author | Age | Files | Lines |
| ... | |
| |\
| |
| |
| | |
17b6bd6 Fix DNS failures in offline mode preventing daemon startup (moneromooo-monero)
|
| | | |
|
| |/
|
|
|
|
| |
Thanks to duckduckgo and the internet.
This might even compile.
|
| |
|
|
|
|
|
|
| |
When receiving an answer packet, the command code was passed
to the callback instead of the error code. This was hiding
the "command not found" failure from the peer, and in turn
causing the code to attempt to deserialize a non existent
reply string.
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
This is intended to catch traffic coming from a web browser,
so we avoid issues with a web page sending a transfer RPC to
the wallet. Requiring a particular user agent can act as a
simple password scheme, while we wait for 0MQ and proper
authentication to be merged.
|
| |
|
|
|
| |
Fixes the wallet being unable to connect to the daemon
when there is no NIC.
|
| |\
| |
| |
| | |
c2ad9ca allow peers without port (moneromooo-monero)
|
| | |
| |
| |
| | |
The default port is then used
|
| |/
|
|
|
|
| |
The noexcept specs were added to make GCC 6.1.1 happy (#846), but this
one was missing (because GCC did not complain about it on Linux, but
does complain on OSX).
|
| |\
| |
| |
| |
| | |
5dc09f2 wallet_rpc_server: fix some string values being returned between <> (moneromooo-monero)
f8213c0 Require 64/16 characters for payment ids (moneromooo-monero)
|
| | |
| |
| |
| |
| |
| |
| | |
The default behavior for hex string parsing would allow the
last digit to be made from a single hexadecimal character,
which is correct, but we typically do not want that as it
gets confusing and easy to not spot wrong input size.
|
| |/
|
|
|
|
|
| |
The destructors get a noexcept(true) spec by default, but these
destructors in fact throw exceptions. An alternative fix might be to not
throw (most if not all of these throws are non-essential
error-reporting/logging).
|
| |\
| |
| |
| |
| | |
1c0bffb Restrict also 'get_connections' and 'getbans' APIs. (osensei)
9f8bc49 Don't allow 'flush_txpool' and 'setbans' JSON_RPC methods when running in restricted mode. (osensei)
|
| | |
| |
| |
| | |
restricted mode.
|
| |/
|
|
| |
They're not fatal, though indicate something wrong
|
| |
|
|
|
|
|
|
|
| |
When the send queue limit is reached, it is likely to not drain
any time soon. If we call close on the connection, it will stay
alive, waiting for the queue to drain before actually closing,
and will hit that check again and again. Since the queue size
limit is the reason we're closing in the first place, we call
shutdown directly.
|
| |
|
|
|
|
|
|
|
| |
If we reach the send queue size limit, we need to release the lock,
or we will deadlock and it will never drain.
If we reach that limit, it's likely there's another problem in the
first place though, so it will probably not drain in practice either,
unless some kind of transient network timeout.
|
| |\
| |
| |
| | |
aaaf9e2 Fix get_tick_count() on Windows (Howard Chu)
|
| | |
| |
| |
| |
| | |
GetTickCount used in 52056dcfc480a126e06afaf209b1772b6aa77fb3
only has ~10-16ms resolution. Use higher rez timer to get 1ms rez.
|
| |/
|
|
|
| |
This is equivalent to line buffering, as C++ seems to lack
a setvbuf equivalent which alows line buffering.
|
| | |
|
| | |
|
| |
|
|
|
|
| |
Ain't nobody got time for link/cmake skullduggery.
This reverts commit fff238ec94ac6d45fc18c315d7bc590ddfaad63d.
|
| |\
| |
| |
| | |
2b4cab3 epee: fix potential hang on exit (moneromooo-monero)
|
| | |
| |
| |
| | |
Also close sockets on failure, just in case
|
| |/
|
|
| |
Useful for debugging users' logs
|
| | |
|
| |\
| |
| |
| |
| | |
66c2fc7 Need to link boost::chrono in more places now (Howard Chu)
b937a2c Use boost::thread instead of std::thread (Howard Chu)
|
| | |
| |
| |
| | |
and all other associated IPC
|
| |/ |
|
| |
|
|
|
| |
This avoids the need to define that variable in every program
which uses epee.
|
| |
|
|
| |
Use boost::unordered_map instead.
|
| |
|
|
| |
Use boost...
|
| |
|
|
| |
std::thread crashes on (at least) ARMv6 g++ 4.8/4.9
|
| | |
|
| |
|
|
|
|
| |
Instead of using boost::uuids::generate_random, which uses
uninitialized stuff *on purpose*, just to annoy people who
use valgrind
|
| |
|
|
| |
in case someone might want to use it
|
| |\
| |
| |
| |
| |
| | |
e514f0a even more typos (Henning Kopp)
9abc4b8 more typos fixed (Henning Kopp)
0693f3c fixed typo (Henning Kopp)
|
| | | |
|
| |/ |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
| |
Since connections from the ::connect method are now kept in
a deque to be able to cancel them on exit, this leaks both
memory and a file descriptor. Here, we clean those up after
30 seconds, to avoid this. 30 seconds is higher then the
5 second timeout used in the async code, so this should be
safe. However, this is an assumption which would break if
that async code was to start relying on longer timeouts.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
When the boost ioservice is stopped, pending work notifications
will not happen. This includes deadline timers, which would
otherwise time out the now cancelled I/O operations. When this
happens just after starting a new connect operation, this can
leave that operations in a state where it won't receive either
the completion notification nor a timeout, causing a hang.
This is fixed by keeping a list of connections corresponding
to the connect operations, and cancelling them before stopping
the boost ioservice.
Note that the list of these connections can grow unbounded, as
they're never cleaned up. Cleaning them up would involve
working out which connections do not have any pending work,
and it's not quite clear yet how to go about this.
|
| |
|
|
|
|
|
| |
In particular, make this kind of thing do what one expects
it to do:
if (x) LOG_PRINT("True"); else LOG_PRINT("No");
|
| |
|
|
|
|
|
|
|
|
| |
This prevents an exception from existing the loop without
calling the exit handler, if one is defined.
The daemon defines one, which stops the p2p layer, and will
only exit once the p2p layer is shut down. This would cause
a hang upon an exception, as the input thread would have
exited and the daemon would wait forever with no console
user input.
|
| |\
| |
| |
| | |
62e49a5 wallet: optional automatic refresh from the daemon (moneromooo-monero)
|