| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| ... | |
| |\ \
| | |
| | |
| | | |
fbd0b19 remove ARCH=x86-64 from release-static (woodser)
|
| | |/ |
|
| |\ \
| | |
| | |
| | | |
052df1b Zero initialize rctSigBase elements (Lee *!* Clagett)
|
| | |/ |
|
| |\ \
| | |
| | |
| | | |
f5b8634 Add <cstdint> to aligned test (Lee *!* Clagett)
|
| | |/ |
|
| |\ \
| | |
| | |
| | | |
98ee46f Disable/fix ports with I2P (Lee Clagett)
|
| | |/ |
|
| |\ \
| | |
| | |
| | | |
dfb990e wallet: mitigate statistical dependence for decoy selection within rings (jeffro256)
|
| | |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since we are required to check for uniqueness of decoy picks within any given
ring, and since some decoy picks may fail due to unlock time or malformed EC points,
the wallet2 decoy selection code was building up a larger than needed *unique* set of
decoys for each ring according to a certain distribution *without replacement*. After
filtering out the outputs that it couldn't use, it chooses from the remaining decoys
uniformly random *without replacement*.
The problem with this is that the picks later in the picking process are not independent
from the picks earlier in the picking process, and the later picks do not follow the
intended decoy distribution as closely as the earlier picks. To understand this
intuitively, imagine that you have 1023 marbles. You label 512 marbles with the letter A,
label 256 with the letter B, so on and so forth, finally labelling one marble with the
letter J. You put them all into a bag, shake it well, and pick 8 marbles from the bag,
but everytime you pick a marble of a certain letter, you remove all the other marbles
from that bag with the same letter. That very first pick, the odds of picking a certain
marble are exactly how you would expect: you are twice as likely to pick A as you are B,
twice as likely to pick B as you are C, etc. However, on the second pick, the odds of
getting the first pick are 0%, and the chances for everything else is higher. As you go
down the line, your picked marbles will have letters that are increasingly more unlikely
to pick if you hadn't remove the other marbles. In other words, the distribution of the
later marbles will be more "skewed" in comparison to your original distribution of marbles.
In Monero's decoy selection, this same statistical effect applies. It is not as dramatic
since the distribution is not so steep, and we have more unique values to choose from,
but the effect *is* measureable. Because of the protocol rules, we cannot have duplicate
ring members, so unless that restriction is removed, we will never have perfectly
independent picking. However, since the earlier picks are less affected by this
statistical effect, the workaround that this commit offers is to store the order that
the outputs were picked and commit to this order after fetching output information over RPC.
|
| |\ \
| | |
| | |
| | |
| | | |
9a89e2d wallet2: call on_reorg callback in handle_reorg (j-berman)
1df5630 wallet2: add on_reorg callback (Crypto City)
|
| | | | |
|
| | | | |
|
| |\ \ \
| |_|/
|/| |
| | | |
51d7a69 wallet: feature: transfer amount with fee included (jeffro256)
|
| |/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
To transfer ~5 XMR to an address such that your balance drops by exactly 5 XMR, provide a `subtractfeefrom` flag to the `transfer` command. For example:
transfer 76bDHojqFYiFCCYYtzTveJ8oFtmpNp3X1TgV2oKP7rHmZyFK1RvyE4r8vsJzf7SyNohMnbKT9wbcD3XUTgsZLX8LU5JBCfm 5 subtractfeefrom=all
If my walet balance was exactly 30 XMR before this transaction, it will be exactly 25 XMR afterwards and the destination address will receive slightly
less than 5 XMR. You can manually select which destinations fund the transaction fee and which ones do not by providing the destination index.
For example:
transfer 75sr8AAr... 3 74M7W4eg... 4 7AbWqDZ6... 5 subtractfeefrom=0,2
This will drop your balance by exactly 12 XMR including fees and will spread the fee cost proportionally (3:5 ratio) over destinations with addresses
`75sr8AAr...` and `7AbWqDZ6...`, respectively.
Disclaimer: This feature was paid for by @LocalMonero.
|
| |\ \
| | |
| | |
| | | |
47d8899 Fix missing checks for IsObject in ZMQ jsonrpc reading (Lee Clagett)
|
| | | | |
|
| |\ \ \
| | | |
| | | |
| | | | |
fe746dc Fix EAGAIN bug in ZMQ-RPC/ZMQ-PUB (Lee *!* Clagett)
|
| | | | | |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
fe47806 wallet: fix multisig key memory leak (jeffro256)
|
| | |/ / /
| | | |
| | | |
| | | |
| | | | |
Multisig keys per-transfer were being wiped, but not erased, which lead to a ginormous
quadratic bloat the more transfers and exports you performed with the wallet.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
6c38c21 heed NO_COLOR environment variable (moneromooo-monero)
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
5435202 readline_buffer: disable bracketed paste escape sequences (Jeffrey Ryan)
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
e7d51e5 JH hash compiler workarounds (SChernykh)
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- Fixed uninitialized `state->x` warning
- Fixed broken code with `-O3` or `-Ofast`
The old code is known to break GCC 10.1 and GCC 11.4
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
0f75585 multisig: better errors for small malformed kex msgs (jeffro256)
|
| | | | | |
| | | | |
| | | | |
| | | | | |
Resolves https://github.com/monero-project/monero/issues/8493
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
eae62a0 ringct: make
ctSigBase serialization follow strict aliasing rule (jeffro256)
|
| | |/ / / /
| | | | |
| | | | |
| | | | |
| | | | | |
Accessing an object of type `char` thru an lvalue of type `crypto::hash8` is undefined behavior.
https://developers.redhat.com/blog/2020/06/03/the-joys-and-perils-of-aliasing-in-c-and-c-part-2
|
| |\ \ \ \ \
| | | | | |
| | | | | |
| | | | | | |
14ae812 cryptonote_config: include cstdint (jeffro256)
|
| | |/ / / /
| | | | |
| | | | |
| | | | | |
Header was using `uint64_t` without including `<cstdint>` which caused some issues downstream for windows builds
|
| |\ \ \ \ \
| |_|/ / /
|/| | | |
| | | | | |
5b0c274 gitian: add riscv64 support (selsta)
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
09a88cc Update RandomX to 1.2.1 (tevador)
|
| | |/ / / |
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
bdebf68 wallet2: ensure transfers and sweeps use same fee calc logic (j-berman)
|
| | |/ / /
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Ensures both transfers and sweeps use a fee that's calculated
from the tx's weight. Using different logic could theoretically
enable distinguishability between the two types of txs. We don't
want that.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
e0b2123 http_client: reduce number of packets sent for small bodies (jeffro256)
|
| | |/ / / |
|
| |\ \ \ \
| |/ / /
|/| | |
| | | | |
0c04018 depends: openssl: update to 3.0.11 (tobtoht)
|
| | |/ / |
|
| |\ \ \
| | | |
| | | |
| | | |
| | | | |
69de381 add a test for the long term weight cache (Boog900)
810f6a6 Fix: long term block weight cache The long term block weight cache was doing a wrong calculation when adding a new block to the cache. (Boog900)
|
| | | | | |
|
| | | | |
| | | |
| | | |
| | | |
| | | | |
The long term block weight cache was doing a wrong calculation when
adding a new block to the cache.
|
| |\ \ \ \
| | | | |
| | | | |
| | | | | |
fbcd8da build: prepare v0.18.3.1 (selsta)
|
| | |/ / / |
|
| |\ \ \ \
| |/ / /
|/| | |
| | | | |
03d51b7 wallet2: fix refresh function parameters (selsta)
|
| | | |/
| |/|
| | |
| | | |
max_blocks is last on master branch
|
