summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #9244v0.18.3.3luigi11112024-03-121-1/+1
|\ | | | | | | 31a7f12 ringct: fix trunc_amount field name change (jeffro256)
| * ringct: fix trunc_amount field name changejeffro2562024-03-111-1/+1
| | | | | | | | Caused in commit 05231400cebfeedbbc0a5386f38a033bba6314b3, PR #9035.
* | Merge pull request #9239luigi11112024-03-117-9/+10
|\ \ | | | | | | | | | 97e3ce5 build: prepare v0.18.3.3 (selsta)
| * | build: prepare v0.18.3.3selsta2024-03-117-9/+10
| |/
* | Merge pull request #9238luigi11112024-03-111-26/+16
|\ \ | | | | | | | | | c7cf489 Revert 'http_client: reduce number of packets sent for small bodies' (jeffro256)
| * | Revert "http_client: reduce number of packets sent for small bodies"jeffro2562024-03-101-26/+16
| |/ | | | | | | This reverts commit e0b2123c324ae80177fd7c6b0516a9f8840803d9.
* | Merge pull request #9229luigi11112024-03-111-0/+3
|\ \ | |/ |/| | | 1a931ec depends: add riscv64 linux build tag (selsta)
| * depends: add riscv64 linux build tagselsta2024-03-091-0/+3
|/
* Merge pull request #9226v0.18.3.2luigi11112024-03-082-7/+19
|\ | | | | | | b5b72ae Fixed mempool pruning (SChernykh)
| * Fixed mempool pruningSChernykh2024-03-082-7/+19
|/ | | | | - Fixed undefined behavior after a call to `remove_tx_from_transient_lists` (it used an invalid iterator) - Fixed `txCompare` (it wasn't strictly weak ordered)
* Merge pull request #9223luigi11112024-03-081-1/+1
|\ | | | | | | 36ee12b get_block_template_backlog: better sorting logic (SChernykh)
| * get_block_template_backlog: better sorting logicSChernykh2024-03-081-1/+1
| | | | | | | | std::sort is unstable, so it can return random sets of transactions when mempool has many transactions with the same fee/byte. It can result in p2pool mining empty blocks sometimes because it doesn't pick up "new" transactions immediately.
* | Merge pull request #9224luigi11112024-03-081-0/+1
|\ \ | | | | | | | | | eeb7c7c tx_memory_pool: make double spends a no-drop offense (jeffro256)
| * | tx_memory_pool: make double spends a no-drop offensejeffro2562024-03-081-0/+1
| |/ | | | | | | | | Nodes who see different txs in a double spend attack will drop each other, splitting the network. Issue found by @boog900.
* | Merge pull request #9220luigi11112024-03-082-3/+3
|\ \ | |/ |/| | | 32b3a56 wallet2: adjust fee during backlog, fix set priority (selsta)
| * wallet2: adjust fee during backlog, fix set priorityselsta2024-03-082-3/+3
| |
* | Merge pull request #9217luigi11112024-03-071-1/+0
|\ \ | |/ |/| | | 7807f56 unit_tests: fix strtoul unit test (jeffro256)
| * unit_tests: fix strtoul unit testjeffro2562024-03-071-1/+0
|/
* Merge pull request #9158luigi11112024-02-249-152/+87
|\ | | | | | | 33e3f72 serialization: fix infinite loops and clean up dispatching (jeffro256)
| * serialization: fix infinite loops and clean up dispatchingjeffro2562024-02-089-152/+87
| | | | | | | | Resolves #8687
* | Merge pull request #9136luigi11112024-02-247-9/+10
|\ \ | | | | | | | | | f2360a7 build: prepare v0.18.3.2 (selsta)
| * | build: prepare v0.18.3.2selsta2024-02-207-9/+10
| |/
* | Merge pull request #9190luigi11112024-02-241-2/+2
|\ \ | | | | | | | | | c97c2ec docs: omit i2p port number from ANONYMITY_NETWORKS (selsta)
| * | docs: omit i2p port number from ANONYMITY_NETWORKSselsta2024-02-211-2/+2
| |/
* | Merge pull request #9188luigi11112024-02-241-1/+2
|\ \ | | | | | | | | | 0cc8f7a cryptonote_core: early out on out of bounds scaling parameter (selsta)
| * | cryptonote_core: early out on out of bounds scaling parameterselsta2024-02-201-1/+2
| |/
* | Merge pull request #9178luigi11112024-02-244-15/+15
|\ \ | | | | | | | | | | | | | | | b987870 depends: openssl: update to 3.0.13 (tobtoht) 3aabfcf depends: unbound: update to 1.19.1 (tobtoht) 8322f9c depends: expat: update to 2.6.0 (tobtoht)
| * | depends: openssl: update to 3.0.13tobtoht2024-02-181-2/+2
| | |
| * | depends: unbound: update to 1.19.1tobtoht2024-02-182-7/+7
| | |
| * | depends: expat: update to 2.6.0tobtoht2024-02-181-6/+6
| |/
* | Merge pull request #9159luigi11112024-02-241-1/+1
|\ \ | | | | | | | | | fbd0b19 remove ARCH=x86-64 from release-static (woodser)
| * | remove ARCH=x86-64 from release-staticwoodser2024-02-101-1/+1
| |/
* | Merge pull request #9156luigi11112024-02-241-0/+4
|\ \ | | | | | | | | | 052df1b Zero initialize rctSigBase elements (Lee *!* Clagett)
| * | Zero initialize rctSigBase elementsLee *!* Clagett2024-02-061-0/+4
| |/
* | Merge pull request #9145luigi11112024-02-241-0/+1
|\ \ | | | | | | | | | f5b8634 Add <cstdint> to aligned test (Lee *!* Clagett)
| * | Add <cstdint> to aligned testLee *!* Clagett2024-01-291-0/+1
| |/
* | Merge pull request #9142luigi11112024-02-245-85/+52
|\ \ | | | | | | | | | 98ee46f Disable/fix ports with I2P (Lee Clagett)
| * | Disable/fix ports with I2PLee Clagett2024-01-305-85/+52
| |/
* | Merge pull request #9130luigi11112024-02-241-16/+43
|\ \ | | | | | | | | | dfb990e wallet: mitigate statistical dependence for decoy selection within rings (jeffro256)
| * | wallet: mitigate statistical dependence for decoy selection within ringsjeffro2562024-01-191-16/+43
| |/ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since we are required to check for uniqueness of decoy picks within any given ring, and since some decoy picks may fail due to unlock time or malformed EC points, the wallet2 decoy selection code was building up a larger than needed *unique* set of decoys for each ring according to a certain distribution *without replacement*. After filtering out the outputs that it couldn't use, it chooses from the remaining decoys uniformly random *without replacement*. The problem with this is that the picks later in the picking process are not independent from the picks earlier in the picking process, and the later picks do not follow the intended decoy distribution as closely as the earlier picks. To understand this intuitively, imagine that you have 1023 marbles. You label 512 marbles with the letter A, label 256 with the letter B, so on and so forth, finally labelling one marble with the letter J. You put them all into a bag, shake it well, and pick 8 marbles from the bag, but everytime you pick a marble of a certain letter, you remove all the other marbles from that bag with the same letter. That very first pick, the odds of picking a certain marble are exactly how you would expect: you are twice as likely to pick A as you are B, twice as likely to pick B as you are C, etc. However, on the second pick, the odds of getting the first pick are 0%, and the chances for everything else is higher. As you go down the line, your picked marbles will have letters that are increasingly more unlikely to pick if you hadn't remove the other marbles. In other words, the distribution of the later marbles will be more "skewed" in comparison to your original distribution of marbles. In Monero's decoy selection, this same statistical effect applies. It is not as dramatic since the distribution is not so steep, and we have more unique values to choose from, but the effect *is* measureable. Because of the protocol rules, we cannot have duplicate ring members, so unless that restriction is removed, we will never have perfectly independent picking. However, since the earlier picks are less affected by this statistical effect, the workaround that this commit offers is to store the order that the outputs were picked and commit to this order after fetching output information over RPC.
* | Merge pull request #9008luigi11112024-02-242-1/+5
|\ \ | | | | | | | | | | | | 9a89e2d wallet2: call on_reorg callback in handle_reorg (j-berman) 1df5630 wallet2: add on_reorg callback (Crypto City)
| * | wallet2: call on_reorg callback in handle_reorgj-berman2023-09-271-4/+4
| | |
| * | wallet2: add on_reorg callbackCrypto City2023-09-272-0/+4
| | |
* | | Merge pull request #8945luigi11112024-02-2410-43/+405
|\ \ \ | |_|/ |/| | | | | 51d7a69 wallet: feature: transfer amount with fee included (jeffro256)
| * | wallet: feature: transfer amount with fee includedjeffro2562024-02-2010-43/+405
|/ / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To transfer ~5 XMR to an address such that your balance drops by exactly 5 XMR, provide a `subtractfeefrom` flag to the `transfer` command. For example: transfer 76bDHojqFYiFCCYYtzTveJ8oFtmpNp3X1TgV2oKP7rHmZyFK1RvyE4r8vsJzf7SyNohMnbKT9wbcD3XUTgsZLX8LU5JBCfm 5 subtractfeefrom=all If my walet balance was exactly 30 XMR before this transaction, it will be exactly 25 XMR afterwards and the destination address will receive slightly less than 5 XMR. You can manually select which destinations fund the transaction fee and which ones do not by providing the destination index. For example: transfer 75sr8AAr... 3 74M7W4eg... 4 7AbWqDZ6... 5 subtractfeefrom=0,2 This will drop your balance by exactly 12 XMR including fees and will spread the fee cost proportionally (3:5 ratio) over destinations with addresses `75sr8AAr...` and `7AbWqDZ6...`, respectively. Disclaimer: This feature was paid for by @LocalMonero.
* | Merge pull request #9080luigi11112024-01-182-0/+208
|\ \ | | | | | | | | | 47d8899 Fix missing checks for IsObject in ZMQ jsonrpc reading (Lee Clagett)
| * | Fix missing checks for IsObject in ZMQ jsonrpc readingLee Clagett2023-11-282-0/+208
| | |
* | | Merge pull request #9053luigi11112024-01-181-6/+15
|\ \ \ | | | | | | | | | | | | fe746dc Fix EAGAIN bug in ZMQ-RPC/ZMQ-PUB (Lee *!* Clagett)
| * | | Fix EAGAIN bug in ZMQ-RPC/ZMQ-PUBLee *!* Clagett2023-11-041-6/+15
| | | |
* | | | Merge pull request #9051luigi11112023-11-061-0/+26
|\ \ \ \ | | | | | | | | | | | | | | | fe47806 wallet: fix multisig key memory leak (jeffro256)