monzero-core.git/src, branch v0.18.2.2Monzero core node, command-line wallet, consensus code, and release tooling.
https://code.monzero.org/monzero-core.git/atom?h=v0.18.2.22023-04-03T00:53:20ZMerge pull request #88052023-04-03T00:53:20Zluigi1111luigi1111w@gmail.com2023-04-03T00:53:20Zurn:sha1:e06129bb4d1076f4f2cebabddcee09f1e9e30dcc
4f1262b build: prepare v0.18.2.2 (selsta)
Merge pull request #88132023-04-03T00:46:21Zluigi1111luigi1111w@gmail.com2023-04-03T00:46:21Zurn:sha1:a371e60a3075a16e82f4489969899d3627116e7b
059b975 cryptonote core/protocol: don't drop peers for soft offenses (jeffro256)
cryptonote core/protocol: don't drop peers for soft offenses2023-03-29T07:07:15Zjeffro256jeffro256@tutanota.com2023-03-27T21:32:47Zurn:sha1:059b975388f346a4243273a75d86c16fd8e6990d
Also: txs with tx_extra which is too large will not get published to ZMQ
Co-authored-by: SChernykh <sergey.v.chernykh@gmail.com>
Fixed deadlock and crash when syncing with full dataset on Windows2023-03-29T06:44:20ZSChernykhsergey.v.chernykh@gmail.com2023-03-29T06:43:47Zurn:sha1:c742fa4c6ef83eb7f2495128a23d7cc250dc7db2
It's not allowed to use WaitForSingleObject with _beginthread, because the thread closes its own handle before exiting.
So the wait function will either wait on an invalid handle, or on a different handle used by something else.
Or, if it starts waiting before the thread exits, the behavior is undefined according to MS: "If this handle is closed while the wait is still pending, the function's behavior is undefined."
In my test sync I observed threads getting stuck infinitely on WaitForSingleObject, and then rx_set_main_seedhash spamming new threads when RandomX seed changes again. Eventually the system ran out of resources, and monerod aborted with "Couldn't start RandomX seed thread" message.
This PR fixes it by using `_beginthreadex` instead and explicitly closing the handle when it's safe.
build: prepare v0.18.2.22023-03-27T16:52:04Zselstaselsta@sent.at2023-03-27T16:52:04Zurn:sha1:4f1262bae9a02201b7ac91893dd4bb68dfb82b37wallet2: fix infinite loop in fake out selection2023-03-25T19:26:43ZCrypto Citycryptocity@example.com2023-03-21T09:02:38Zurn:sha1:132804811d141d29bef341fa5d30dd4b934beeb5
The gamma picker and the caller code did not quite agree on the
number of rct outputs available for use - by one block - which
caused an infinite loop if the picker could never pick outputs
from that block but already had picked all other outputs from
previous blocks.
Also change the range to select from using code from UkoeHB.
Merge pull request #87852023-03-25T02:55:49Zluigi1111luigi1111w@gmail.com2023-03-25T02:55:49Zurn:sha1:25645e5d2384d922ef20758ac8cf19296ee4b11e
cdeb286 build: prepare v0.18.2.1 (selsta)
Merge pull request #87872023-03-25T02:55:29Zluigi1111luigi1111w@gmail.com2023-03-25T02:55:29Zurn:sha1:0e2c2ddd9cddf8915cbc49b966421633a4505c77
c4cfaa4 p2p: do not log to global when re-blocking a subnet (moneromooo-monero)
f0e326b p2p: avoid spam blocking ipv4 addresses in a blocked subnet (moneromooo-monero)
p2p: do not log to global when re-blocking a subnet2023-03-19T01:58:38Zmoneromooo-moneromoneromooo-monero@users.noreply.github.com2023-03-09T17:17:59Zurn:sha1:c4cfaa4567106d53f397b1e61f9ed9ea76dae579p2p: avoid spam blocking ipv4 addresses in a blocked subnet2023-03-19T01:58:38Zmoneromooo-moneromoneromooo-monero@users.noreply.github.com2023-03-01T16:56:17Zurn:sha1:f0e326be58f5ac78e3aa1de29db848a895f5e62b