monzero-core.git/src/ringct/rctSigs.cpp, branch crash-pl

Merge pull request #3372

2018-03-14T14:06:16Z

c3e23b2d ringct: 17% improvement in Borromean signature verification (moneromooo-monero)

device: untangle cyclic depenency

2018-03-14T12:00:15Z

When #3303 was merged, a cyclic dependency chain was generated: libdevice <- libcncrypto <- libringct <- libdevice This was because libdevice needs access to a set of basic crypto operations implemented in libringct such as scalarmultBase(), while libringct also needs access to abstracted crypto operations implemented in libdevice such as ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct into libringct_basic and libringct, where the basic crypto ops previously in libringct are moved into libringct_basic. The cyclic dependency is now resolved thanks to this separation: libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct This eliminates the need for crypto_device.cpp and rctOps_device.cpp. Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and get_subaddress_secret_key() were previously implemented in libcryptonote_basic (cryptonote_format_utils.cpp) and were then called from hw::core::device_default, which is odd because libdevice is supposed to be independent of libcryptonote_basic. Therefore, those functions were moved to device_default.cpp.

ringct: 17% improvement in Borromean signature verification

2018-03-08T00:41:54Z

Merge pull request #3348

2018-03-05T17:13:52Z

c95dddd2 remove unused function keyImageV (h908714124)

Merge pull request #3301

2018-03-05T17:11:35Z

34a2a085 rctSigs - loop invariant code removed from the loop (Dusan Klinec)

remove unused function keyImageV

2018-03-05T08:21:44Z

Code modifications to integrate Ledger HW device into monero-wallet-cli.

2018-03-04T11:54:53Z

The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.

rctSigs - loop invariant code removed from the loop

2018-02-21T15:35:06Z

ringct: pseudoOuts moved to prunable in the simple bulletproof case

2018-01-31T15:56:26Z

Saves 64 bytes non prunable data per typical tx This breaks v7 consensus, will require a testnet reorg from v6

ringct: handle exceptions verifying bulletproofs in worker threads

2018-01-15T11:48:23Z