monzero-core.git/src/device/device_default.cpp, branch crash-pl

Fix sub-address tx scan.

2018-04-12T11:58:57Z

When additional keys was needed, the TX scan failed because the derivation data was always recomputed with the main tx_key and not the corresponding additional one. Moreover this patch avoid perf decreasing when not using HW device.

Merge pull request #3511

2018-04-12T09:15:27Z

0beb94f3 device: fix endianess dependence on subaddress secret key generation (moneromooo-monero)

Add the possibility to export private view key for fast scan.

2018-03-31T16:00:33Z

On client startup the device asks for authorization to export the private view key. If user agree, the client hold the private view key allowing a fast blockchain scan. If the user does not agree, the blockchain scan is fully done via the device.

Change mutex lock model to avoid dead lock and ensure locks are always released.

2018-03-31T16:00:33Z

Additional cosmetic fixes: move 'name' as protected remove unnecessary local var Fix debug log

device: fix endianess dependence on subaddress secret key generation

2018-03-28T10:14:25Z

We now force little endianness

keypair::generate: always require hw::device to avoid possible mistake

2018-03-14T12:00:16Z

device: untangle cyclic depenency

2018-03-14T12:00:15Z

When #3303 was merged, a cyclic dependency chain was generated: libdevice <- libcncrypto <- libringct <- libdevice This was because libdevice needs access to a set of basic crypto operations implemented in libringct such as scalarmultBase(), while libringct also needs access to abstracted crypto operations implemented in libdevice such as ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct into libringct_basic and libringct, where the basic crypto ops previously in libringct are moved into libringct_basic. The cyclic dependency is now resolved thanks to this separation: libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct This eliminates the need for crypto_device.cpp and rctOps_device.cpp. Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and get_subaddress_secret_key() were previously implemented in libcryptonote_basic (cryptonote_format_utils.cpp) and were then called from hw::core::device_default, which is odd because libdevice is supposed to be independent of libcryptonote_basic. Therefore, those functions were moved to device_default.cpp.

device: made function prototypes consistent with pre-#3303 codebase

2018-03-14T12:00:06Z

Ledger HW Bug fixes

2018-03-12T09:43:06Z

Fix the way the REAL mode is handle: Let create_transactions_2 and create_transactions_from construct the vector of transactions. Then iterate on it and resign. We just need to add 'outs' list in the TX struct for that. Fix default secret keys value when DEBUG_HWDEVICE mode is off The magic value (00...00 for view key and FF..FF for spend key) was not correctly set when DEBUG_HWDEVICE was off. Both was set to 00...00. Add sub-address info in ABP map in order to correctly display destination sub-address on device Fix DEBUG_HWDEVICE mode: - Fix compilation errors. - Fix control device init in ledger device. - Add more log. Fix sub addr control Fix debug Info

Fix invalid device unique_ptr cast

2018-03-04T18:56:48Z