monzero-core.git/src/daemonizer/posix_fork.cpp, branch v0.18.1.2Monzero core node, command-line wallet, consensus code, and release tooling.
https://code.monzero.org/monzero-core.git/atom?h=v0.18.1.22019-11-17T14:04:22ZFix #6147 DB corruption from child process overwrite2019-11-17T14:04:22ZHoward Chuhyc@symas.com2019-11-17T11:41:09Zurn:sha1:47d094c0c40605572f2fe3a9d62cb5c96ef37de8
Don't leave stdout/stderr dangling on a fork.
Removed a lot of unnecessary includes2018-11-15T16:29:34ZMartijn Ottogit@martijnotto.nl2018-11-15T16:29:34Zurn:sha1:bd98e99c8095cf05c4d3282c888a87745ad1c559monerod: do not log to tmpdir in daemon mode2018-02-23T20:27:14Zston1thston1th@giftfish.de2018-02-13T18:54:49Zurn:sha1:496055d12871eca27b024fd2f746a8e5d07e5714
The logging to /tmp/bitmonero.daemon.stdout.stderr caused segfaults
if the /tmp mount was full (#2851).
Now the daemon is only logging to /tmp/bitmonero.daemon.stdout.stderr
in the debug builds.
daemon: Add ability to write a PID file2017-07-21T22:34:56ZErik de Castro Lopoerikd@mega-nerd.com2017-07-19T11:45:00Zurn:sha1:51efb21713ee630ca9c2f6aaaea98f18bce72106
The PID file will only be written if the daemon is called with the
`--detach` command line argument and a `--pidfile /some/file/path`
argument.
Don't hardcode /tmp2017-07-11T11:38:51ZHoward Chuhyc@symas.com2017-07-11T11:38:51Zurn:sha1:33d17c37e80acc8d810d870eee5f5aac202f7804daemonizer: posix: keep parent's working dir and umask2016-07-10T00:16:44Zredfishredfish@galactica.pw2016-07-10T00:09:56Zurn:sha1:ce6b83128e343687d526479f1a308d838a38f02a
Keep the working directory (and umask) inherited from
the parent. Otherwise, it's impossible to control
the working directory of the daemon (from systemd, for
example).
Furthermoer, bitmonerod attempts to create logging directories and files
*in current working directory*. This fails due to permission denied and
generates a (caught, nonfatal) exception. Below is the strace with this
patch applied (so, no `chdir("/")`), showing successful opens at `log/`
relative path. Without this patch they fail (sorry, didn't save the
trace).
```
28911 getcwd("/.../bitmonero", 128) = 25
28911 stat64("/var/lib/bitmonero/.bitmonero", {st_mode=S_IFDIR|0755, st_size=4096, ...}) = 0
28911 stat64("/etc/bitmonerod.conf", {st_mode=S_IFREG|0644, st_size=244, ...}) = 0
28911 open("/etc/bitmonerod.conf", O_RDONLY|O_LARGEFILE) = 3
28911 open("/var/log/bitmonero/bitmonero.log", O_WRONLY|O_CREAT|O_APPEND|O_LARGEFILE, 0666) = 3
28911 stat64("log", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0
28911 stat64("log/dbg", {st_mode=S_IFDIR|0700, st_size=4096, ...}) = 0
28911 open("log/dbg/main.log", O_WRONLY|O_CREAT|O_TRUNC|O_LARGEFILE, 0666) = 4
```
The reasoning of chdir("/") in order to prevent the daemon from holding
a filesystem in busy state is not compelling at all: the choice of
working directory for the daemon is the user's business not the
daemon's.
Revert "Print stack trace upon exceptions"2016-03-21T10:12:23Zmoneromooo-moneromoneromooo-monero@users.noreply.github.com2016-03-21T10:12:12Zurn:sha1:f7301c3563e7ae19b8d7c65d8bc88f3c42eefc09
Ain't nobody got time for link/cmake skullduggery.
This reverts commit fff238ec94ac6d45fc18c315d7bc590ddfaad63d.
Print stack trace upon exceptions2016-03-19T21:48:36Zmoneromooo-moneromoneromooo-monero@users.noreply.github.com2016-03-19T21:48:36Zurn:sha1:fff238ec94ac6d45fc18c315d7bc590ddfaad63d
Useful for debugging users' logs
Daemonize changes pulled in -- daemon builds2015-02-24T05:05:19ZThomas Wingettewinget@gmail.com2015-01-29T22:10:53Zurn:sha1:9193d6fb5be92df732af18b08b1e052f84cc2f9d
many RPC functions added by the daemonize changes
(and related changes on the upstream dev branch that were not merged)
were commented out (apart from return). Other than that, this *should*
work...at any rate, it builds, and that's something.