monzero-core.git/src/cryptonote_core/cryptonote_tx_utils.cpp, branch v0.13.0.2

Merge pull request #4476

2018-10-02T20:45:48Z

fa9e54b6 build: fix gcc false positive 'stringop-overflow' warning (xiphon)

v8: per byte fee, pad bulletproofs, fixed 11 ring size

2018-09-11T13:38:07Z

Bulletproof aggregated verification and tests

2018-09-11T13:37:37Z

Also constrains bulletproofs to simple rct, for simplicity

bulletproofs: add multi output bulletproofs to rct

2018-09-11T13:37:28Z

Do memwipe for critical secret keys copied to rct::key

2018-08-16T13:26:30Z

Fix output shuffling for multisig

2018-05-20T00:38:41Z

cryptonote_tx_util: make destinations properly shuffled

2018-03-31T09:37:46Z

keypair::generate: always require hw::device to avoid possible mistake

2018-03-14T12:00:16Z

device: untangle cyclic depenency

2018-03-14T12:00:15Z

When #3303 was merged, a cyclic dependency chain was generated: libdevice <- libcncrypto <- libringct <- libdevice This was because libdevice needs access to a set of basic crypto operations implemented in libringct such as scalarmultBase(), while libringct also needs access to abstracted crypto operations implemented in libdevice such as ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct into libringct_basic and libringct, where the basic crypto ops previously in libringct are moved into libringct_basic. The cyclic dependency is now resolved thanks to this separation: libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct This eliminates the need for crypto_device.cpp and rctOps_device.cpp. Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and get_subaddress_secret_key() were previously implemented in libcryptonote_basic (cryptonote_format_utils.cpp) and were then called from hw::core::device_default, which is odd because libdevice is supposed to be independent of libcryptonote_basic. Therefore, those functions were moved to device_default.cpp.

Ledger HW Bug fixes

2018-03-12T09:43:06Z

Fix the way the REAL mode is handle: Let create_transactions_2 and create_transactions_from construct the vector of transactions. Then iterate on it and resign. We just need to add 'outs' list in the TX struct for that. Fix default secret keys value when DEBUG_HWDEVICE mode is off The magic value (00...00 for view key and FF..FF for spend key) was not correctly set when DEBUG_HWDEVICE was off. Both was set to 00...00. Add sub-address info in ABP map in order to correctly display destination sub-address on device Fix DEBUG_HWDEVICE mode: - Fix compilation errors. - Fix control device init in ledger device. - Add more log. Fix sub addr control Fix debug Info