monzero-core.git/src/crypto/crypto.h, branch crash-pl

crypto: revert odd namespace changes made in #3303

2018-03-14T12:00:17Z

device: untangle cyclic depenency

2018-03-14T12:00:15Z

When #3303 was merged, a cyclic dependency chain was generated: libdevice <- libcncrypto <- libringct <- libdevice This was because libdevice needs access to a set of basic crypto operations implemented in libringct such as scalarmultBase(), while libringct also needs access to abstracted crypto operations implemented in libdevice such as ecdhEncode(). To untangle this cyclic dependency chain, this patch splits libringct into libringct_basic and libringct, where the basic crypto ops previously in libringct are moved into libringct_basic. The cyclic dependency is now resolved thanks to this separation: libcncrypto <- libringct_basic <- libdevice <- libcryptonote_basic <- libringct This eliminates the need for crypto_device.cpp and rctOps_device.cpp. Also, many abstracted interfaces of hw::device such as encrypt_payment_id() and get_subaddress_secret_key() were previously implemented in libcryptonote_basic (cryptonote_format_utils.cpp) and were then called from hw::core::device_default, which is odd because libdevice is supposed to be independent of libcryptonote_basic. Therefore, those functions were moved to device_default.cpp.

Code modifications to integrate Ledger HW device into monero-wallet-cli.

2018-03-04T11:54:53Z

The basic approach it to delegate all sensitive data (master key, secret ephemeral key, key derivation, ....) and related operations to the device. As device has low memory, it does not keep itself the values (except for view/spend keys) but once computed there are encrypted (with AES are equivalent) and return back to monero-wallet-cli. When they need to be manipulated by the device, they are decrypted on receive. Moreover, using the client for storing the value in encrypted form limits the modification in the client code. Those values are transfered from one C-structure to another one as previously. The code modification has been done with the wishes to be open to any other hardware wallet. To achieve that a C++ class hw::Device has been introduced. Two initial implementations are provided: the "default", which remaps all calls to initial Monero code, and the "Ledger", which delegates all calls to Ledger device.

Update 2018 copyright

2018-01-26T15:03:20Z

move memwipe to epee to avoid common<->crypto circular dependencies

2018-01-10T01:57:54Z

Scrub keys from memory just before scope end.

2017-12-16T22:40:33Z

Partially implements #74. Securely erases keys from memory after they are no longer needed. Might have a performance impact, which I haven't measured (perf measurements aren't generally reliable on laptops). Thanks to @stoffu for the suggestion to specialize the pod_to_hex/hex_to_pod functions. Using overloads + SFINAE instead generalizes it so other types can be marked as scrubbed without adding more boilerplate.

Subaddresses

2017-10-07T04:06:21Z

move checkpoints in a separate library

2017-09-25T20:16:26Z

Signature proving payment to destination by only revealing key derivation, not the actual tx secret key

2017-06-22T09:11:13Z

update copyright year, fix occasional lack of newline at line end

2017-02-21T17:38:18Z