monzero-core.git, branch v0.18.3.0Monzero core node, command-line wallet, consensus code, and release tooling.
https://code.monzero.org/monzero-core.git/atom?h=v0.18.3.02023-09-30T18:45:43ZMerge pull request #90012023-09-30T18:45:43Zluigi1111luigi1111w@gmail.com2023-09-30T18:45:43Zurn:sha1:f9b81a589e19f660ed803f505c8c2a1b309c3bed
3f9140e storages: change error log category to serialization (selsta)
It's over 9000!!!
Merge pull request #89992023-09-30T18:44:32Zluigi1111luigi1111w@gmail.com2023-09-30T18:44:32Zurn:sha1:41157dbc82fa2cb514ba0725210d9ae0316708a8
205c804 wallet: store watch-only wallet correctly when change_password() is called (jeff)
storages: change error log category to serialization2023-09-22T17:09:27Zselstaselsta@sent.at2023-09-22T17:05:55Zurn:sha1:3f9140e754769baa84d75f072f45c8fe63d13f60wallet: store watch-only wallet correctly when `change_password()` is called2023-09-22T14:20:56Zjeffjeffro256@tutanota.com2023-09-22T03:33:00Zurn:sha1:205c80427ba6f5751d1aef800f1dd00d736a3ca9
The Monero GUI code was calling `Monero::wallet::setPassword()` on every open/close for some reason,
and the old `store_to()` code called `store_keys()` with `watch_only=false`, even for watch-only wallets.
This caused a bug where the watch-only keys file got saved with with the JSON field `watch_only` set to 0,
and after saving a watch-only wallet once, a user could never open it back up against because `load()` errored out.
This never got brought up before this because you would have to change the file location of the watch-only
wallet to see this bug, and I guess that didn't happen often, but calling the new `store_to()` function with the
new `force_rewrite` parameter set to `true` triggers key restoring and the bug appeared.
Merge pull request #89882023-09-15T03:21:06Zluigi1111luigi1111w@gmail.com2023-09-15T03:21:06Zurn:sha1:533bbc3208191dfddb3a60e939078c86873b6946
64ed938 build: prepare v0.18.3.0 (selsta)
Merge pull request #89772023-09-15T03:20:38Zluigi1111luigi1111w@gmail.com2023-09-15T03:20:38Zurn:sha1:6e7bd68b183272dab2ac12c236505aa8f260998b
7dbb14b functional_tests: fix multisig tests noutputs assertion (jeffro256)
Merge pull request #89412023-09-15T03:19:27Zluigi1111luigi1111w@gmail.com2023-09-15T03:19:27Zurn:sha1:031d318ca2cd6427fd91543e82eda0a9538fa73b
356e687 wallet_rpc_server: chunk refresh to keep responding to RPC while refreshing (moneromooo-monero) 633e1b7 wallet_rpc_server: add --no-initial-sync flag for quicker network binding (moneromooo-monero)
Merge pull request #89382023-09-15T03:18:22Zluigi1111luigi1111w@gmail.com2023-09-15T03:18:22Zurn:sha1:61e664a258aed020d3d346d319034c4adf28b1be
ba98269 wallet2: fix store_to() and change_password() (jeffro256)
build: prepare v0.18.3.02023-09-10T16:30:34Zselstaselsta@sent.at2023-09-10T13:55:30Zurn:sha1:64ed9385a204920499dd2b3f0c5f71030fdbe9f4wallet2: fix `store_to()` and `change_password()`2023-08-23T16:52:31Zjeffro256jeffro256@tutanota.com2023-07-07T17:55:02Zurn:sha1:ba98269ca507766aa76f0ebbcaebe6f6eef93192
Resolves #8932 and:
2. Not storing cache when new path is different from old in `store_to()` and
3. Detecting same path when new path contains entire string of old path in `store_to()` and
4. Changing your password / decrypting your keys (in this method or others) and providing a bad original password and getting no error and
5. Changing your password and storing to a new file